]> granicus.if.org Git - postgresql/commit
Correct some code in pg_restore when reading the header of a tar archive:
authorNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:00:47 +0000 (02:00 +0000)
committerNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:00:47 +0000 (02:00 +0000)
commit05db8b501b7807cf730a7c1b8a95d05ca694070b
tree23e0841dbc09e2da8d40a3e574fcc94c54f9d245
parent06ecacded604d6d04b77e119a87a78f759b6b171
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
    match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
    the first byte of the tar block 512 times, rather than each of the
    512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.
src/bin/pg_dump/pg_backup_tar.c