]> granicus.if.org Git - postgresql/commit
Fix use of dangling pointer in heap_delete() when logging replica identity
authorMichael Paquier <michael@paquier.xyz>
Fri, 1 Feb 2019 01:36:02 +0000 (10:36 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 1 Feb 2019 01:36:02 +0000 (10:36 +0900)
commit05d24cf7ca7aae4f6842dfbd0962a9d04511ba78
tree6d02ab64fb347d3d0700333a13afd025d856b995
parent452253eae95a3dd36b52606c91844af5f647d7fa
Fix use of dangling pointer in heap_delete() when logging replica identity

When logging the replica identity of a deleted tuple, XLOG_HEAP_DELETE
records include references of the old tuple.  Its data is stored in an
intermediate variable used to register this information for the WAL
record, but this variable gets away from the stack when the record gets
actually inserted.

Spotted by clang's AddressSanitizer.

Author: Stas Kelvish
Discussion: https://postgr.es/m/085C8825-AD86-4E93-AF80-E26CDF03D1EA@postgrespro.ru
Backpatch-through: 9.4
src/backend/access/heap/heapam.c