]> granicus.if.org Git - clang/commit
[Sema] Document+test the -Wsign-compare change for enums in C code [NFC]
authorRoman Lebedev <lebedev.ri@gmail.com>
Tue, 24 Oct 2017 21:05:43 +0000 (21:05 +0000)
committerRoman Lebedev <lebedev.ri@gmail.com>
Tue, 24 Oct 2017 21:05:43 +0000 (21:05 +0000)
commit05b3b1db31719cae8568468f036fb55c99017fe0
treeaf4e790cb2b1dbc291692cccf70e2191dea4a6b7
parent3692af84cecf2239927281bdb9679f618811f9f5
[Sema] Document+test the -Wsign-compare change for enums in C code [NFC]

rL316268 / D39122 has fixed PR35009, and now when in C,
these three(?) diagnostics properly use the enum's underlying
datatype.

While it was fixed, the test coverage was clearly insufficient,
because the -Wsign-compare change didn't show up in any of the
tests, until it was reported in the post-commit mail for rL316268.

So add the test for the -Wsign-compare diagnostic for enum
for C code, and while there, document this in the release notes.

The fix itself was obviously correct, so unless we want to silence
this new diagnosed case, i deem this commit to be NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316500 91177308-0d34-0410-b5e6-96231b3b80d8
docs/ReleaseNotes.rst
test/Sema/sign-compare-enum.c [new file with mode: 0644]