]> granicus.if.org Git - postgresql/commit
Improve pg_dump's checkSeek() function to verify the functioning of ftello
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2010 02:07:02 +0000 (02:07 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2010 02:07:02 +0000 (02:07 +0000)
commit04d9f4dab4723a0736157542b1d1a24ad2b8aa1d
tree6d28a971442116455da1c612ff5da6558a47d8fc
parentb779ea8a9a2dc3a089b3ac152b1ec4568bfeb26f
Improve pg_dump's checkSeek() function to verify the functioning of ftello
as well as fseeko, and to not assume that fseeko(fp, 0, SEEK_CUR) proves
anything.  Also improve some related comments.  Per my observation that
the SEEK_CUR test didn't actually work on some platforms, and subsequent
discussion with Robert Haas.

Back-patch to 8.4.  In earlier releases it's not that important whether
we get the hasSeek test right, but with parallel restore it matters.
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_backup_custom.c