]> granicus.if.org Git - postgresql/commit
Fix some more bugs in signal handlers and process shutdown logic.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Feb 2014 21:21:07 +0000 (16:21 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Feb 2014 21:21:38 +0000 (16:21 -0500)
commit03f06ff383eaeb80e1ad1f2aa496ab0cb283f3da
treeff3b88b02f2c581de8fb8a53ee15e4b1da3ce2df
parente5c22c15d863fc557b9510cc5865c23803766b04
Fix some more bugs in signal handlers and process shutdown logic.

WalSndKill was doing things exactly backwards: it should first clear
MyWalSnd (to stop signal handlers from touching MyWalSnd->latch),
then disown the latch, and only then mark the WalSnd struct unused by
clearing its pid field.

Also, WalRcvSigUsr1Handler and worker_spi_sighup failed to preserve
errno, which is surely a requirement for any signal handler.

Per discussion of recent buildfarm failures.  Back-patch as far
as the relevant code exists.
src/backend/replication/walsender.c