]> granicus.if.org Git - postgresql/commit
Fix unportable shell-script syntax in pg_upgrade's test.sh.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:55:02 +0000 (21:55 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:55:27 +0000 (21:55 -0400)
commit0268d21e5d3c732bf5543d68a6d870e4eee7e673
tree45a64b0fc5e47fb20be31686a03bd482fe0140bd
parent2861e8e9cb7bcf7ca7839378743a4a881b67edcf
Fix unportable shell-script syntax in pg_upgrade's test.sh.

I discovered the hard way that on some old shells, the locution
    FOO=""   unset FOO
does not behave the same as
    FOO="";  unset FOO
and in fact leaves FOO set to an empty string.  test.sh was inconsistently
spelling it different ways on adjacent lines.

This got broken relatively recently, in commit c737a2e56, so the lack of
field reports to date doesn't represent a lot of evidence that the problem
is rare.
contrib/pg_upgrade/test.sh