]> granicus.if.org Git - postgresql/commit
Disallow starting server with insufficient wal_level for existing slot.
authorAndres Freund <andres@anarazel.de>
Wed, 31 Oct 2018 21:47:41 +0000 (14:47 -0700)
committerAndres Freund <andres@anarazel.de>
Wed, 31 Oct 2018 22:46:40 +0000 (15:46 -0700)
commit021e1c329d7c5e9a72cc7c7bd21d4604d087635f
tree74e5fc062bbfd5ccc91946c73337f778627d80da
parent92e371f9b143dacd83ec14ef8c7caba9612d9294
Disallow starting server with insufficient wal_level for existing slot.

Previously it was possible to create a slot, change wal_level, and
restart, even if the new wal_level was insufficient for the
slot. That's a problem for both logical and physical slots, because
the necessary WAL records are not generated.

This removes a few tests in newer versions that, somewhat
inexplicably, whether restarting with a too low wal_level worked (a
buggy behaviour!).

Reported-By: Joshua D. Drake
Author: Andres Freund
Discussion: https://postgr.es/m/20181029191304.lbsmhshkyymhw22w@alap3.anarazel.de
Backpatch: 9.4-, where replication slots where introduced
src/backend/replication/logical/logical.c
src/backend/replication/slot.c
src/test/recovery/t/006_logical_decoding.pl