]> granicus.if.org Git - zfs/commit - lib/libzfs/libzfs_pool.c
Fix `zpool status -v` error message
authorBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 23 Mar 2017 01:08:55 +0000 (18:08 -0700)
committerGitHub <noreply@github.com>
Thu, 23 Mar 2017 01:08:55 +0000 (18:08 -0700)
commit56a6054d553fd7f1cf7d7c86bf4b33951e1d009f
tree33b2b34135d17657627af099793c520c86756283
parent6a9d6359982cbff298dd17f68c3103d1269602fa
Fix `zpool status -v` error message

When a pool is suspended it's impossible to read the list
of damaged files from disk.  This would result in a generic
misleading "insufficient permissions" error message.

Update zpool_get_errlog() to use the standard zpool error
logging functions to generate a useful error message.  In
this case:

  errors: List of errors unavailable: pool I/O is currently suspended

This patch does not address the related issue of potentially
not being able to resume a suspend pool when the underlying
device names have changed.

Additionally, remove the error handling from zfs_alloc()
in zpool_get_errlog() for readability since this function
can never fail.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #4031
Closes #5731
Closes #5907
cmd/zpool/zpool_main.c
lib/libzfs/libzfs_pool.c