]> granicus.if.org Git - postgresql/commit - contrib/bloom/blinsert.c
Revert no-op changes to BufferGetPage()
authorKevin Grittner <kgrittn@postgresql.org>
Wed, 20 Apr 2016 13:31:19 +0000 (08:31 -0500)
committerKevin Grittner <kgrittn@postgresql.org>
Wed, 20 Apr 2016 13:31:19 +0000 (08:31 -0500)
commita343e223a5c33a7283a6d8b255c9dbc48dbc5061
treef02f3de305180170d8d5e51120861ae6770b31e8
parent4db0d2d2fe935e086dfd26c00f707dab298b443c
Revert no-op changes to BufferGetPage()

The reverted changes were intended to force a choice of whether any
newly-added BufferGetPage() calls needed to be accompanied by a
test of the snapshot age, to support the "snapshot too old"
feature.  Such an accompanying test is needed in about 7% of the
cases, where the page is being used as part of a scan rather than
positioning for other purposes (such as DML or vacuuming).  The
additional effort required for back-patching, and the doubt whether
the intended benefit would really be there, have indicated it is
best just to rely on developers to do the right thing based on
comments and existing usage, as we do with many other conventions.

This change should have little or no effect on generated executable
code.

Motivated by the back-patching pain of Tom Lane and Robert Haas
65 files changed:
contrib/bloom/blinsert.c
contrib/bloom/blscan.c
contrib/bloom/blutils.c
contrib/bloom/blvacuum.c
contrib/pageinspect/btreefuncs.c
contrib/pageinspect/rawpage.c
contrib/pg_visibility/pg_visibility.c
contrib/pgstattuple/pgstatapprox.c
contrib/pgstattuple/pgstatindex.c
contrib/pgstattuple/pgstattuple.c
src/backend/access/brin/brin.c
src/backend/access/brin/brin_pageops.c
src/backend/access/brin/brin_revmap.c
src/backend/access/brin/brin_xlog.c
src/backend/access/gin/ginbtree.c
src/backend/access/gin/gindatapage.c
src/backend/access/gin/ginentrypage.c
src/backend/access/gin/ginfast.c
src/backend/access/gin/ginget.c
src/backend/access/gin/gininsert.c
src/backend/access/gin/ginutil.c
src/backend/access/gin/ginvacuum.c
src/backend/access/gin/ginxlog.c
src/backend/access/gist/gist.c
src/backend/access/gist/gistbuild.c
src/backend/access/gist/gistget.c
src/backend/access/gist/gistutil.c
src/backend/access/gist/gistvacuum.c
src/backend/access/gist/gistxlog.c
src/backend/access/hash/hash.c
src/backend/access/hash/hashinsert.c
src/backend/access/hash/hashovfl.c
src/backend/access/hash/hashpage.c
src/backend/access/hash/hashsearch.c
src/backend/access/hash/hashutil.c
src/backend/access/heap/heapam.c
src/backend/access/heap/hio.c
src/backend/access/heap/pruneheap.c
src/backend/access/heap/visibilitymap.c
src/backend/access/nbtree/nbtinsert.c
src/backend/access/nbtree/nbtpage.c
src/backend/access/nbtree/nbtree.c
src/backend/access/nbtree/nbtsearch.c
src/backend/access/nbtree/nbtutils.c
src/backend/access/nbtree/nbtxlog.c
src/backend/access/spgist/spgdoinsert.c
src/backend/access/spgist/spginsert.c
src/backend/access/spgist/spgscan.c
src/backend/access/spgist/spgutils.c
src/backend/access/spgist/spgvacuum.c
src/backend/access/spgist/spgxlog.c
src/backend/access/transam/generic_xlog.c
src/backend/access/transam/xloginsert.c
src/backend/access/transam/xlogutils.c
src/backend/catalog/index.c
src/backend/commands/analyze.c
src/backend/commands/sequence.c
src/backend/commands/trigger.c
src/backend/commands/vacuumlazy.c
src/backend/executor/nodeBitmapHeapscan.c
src/backend/executor/nodeSamplescan.c
src/backend/storage/buffer/bufmgr.c
src/backend/storage/freespace/freespace.c
src/backend/storage/freespace/fsmpage.c
src/include/storage/bufmgr.h