]> granicus.if.org Git - strace/blobdiff - unwind.c
mem: decode hugetlb page size in mmap flags
[strace] / unwind.c
index 6f422a1cf937dfc52cb44d312752605c2fd6d08a..919b63c366978d4524dd91d8c9402f8b51534bff 100644 (file)
--- a/unwind.c
+++ b/unwind.c
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2013 Luca Clementi <luca.clementi@gmail.com>
+ * Copyright (c) 2013-2017 The strace developers.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
 # define fopen_for_input fopen
 #endif
 
-#define DPRINTF(F, A, ...) if (debug_flag) fprintf(stderr, " [unwind(" A ")] " F "\n", __VA_ARGS__)
+#define DPRINTF(F, A, ...)                                             \
+       do {                                                            \
+               if (debug_flag)                                         \
+                       error_msg("[unwind(" A ")] " F, __VA_ARGS__);   \
+       } while (0)
 
 /*
- * Кeep a sorted array of cache entries,
+ * Keep a sorted array of cache entries,
  * so that we can binary search through it.
  */
 struct mmap_cache_t {
@@ -76,13 +81,13 @@ typedef void (*error_action_fn)(void *data,
  * Type used in stacktrace capturing
  */
 struct call_t {
-       struct call_tnext;
-       char *output_line;
+       struct call_t *next;
+       char *output_line;
 };
 
 struct queue_t {
-       struct call_t *tail;
-       struct call_t *head;
+       struct call_t *tail;
+       struct call_t *head;
 };
 
 static void queue_print(struct queue_t *queue);
@@ -103,13 +108,14 @@ unwind_init(void)
 void
 unwind_tcb_init(struct tcb *tcp)
 {
+       if (tcp->libunwind_ui)
+               return;
+
        tcp->libunwind_ui = _UPT_create(tcp->pid);
        if (!tcp->libunwind_ui)
-               die_out_of_memory();
+               perror_msg_and_die("_UPT_create");
 
-       tcp->queue = malloc(sizeof(*tcp->queue));
-       if (!tcp->queue)
-               die_out_of_memory();
+       tcp->queue = xmalloc(sizeof(*tcp->queue));
        tcp->queue->head = NULL;
        tcp->queue->tail = NULL;
 }
@@ -121,7 +127,7 @@ unwind_tcb_fin(struct tcb *tcp)
        free(tcp->queue);
        tcp->queue = NULL;
 
-       delete_mmap_cache(tcp, __FUNCTION__);
+       delete_mmap_cache(tcp, __func__);
 
        _UPT_destroy(tcp->libunwind_ui);
        tcp->libunwind_ui = NULL;
@@ -134,7 +140,7 @@ unwind_tcb_fin(struct tcb *tcp)
  * e.g. mmap, mprotect, munmap, execve.
  */
 static void
-build_mmap_cache(struct tcbtcp)
+build_mmap_cache(struct tcb *tcp)
 {
        FILE *fp;
        struct mmap_cache_t *cache_head;
@@ -152,15 +158,13 @@ build_mmap_cache(struct tcb* tcp)
                return;
        }
 
-       cache_head = calloc(cur_array_size, sizeof(*cache_head));
-       if (!cache_head)
-               die_out_of_memory();
+       cache_head = xcalloc(cur_array_size, sizeof(*cache_head));
 
        while (fgets(buffer, sizeof(buffer), fp) != NULL) {
                struct mmap_cache_t *entry;
                unsigned long start_addr, end_addr, mmap_offset;
                char exec_bit;
-               char binary_path[PATH_MAX];
+               char binary_path[sizeof(buffer)];
 
                if (sscanf(buffer, "%lx-%lx %*c%*c%c%*c %lx %*x:%*x %*d %[^\n]",
                           &start_addr, &end_addr, &exec_bit,
@@ -197,19 +201,15 @@ build_mmap_cache(struct tcb* tcp)
 
                if (tcp->mmap_cache_size >= cur_array_size) {
                        cur_array_size *= 2;
-                       cache_head = realloc(cache_head,
-                                            cur_array_size * sizeof(*cache_head));
-                       if (!cache_head)
-                               die_out_of_memory();
+                       cache_head = xreallocarray(cache_head, cur_array_size,
+                                                  sizeof(*cache_head));
                }
 
                entry = &cache_head[tcp->mmap_cache_size];
                entry->start_addr = start_addr;
                entry->end_addr = end_addr;
                entry->mmap_offset = mmap_offset;
-               entry->binary_filename = strdup(binary_path);
-               if (!entry->binary_filename)
-                       die_out_of_memory();
+               entry->binary_filename = xstrdup(binary_path);
                tcp->mmap_cache_size++;
        }
        fclose(fp);
@@ -261,7 +261,7 @@ rebuild_cache_if_invalid(struct tcb *tcp, const char *caller)
 }
 
 void
-unwind_cache_invalidate(struct tcbtcp)
+unwind_cache_invalidate(struct tcb *tcp)
 {
 #if SUPPORTED_PERSONALITIES > 1
        if (tcp->currpers != DEFAULT_PERSONALITY) {
@@ -290,10 +290,8 @@ get_symbol_name(unw_cursor_t *cursor, char **name,
                        *offset = 0;
                        break;
                }
+               *name = xreallocarray(*name, 2, *size);
                *size *= 2;
-               *name = realloc(*name, *size);
-               if (!*name)
-                       die_out_of_memory();
        }
 }
 
@@ -336,8 +334,7 @@ print_stack_frame(struct tcb *tcp,
                                    function_offset,
                                    true_offset);
                        return 0;
-               }
-               else if (ip < cur_mmap_cache->start_addr)
+               } else if (ip < cur_mmap_cache->start_addr)
                        upper = mid - 1;
                else
                        lower = mid + 1;
@@ -348,7 +345,7 @@ print_stack_frame(struct tcb *tcp,
         * after a set_tid_address syscall
         * unw_get_reg returns IP == 0
         */
-       if(ip)
+       if (ip)
                error_action(data, "unexpected_backtracing_error", ip);
        return -1;
 }
@@ -372,9 +369,7 @@ stacktrace_walk(struct tcb *tcp,
        if (tcp->mmap_cache_size == 0)
                error_msg_and_die("bug: mmap_cache is empty");
 
-       symbol_name = malloc(symbol_name_size);
-       if (!symbol_name)
-               die_out_of_memory();
+       symbol_name = xmalloc(symbol_name_size);
 
        if (unw_init_remote(&cursor, libunwind_as, tcp->libunwind_ui) < 0)
                perror_msg_and_die("Can't initiate libunwind");
@@ -432,7 +427,7 @@ print_call_cb(void *dummy,
        else if (binary_filename)
                tprintf(STACK_ENTRY_NOSYMBOL_FMT);
        else
-               tprintf(STACK_ENTRY_BUG_FMT, __FUNCTION__);
+               tprintf(STACK_ENTRY_BUG_FMT, __func__);
 
        line_ended();
 }
@@ -457,24 +452,24 @@ sprint_call_or_error(const char *binary_filename,
                     unsigned long true_offset,
                     const char *error)
 {
-       char *output_line = NULL;
-       int n;
-
-       if (symbol_name)
-               n = asprintf(&output_line, STACK_ENTRY_SYMBOL_FMT);
-       else if (binary_filename)
-               n = asprintf(&output_line, STACK_ENTRY_NOSYMBOL_FMT);
-       else if (error)
-               n = true_offset
-                       ? asprintf(&output_line, STACK_ENTRY_ERROR_WITH_OFFSET_FMT)
-                       : asprintf(&output_line, STACK_ENTRY_ERROR_FMT);
-       else
-               n = asprintf(&output_line, STACK_ENTRY_BUG_FMT, __FUNCTION__);
-
-       if (n < 0)
-               error_msg_and_die("error in asprintf");
-
-       return output_line;
+       char *output_line = NULL;
+       int n;
+
+       if (symbol_name)
+               n = asprintf(&output_line, STACK_ENTRY_SYMBOL_FMT);
+       else if (binary_filename)
+               n = asprintf(&output_line, STACK_ENTRY_NOSYMBOL_FMT);
+       else if (error)
+               n = true_offset
+                       ? asprintf(&output_line, STACK_ENTRY_ERROR_WITH_OFFSET_FMT)
+                       : asprintf(&output_line, STACK_ENTRY_ERROR_FMT);
+       else
+               n = asprintf(&output_line, STACK_ENTRY_BUG_FMT, __func__);
+
+       if (n < 0)
+               error_msg_and_die("error in asprintf");
+
+       return output_line;
 }
 
 /*
@@ -490,10 +485,7 @@ queue_put(struct queue_t *queue,
 {
        struct call_t *call;
 
-       call = malloc(sizeof(*call));
-       if (!call)
-               die_out_of_memory();
-
+       call = xmalloc(sizeof(*call));
        call->output_line = sprint_call_or_error(binary_filename,
                                                 symbol_name,
                                                 function_offset,
@@ -559,7 +551,7 @@ queue_print(struct queue_t *queue)
  * printing stack
  */
 void
-unwind_print_stacktrace(struct tcbtcp)
+unwind_print_stacktrace(struct tcb *tcp)
 {
 #if SUPPORTED_PERSONALITIES > 1
        if (tcp->currpers != DEFAULT_PERSONALITY) {
@@ -567,14 +559,13 @@ unwind_print_stacktrace(struct tcb* tcp)
                return;
        }
 #endif
-       if (tcp->queue->head) {
-              DPRINTF("tcp=%p, queue=%p", "queueprint", tcp, tcp->queue->head);
-              queue_print(tcp->queue);
-       }
-       else if (rebuild_cache_if_invalid(tcp, __FUNCTION__)) {
-               DPRINTF("tcp=%p, queue=%p", "stackprint", tcp, tcp->queue->head);
-               stacktrace_walk(tcp, print_call_cb, print_error_cb, NULL);
-       }
+       if (tcp->queue->head) {
+               DPRINTF("tcp=%p, queue=%p", "queueprint", tcp, tcp->queue->head);
+               queue_print(tcp->queue);
+       } else if (rebuild_cache_if_invalid(tcp, __func__)) {
+               DPRINTF("tcp=%p, queue=%p", "stackprint", tcp, tcp->queue->head);
+               stacktrace_walk(tcp, print_call_cb, print_error_cb, NULL);
+       }
 }
 
 /*
@@ -592,7 +583,7 @@ unwind_capture_stacktrace(struct tcb *tcp)
        if (tcp->queue->head)
                error_msg_and_die("bug: unprinted entries in queue");
 
-       if (rebuild_cache_if_invalid(tcp, __FUNCTION__)) {
+       if (rebuild_cache_if_invalid(tcp, __func__)) {
                stacktrace_walk(tcp, queue_put_call, queue_put_error,
                                tcp->queue);
                DPRINTF("tcp=%p, queue=%p", "captured", tcp, tcp->queue->head);