strace: terminate itself if interrupted by a signal

[strace] / tests / netlink_inet_diag.c

diff --git a/tests/netlink_inet_diag.c b/tests/netlink_inet_diag.c
index 7d1bc2bd510b7b1247daada51ebd68e251e13dbe..e3ccc05c0827882b1605884d20d4a27b38236e8e 100644 (file)
--- a/tests/netlink_inet_diag.c
+++ b/tests/netlink_inet_diag.c
@@ -1,39 +1,23 @@
 /*
- * Copyright (c) 2014-2015 Dmitry V. Levin <ldv@altlinux.org>
- * All rights reserved.
+ * This file is part of inet-yy strace test.
  *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
+ * Copyright (c) 2014-2016 Dmitry V. Levin <ldv@altlinux.org>
+ * Copyright (c) 2014-2018 The strace developers.
+ * All rights reserved.
  *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
- * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
- * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
- * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
- * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-#include <assert.h>
+#include "tests.h"
+#include <errno.h>
 #include <string.h>
 #include <unistd.h>
 #include <netinet/in.h>
-#include <linux/netlink.h>
+#include "netlink.h"
 #include <linux/sock_diag.h>
 #include <linux/inet_diag.h>
 
-static int
+static void
 send_query(const int fd, const int family, const int proto)
 {
        struct sockaddr_nl nladdr = {
@@ -59,28 +43,33 @@ send_query(const int fd, const int family, const int proto)
                .iov_len = sizeof(req)
        };
        struct msghdr msg = {
-               .msg_name = (void*)&nladdr,
+               .msg_name = (void *) &nladdr,
                .msg_namelen = sizeof(nladdr),
                .msg_iov = &iov,
                .msg_iovlen = 1
        };
 
-       return sendmsg(fd, &msg, 0) > 0;
+       if (sendmsg(fd, &msg, 0) <= 0)
+               perror_msg_and_skip("sendmsg");
 }
 
-static int
+static void
 check_responses(const int fd)
 {
-       static char buf[8192];
+       static union {
+               struct nlmsghdr hdr;
+               long buf[8192 / sizeof(long)];
+       } hdr_buf;
+
        struct sockaddr_nl nladdr = {
                .nl_family = AF_NETLINK
        };
        struct iovec iov = {
-               .iov_base = buf,
-               .iov_len = sizeof(buf)
+               .iov_base = hdr_buf.buf,
+               .iov_len = sizeof(hdr_buf.buf)
        };
        struct msghdr msg = {
-               .msg_name = (void*)&nladdr,
+               .msg_name = (void *) &nladdr,
                .msg_namelen = sizeof(nladdr),
                .msg_iov = &iov,
                .msg_iovlen = 1
@@ -88,12 +77,25 @@ check_responses(const int fd)
 
        ssize_t ret = recvmsg(fd, &msg, 0);
        if (ret <= 0)
-               return 0;
+               perror_msg_and_skip("recvmsg");
+
+       struct nlmsghdr *h = &hdr_buf.hdr;
+       if (!is_nlmsg_ok(h, ret))
+               error_msg_and_skip("!is_nlmsg_ok");
+       if (h->nlmsg_type == NLMSG_ERROR) {
+               const struct nlmsgerr *err = NLMSG_DATA(h);
+               if (h->nlmsg_len < NLMSG_LENGTH(sizeof(*err)))
+                       error_msg_and_skip("NLMSG_ERROR");
+               errno = -err->error;
+               perror_msg_and_skip("NLMSG_ERROR");
+       }
+       if (h->nlmsg_type != SOCK_DIAG_BY_FAMILY)
+               error_msg_and_skip("unexpected nlmsg_type %u",
+                                  (unsigned) h->nlmsg_type);
 
-       struct nlmsghdr *h = (struct nlmsghdr*)buf;
-       return (NLMSG_OK(h, ret) &&
-               h->nlmsg_type != NLMSG_ERROR &&
-               h->nlmsg_type != NLMSG_DONE) ? 1 : 0;
+       const struct inet_diag_msg *diag = NLMSG_DATA(h);
+       if (h->nlmsg_len < NLMSG_LENGTH(sizeof(*diag)))
+               error_msg_and_skip("short response");
 }
 
 int main(void)
@@ -108,12 +110,16 @@ int main(void)
        close(0);
        close(1);
 
-       if (socket(PF_INET, SOCK_STREAM, 0) ||
-           bind(0, (struct sockaddr *) &addr, len) ||
-           listen(0, 5) ||
-           socket(AF_NETLINK, SOCK_RAW, NETLINK_INET_DIAG) != 1)
-               return 77;
+       if (socket(AF_INET, SOCK_STREAM, 0))
+               perror_msg_and_skip("socket AF_INET");
+       if (bind(0, (struct sockaddr *) &addr, len))
+               perror_msg_and_skip("bind");
+       if (listen(0, 5))
+               perror_msg_and_skip("listen");
+       if (socket(AF_NETLINK, SOCK_RAW, NETLINK_INET_DIAG) != 1)
+               perror_msg_and_skip("socket AF_NETLINK");
 
-       return (send_query(1, AF_INET, IPPROTO_TCP) &&
-               check_responses(1)) ? 0 : 77;
+       send_query(1, AF_INET, IPPROTO_TCP);
+       check_responses(1);
+       return 0;
 }