Fix some scan-build warnings

[pgbouncer] / src / varcache.c

diff --git a/src/varcache.c b/src/varcache.c
index 37582c640e42fcb3916c41c9ca467d4cbe0b4b69..f006e279faccedf2e65e63dbc71b6ee27bf800a7 100644 (file)
--- a/src/varcache.c
+++ b/src/varcache.c
@@ -1,12 +1,12 @@
 /*
  * PgBouncer - Lightweight connection pooler for PostgreSQL.
- * 
+ *
  * Copyright (c) 2007-2009  Marko Kreen, Skype Technologies OÜ
- * 
+ *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
  * copyright notice and this permission notice appear in all copies.
- * 
+ *
  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
@@ -67,8 +67,8 @@ set_value:
        strpool_decref(cache->var_list[lk->idx]);
        cache->var_list[lk->idx] = NULL;
 
-       /* ignore empty value */
-       if (!value || !value[0])
+       /* NULL value? */
+       if (!value)
                return false;
 
        /* set new value */
@@ -124,7 +124,7 @@ bool varcache_apply(PgSocket *server, PgSocket *client, bool *changes_p)
 
        pktbuf_start_packet(pkt, 'Q');
 
-       /* grab quory position inside pkt */
+       /* grab query position inside pkt */
        sql_ofs = pktbuf_written(pkt);
 
        for (lk = lookup; lk->name; lk++) {
@@ -140,7 +140,7 @@ bool varcache_apply(PgSocket *server, PgSocket *client, bool *changes_p)
        pktbuf_finish_packet(pkt);
 
        slog_debug(server, "varcache_apply: %s", pkt->buf + sql_ofs);
-       return pktbuf_send_immidiate(pkt, server);
+       return pktbuf_send_immediate(pkt, server);
 }
 
 void varcache_fill_unset(VarCache *src, PgSocket *dst)
@@ -177,3 +177,8 @@ void varcache_add_params(PktBuf *pkt, VarCache *vars)
        }
 }
 
+void varcache_deinit(void)
+{
+       strpool_free(vpool);
+       vpool = NULL;
+}