]> granicus.if.org Git - postgresql/blobdiff - src/pl/plperl/plperl.c
Fix typo in comment.
[postgresql] / src / pl / plperl / plperl.c
index cfbee1f2839b1c48f2fadf79111c06592b487477..da1b8780d3f8d749264a6c4dfce63c6ecc9ef3bb 100644 (file)
@@ -4,7 +4,7 @@
  * IDENTIFICATION
  *
  *       This software is copyrighted by Mark Hollomon
- *      but is shameless cribbed from pltcl.c by Jan Weick.
+ *       but is shamelessly cribbed from pltcl.c by Jan Wieck.
  *
  *       The author hereby grants permission  to  use,  copy,  modify,
  *       distribute,  and      license this software and its documentation
@@ -33,7 +33,7 @@
  *       ENHANCEMENTS, OR MODIFICATIONS.
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.74 2005/05/23 01:57:51 neilc Exp $
+ *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.103 2006/02/28 23:38:13 neilc Exp $
  *
  **********************************************************************/
 
@@ -45,6 +45,7 @@
 #include <ctype.h>
 #include <fcntl.h>
 #include <unistd.h>
+#include <locale.h>
 
 /* postgreSQL stuff */
 #include "commands/trigger.h"
 #include "utils/lsyscache.h"
 #include "utils/memutils.h"
 #include "utils/typcache.h"
+#include "miscadmin.h"
+#include "mb/pg_wchar.h"
 
-/* perl stuff */
-#include "EXTERN.h"
-#include "perl.h"
-#include "XSUB.h"
-#include "ppport.h"
-
-/* just in case these symbols aren't provided */
-#ifndef pTHX_
-#define pTHX_
-#define pTHX void
-#endif
+/* define this before the perl headers get a chance to mangle DLLIMPORT */
+extern DLLIMPORT bool check_function_bodies;
 
+/* perl stuff */
+#include "plperl.h"
 
 /**********************************************************************
  * The information we cache about loaded procedures
@@ -79,8 +75,9 @@ typedef struct plperl_proc_desc
        bool            lanpltrusted;
        bool            fn_retistuple;  /* true, if function returns tuple */
        bool            fn_retisset;    /* true, if function returns set */
+       bool            fn_retisarray;  /* true if function returns array */
        Oid                     result_oid;             /* Oid of result type */
-       FmgrInfo        result_in_func; /* I/O function and arg for result type */
+       FmgrInfo        result_in_func; /* I/O function and arg for result type */
        Oid                     result_typioparam;
        int                     nargs;
        FmgrInfo        arg_out_func[FUNC_MAX_ARGS];
@@ -88,17 +85,33 @@ typedef struct plperl_proc_desc
        SV                 *reference;
 } plperl_proc_desc;
 
+/*
+ * The information we cache for the duration of a single call to a
+ * function.
+ */
+typedef struct plperl_call_data
+{
+       plperl_proc_desc *prodesc;
+       FunctionCallInfo  fcinfo;
+       Tuplestorestate  *tuple_store;
+       TupleDesc                 ret_tdesc;
+       AttInMetadata    *attinmeta;
+       MemoryContext     tmp_cxt;
+} plperl_call_data;
+
 
 /**********************************************************************
  * Global data
  **********************************************************************/
-static int     plperl_firstcall = 1;
+static bool plperl_firstcall = true;
 static bool plperl_safe_init_done = false;
 static PerlInterpreter *plperl_interp = NULL;
 static HV  *plperl_proc_hash = NULL;
 
+static bool plperl_use_strict = false;
+
 /* this is saved and restored by plperl_call_handler */
-static plperl_proc_desc *plperl_current_prodesc = NULL;
+static plperl_call_data *current_call_data = NULL;
 
 /**********************************************************************
  * Forward declarations
@@ -107,10 +120,9 @@ static void plperl_init_all(void);
 static void plperl_init_interp(void);
 
 Datum          plperl_call_handler(PG_FUNCTION_ARGS);
+Datum          plperl_validator(PG_FUNCTION_ARGS);
 void           plperl_init(void);
 
-HV                *plperl_spi_exec(char *query, int limit);
-
 static Datum plperl_func_handler(PG_FUNCTION_ARGS);
 
 static Datum plperl_trigger_handler(PG_FUNCTION_ARGS);
@@ -120,7 +132,6 @@ static SV  *plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc);
 static void plperl_init_shared_libs(pTHX);
 static HV  *plperl_spi_execute_fetch_result(SPITupleTable *, int, int);
 
-
 /*
  * This routine is a crock, and so is everyplace that calls it.  The problem
  * is that the cached form of plperl functions/queries is allocated permanently
@@ -138,68 +149,160 @@ perm_fmgr_info(Oid functionId, FmgrInfo *finfo)
        fmgr_info_cxt(functionId, finfo, TopMemoryContext);
 }
 
-/**********************************************************************
- * plperl_init()                       - Initialize everything that can be
- *                                                       safely initialized during postmaster
- *                                                       startup.
- *
- * DO NOT make this static --- it has to be callable by preload
- **********************************************************************/
+
+/* Perform initialization during postmaster startup. */
+
 void
 plperl_init(void)
 {
-       /************************************************************
-        * Do initialization only once
-        ************************************************************/
        if (!plperl_firstcall)
                return;
 
-       /************************************************************
-        * Create the Perl interpreter
-        ************************************************************/
-       plperl_init_interp();
+       DefineCustomBoolVariable(
+                                                        "plperl.use_strict",
+         "If true, will compile trusted and untrusted perl code in strict mode",
+                                                        NULL,
+                                                        &plperl_use_strict,
+                                                        PGC_USERSET,
+                                                        NULL, NULL);
 
-       plperl_firstcall = 0;
+       EmitWarningsOnPlaceholders("plperl");
+
+       plperl_init_interp();
+       plperl_firstcall = false;
 }
 
-/**********************************************************************
- * plperl_init_all()           - Initialize all
- **********************************************************************/
+
+/* Perform initialization during backend startup. */
+
 static void
 plperl_init_all(void)
 {
-
-       /************************************************************
-        * Execute postmaster-startup safe initialization
-        ************************************************************/
        if (plperl_firstcall)
                plperl_init();
 
-       /************************************************************
-        * Any other initialization that must be done each time a new
-        * backend starts -- currently none
-        ************************************************************/
-
+       /* We don't need to do anything yet when a new backend starts. */
 }
 
+/* Each of these macros must represent a single string literal */
+
+#define PERLBOOT \
+       "SPI::bootstrap(); use vars qw(%_SHARED);" \
+       "sub ::plperl_warn { my $msg = shift; " \
+       "       $msg =~ s/\\(eval \\d+\\) //g; &elog(&NOTICE, $msg); } " \
+       "$SIG{__WARN__} = \\&::plperl_warn; " \
+       "sub ::plperl_die { my $msg = shift; " \
+       "       $msg =~ s/\\(eval \\d+\\) //g; die $msg; } " \
+       "$SIG{__DIE__} = \\&::plperl_die; " \
+       "sub ::mkunsafefunc {" \
+       "      my $ret = eval(qq[ sub { $_[0] $_[1] } ]); " \
+       "      $@ =~ s/\\(eval \\d+\\) //g if $@; return $ret; }" \
+       "use strict; " \
+       "sub ::mk_strict_unsafefunc {" \
+       "      my $ret = eval(qq[ sub { use strict; $_[0] $_[1] } ]); " \
+       "      $@ =~ s/\\(eval \\d+\\) //g if $@; return $ret; } " \
+       "sub ::_plperl_to_pg_array {" \
+       "  my $arg = shift; ref $arg eq 'ARRAY' || return $arg; " \
+       "  my $res = ''; my $first = 1; " \
+       "  foreach my $elem (@$arg) " \
+       "  { " \
+       "    $res .= ', ' unless $first; $first = undef; " \
+       "    if (ref $elem) " \
+       "    { " \
+       "      $res .= _plperl_to_pg_array($elem); " \
+       "    } " \
+       "    elsif (defined($elem)) " \
+       "    { " \
+       "      my $str = qq($elem); " \
+       "      $str =~ s/([\"\\\\])/\\\\$1/g; " \
+       "      $res .= qq(\"$str\"); " \
+       "    } " \
+       "    else " \
+       "    { "\
+       "      $res .= 'NULL' ; " \
+       "    } "\
+       "  } " \
+       "  return qq({$res}); " \
+       "} "
+
+#define SAFE_MODULE \
+       "require Safe; $Safe::VERSION"
+
+#define SAFE_OK \
+       "use vars qw($PLContainer); $PLContainer = new Safe('PLPerl');" \
+       "$PLContainer->permit_only(':default');" \
+       "$PLContainer->permit(qw[:base_math !:base_io sort time]);" \
+       "$PLContainer->share(qw[&elog &spi_exec_query &return_next " \
+       "&spi_query &spi_fetchrow " \
+       "&_plperl_to_pg_array " \
+       "&DEBUG &LOG &INFO &NOTICE &WARNING &ERROR %_SHARED ]);" \
+       "sub ::mksafefunc {" \
+       "      my $ret = $PLContainer->reval(qq[sub { $_[0] $_[1] }]); " \
+       "      $@ =~ s/\\(eval \\d+\\) //g if $@; return $ret; }" \
+       "$PLContainer->permit('require'); $PLContainer->reval('use strict;');" \
+       "$PLContainer->deny('require');" \
+       "sub ::mk_strict_safefunc {" \
+       "      my $ret = $PLContainer->reval(qq[sub { BEGIN { strict->import(); } $_[0] $_[1] }]); " \
+       "      $@ =~ s/\\(eval \\d+\\) //g if $@; return $ret; }"
+
+#define SAFE_BAD \
+       "use vars qw($PLContainer); $PLContainer = new Safe('PLPerl');" \
+       "$PLContainer->permit_only(':default');" \
+       "$PLContainer->share(qw[&elog &ERROR ]);" \
+       "sub ::mksafefunc { return $PLContainer->reval(qq[sub { " \
+       "      elog(ERROR,'trusted Perl functions disabled - " \
+       "      please upgrade Perl Safe module to version 2.09 or later');}]); }" \
+       "sub ::mk_strict_safefunc { return $PLContainer->reval(qq[sub { " \
+       "      elog(ERROR,'trusted Perl functions disabled - " \
+       "      please upgrade Perl Safe module to version 2.09 or later');}]); }"
+
 
-/**********************************************************************
- * plperl_init_interp() - Create the Perl interpreter
- **********************************************************************/
 static void
 plperl_init_interp(void)
 {
-       static char        *embedding[3] = {
-               "", "-e",
-
-               /*
-                * no commas between the next lines please. They are supposed to
-                * be one string
-                */
-               "SPI::bootstrap(); use vars qw(%_SHARED);"
-               "sub ::mkunsafefunc {return eval(qq[ sub { $_[0] $_[1] } ]); }"
+       static char *embedding[3] = {
+               "", "-e", PERLBOOT
        };
 
+#ifdef WIN32
+
+       /* 
+        * The perl library on startup does horrible things like call
+        * setlocale(LC_ALL,""). We have protected against that on most
+        * platforms by setting the environment appropriately. However, on
+        * Windows, setlocale() does not consult the environment, so we need
+        * to save the existing locale settings before perl has a chance to 
+        * mangle them and restore them after its dirty deeds are done.
+        *
+        * MSDN ref:
+        * http://msdn.microsoft.com/library/en-us/vclib/html/_crt_locale.asp
+        *
+        * It appears that we only need to do this on interpreter startup, and
+        * subsequent calls to the interpreter don't mess with the locale
+        * settings.
+        *
+        * We restore them using Perl's POSIX::setlocale() function so that
+        * Perl doesn't have a different idea of the locale from Postgres.
+        *
+        */
+
+       char *loc;
+       char *save_collate, *save_ctype, *save_monetary, *save_numeric, *save_time;
+       char buf[1024];
+
+       loc = setlocale(LC_COLLATE,NULL);
+       save_collate = loc ? pstrdup(loc) : NULL;
+       loc = setlocale(LC_CTYPE,NULL);
+       save_ctype = loc ? pstrdup(loc) : NULL;
+       loc = setlocale(LC_MONETARY,NULL);
+       save_monetary = loc ? pstrdup(loc) : NULL;
+       loc = setlocale(LC_NUMERIC,NULL);
+       save_numeric = loc ? pstrdup(loc) : NULL;
+       loc = setlocale(LC_TIME,NULL);
+       save_time = loc ? pstrdup(loc) : NULL;
+
+#endif
+
        plperl_interp = perl_alloc();
        if (!plperl_interp)
                elog(ERROR, "could not allocate Perl interpreter");
@@ -208,41 +311,60 @@ plperl_init_interp(void)
        perl_parse(plperl_interp, plperl_init_shared_libs, 3, embedding, NULL);
        perl_run(plperl_interp);
 
-       /************************************************************
-        * Initialize the procedure hash table
-        ************************************************************/
        plperl_proc_hash = newHV();
+
+#ifdef WIN32
+
+       eval_pv("use POSIX qw(locale_h);", TRUE); /* croak on failure */
+
+       if (save_collate != NULL)
+       {
+               snprintf(buf, sizeof(buf),"setlocale(%s,'%s');",
+                                "LC_COLLATE",save_collate);
+               eval_pv(buf,TRUE);
+               pfree(save_collate);
+       }
+       if (save_ctype != NULL)
+       {
+               snprintf(buf, sizeof(buf),"setlocale(%s,'%s');",
+                                "LC_CTYPE",save_ctype);
+               eval_pv(buf,TRUE);
+               pfree(save_ctype);
+       }
+       if (save_monetary != NULL)
+       {
+               snprintf(buf, sizeof(buf),"setlocale(%s,'%s');",
+                                "LC_MONETARY",save_monetary);
+               eval_pv(buf,TRUE);
+               pfree(save_monetary);
+       }
+       if (save_numeric != NULL)
+       {
+               snprintf(buf, sizeof(buf),"setlocale(%s,'%s');",
+                                "LC_NUMERIC",save_numeric);
+               eval_pv(buf,TRUE);
+               pfree(save_numeric);
+       }
+       if (save_time != NULL)
+       {
+               snprintf(buf, sizeof(buf),"setlocale(%s,'%s');",
+                                "LC_TIME",save_time);
+               eval_pv(buf,TRUE);
+               pfree(save_time);
+       }
+
+#endif
+
 }
 
 
 static void
 plperl_safe_init(void)
 {
-       static char *safe_module =
-       "require Safe; $Safe::VERSION";
-
-       static char *safe_ok =
-       "use vars qw($PLContainer); $PLContainer = new Safe('PLPerl');"
-       "$PLContainer->permit_only(':default');"
-       "$PLContainer->permit(qw[:base_math !:base_io sort time]);"
-       "$PLContainer->share(qw[&elog &spi_exec_query &DEBUG &LOG "
-    "&INFO &NOTICE &WARNING &ERROR %_SHARED ]);"
-       "sub ::mksafefunc { return $PLContainer->reval(qq[sub { $_[0] $_[1]}]); }"
-                          ;
-
-       static char *safe_bad =
-       "use vars qw($PLContainer); $PLContainer = new Safe('PLPerl');"
-       "$PLContainer->permit_only(':default');"
-       "$PLContainer->share(qw[&elog &ERROR ]);"
-       "sub ::mksafefunc { return $PLContainer->reval(qq[sub { "
-       "elog(ERROR,'trusted Perl functions disabled - "
-    "please upgrade Perl Safe module to version 2.09 or later');}]); }"
-                          ;
-
        SV                 *res;
        double          safe_version;
 
-       res = eval_pv(safe_module, FALSE);      /* TRUE = croak if failure */
+       res = eval_pv(SAFE_MODULE, FALSE);      /* TRUE = croak if failure */
 
        safe_version = SvNV(res);
 
@@ -251,30 +373,36 @@ plperl_safe_init(void)
         * assume that floating-point comparisons are exact, so use a slightly
         * smaller comparison value.
         */
-       eval_pv((safe_version < 2.0899 ? safe_bad : safe_ok), FALSE);
+       if (safe_version < 2.0899)
+       {
+               /* not safe, so disallow all trusted funcs */
+               eval_pv(SAFE_BAD, FALSE);
+       }
+       else
+       {
+               eval_pv(SAFE_OK, FALSE);
+       }
 
        plperl_safe_init_done = true;
 }
 
-
 /*
  * Perl likes to put a newline after its error messages; clean up such
  */
 static char *
 strip_trailing_ws(const char *msg)
 {
-       char   *res = pstrdup(msg);
-       int             len = strlen(res);
+       char       *res = pstrdup(msg);
+       int                     len = strlen(res);
 
-       while (len > 0 && isspace((unsigned char) res[len-1]))
+       while (len > 0 && isspace((unsigned char) res[len - 1]))
                res[--len] = '\0';
        return res;
 }
 
 
-/*
- * Build a tuple from a hash
- */
+/* Build a tuple from a hash. */
+
 static HeapTuple
 plperl_build_tuple_result(HV *perlhash, AttInMetadata *attinmeta)
 {
@@ -307,10 +435,38 @@ plperl_build_tuple_result(HV *perlhash, AttInMetadata *attinmeta)
        return tup;
 }
 
+/*
+ * convert perl array to postgres string representation
+ */
+static SV  *
+plperl_convert_to_pg_array(SV *src)
+{
+       SV                 *rv;
+       int                     count;
+
+       dSP;
+
+       PUSHMARK(SP);
+       XPUSHs(src);
+       PUTBACK;
+
+       count = call_pv("::_plperl_to_pg_array", G_SCALAR);
+
+       SPAGAIN;
+
+       if (count != 1)
+               elog(ERROR, "unexpected _plperl_to_pg_array failure");
+
+       rv = POPs;
+
+       PUTBACK;
+
+       return rv;
+}
+
+
+/* Set up the arguments for a trigger call. */
 
-/**********************************************************************
- * set up arguments for a trigger call
- **********************************************************************/
 static SV  *
 plperl_trigger_build_args(FunctionCallInfo fcinfo)
 {
@@ -329,10 +485,10 @@ plperl_trigger_build_args(FunctionCallInfo fcinfo)
        tupdesc = tdata->tg_relation->rd_att;
 
        relid = DatumGetCString(
-                               DirectFunctionCall1(oidout,
-                                                                       ObjectIdGetDatum(tdata->tg_relation->rd_id)
-                               )
-                       );
+                                                       DirectFunctionCall1(oidout,
+                                                                 ObjectIdGetDatum(tdata->tg_relation->rd_id)
+                                                                                               )
+               );
 
        hv_store(hv, "name", 4, newSVpv(tdata->tg_trigger->tgname, 0), 0);
        hv_store(hv, "relid", 5, newSVpv(relid, 0), 0);
@@ -374,10 +530,11 @@ plperl_trigger_build_args(FunctionCallInfo fcinfo)
 
        if (tdata->tg_trigger->tgnargs > 0)
        {
-               AV *av = newAV();
-               for (i=0; i < tdata->tg_trigger->tgnargs; i++)
+               AV                 *av = newAV();
+
+               for (i = 0; i < tdata->tg_trigger->tgnargs; i++)
                        av_push(av, newSVpv(tdata->tg_trigger->tgargs[i], 0));
-               hv_store(hv, "args", 4, newRV_noinc((SV *)av), 0);
+               hv_store(hv, "args", 4, newRV_noinc((SV *) av), 0);
        }
 
        hv_store(hv, "relname", 7,
@@ -399,31 +556,12 @@ plperl_trigger_build_args(FunctionCallInfo fcinfo)
                level = "UNKNOWN";
        hv_store(hv, "level", 5, newSVpv(level, 0), 0);
 
-       return newRV_noinc((SV*)hv);
+       return newRV_noinc((SV *) hv);
 }
 
 
-/*
- * Obtain tuple descriptor for a function returning tuple
- *
- * NB: copy the result if needed for any great length of time
- */
-static TupleDesc
-get_function_tupdesc(FunctionCallInfo fcinfo)
-{
-       TupleDesc       result;
-
-       if (get_call_result_type(fcinfo, NULL, &result) != TYPEFUNC_COMPOSITE)
-               ereport(ERROR,
-                               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                errmsg("function returning record called in context "
-                                               "that cannot accept type record")));
-       return result;
-}
+/* Set up the new tuple returned from a trigger. */
 
-/**********************************************************************
- * set up the new tuple returned from a trigger
- **********************************************************************/
 static HeapTuple
 plperl_modify_tuple(HV *hvTD, TriggerData *tdata, HeapTuple otup)
 {
@@ -479,8 +617,8 @@ plperl_modify_tuple(HV *hvTD, TriggerData *tdata, HeapTuple otup)
                                                         &typinput, &typioparam);
                        fmgr_info(typinput, &finfo);
                        modvalues[slotsused] = FunctionCall3(&finfo,
-                                                                                CStringGetDatum(SvPV(val, PL_na)),
-                                                                                ObjectIdGetDatum(typioparam),
+                                                                                  CStringGetDatum(SvPV(val, PL_na)),
+                                                                                                ObjectIdGetDatum(typioparam),
                                                 Int32GetDatum(tupdesc->attrs[attn - 1]->atttypmod));
                        modnulls[slotsused] = ' ';
                }
@@ -508,38 +646,25 @@ plperl_modify_tuple(HV *hvTD, TriggerData *tdata, HeapTuple otup)
        return rtup;
 }
 
-/**********************************************************************
- * plperl_call_handler         - This is the only visible function
- *                               of the PL interpreter. The PostgreSQL
- *                               function manager and trigger manager
- *                               call this function for execution of
- *                               perl procedures.
- **********************************************************************/
+
+/*
+ * This is the only externally-visible part of the plperl call interface.
+ * The Postgres function and trigger managers call it to execute a
+ * perl function.
+ */
 PG_FUNCTION_INFO_V1(plperl_call_handler);
 
-/* keep non-static */
 Datum
 plperl_call_handler(PG_FUNCTION_ARGS)
 {
        Datum           retval;
-       plperl_proc_desc *save_prodesc;
+       plperl_call_data *save_call_data;
 
-       /*
-        * Initialize interpreter if first time through
-        */
        plperl_init_all();
 
-       /*
-        * Ensure that static pointers are saved/restored properly
-        */
-       save_prodesc = plperl_current_prodesc;
-
+       save_call_data = current_call_data;
        PG_TRY();
        {
-               /*
-                * Determine if called as function or trigger and
-                * call appropriate subhandler
-                */
                if (CALLED_AS_TRIGGER(fcinfo))
                        retval = PointerGetDatum(plperl_trigger_handler(fcinfo));
                else
@@ -547,28 +672,100 @@ plperl_call_handler(PG_FUNCTION_ARGS)
        }
        PG_CATCH();
        {
-               plperl_current_prodesc = save_prodesc;
+               current_call_data = save_call_data;
                PG_RE_THROW();
        }
        PG_END_TRY();
 
-       plperl_current_prodesc = save_prodesc;
-
+       current_call_data = save_call_data;
        return retval;
 }
 
+/*
+ * This is the other externally visible function - it is called when CREATE
+ * FUNCTION is issued to validate the function being created/replaced.
+ */
+PG_FUNCTION_INFO_V1(plperl_validator);
+
+Datum
+plperl_validator(PG_FUNCTION_ARGS)
+{
+       Oid                     funcoid = PG_GETARG_OID(0);
+       HeapTuple       tuple;
+       Form_pg_proc proc;
+       char            functyptype;
+       int                     numargs;
+       Oid                *argtypes;
+       char      **argnames;
+       char       *argmodes;
+       bool            istrigger = false;
+       int                     i;
+
+       /* Get the new function's pg_proc entry */
+       tuple = SearchSysCache(PROCOID,
+                                                  ObjectIdGetDatum(funcoid),
+                                                  0, 0, 0);
+       if (!HeapTupleIsValid(tuple))
+               elog(ERROR, "cache lookup failed for function %u", funcoid);
+       proc = (Form_pg_proc) GETSTRUCT(tuple);
+
+       functyptype = get_typtype(proc->prorettype);
+
+       /* Disallow pseudotype result */
+       /* except for TRIGGER, RECORD, or VOID */
+       if (functyptype == 'p')
+       {
+               /* we assume OPAQUE with no arguments means a trigger */
+               if (proc->prorettype == TRIGGEROID ||
+                       (proc->prorettype == OPAQUEOID && proc->pronargs == 0))
+                       istrigger = true;
+               else if (proc->prorettype != RECORDOID &&
+                                proc->prorettype != VOIDOID)
+                       ereport(ERROR,
+                                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                        errmsg("plperl functions cannot return type %s",
+                                                       format_type_be(proc->prorettype))));
+       }
+
+       /* Disallow pseudotypes in arguments (either IN or OUT) */
+       numargs = get_func_arg_info(tuple,
+                                                               &argtypes, &argnames, &argmodes);
+       for (i = 0; i < numargs; i++)
+       {
+               if (get_typtype(argtypes[i]) == 'p')
+                       ereport(ERROR,
+                                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                        errmsg("plperl functions cannot take type %s",
+                                                       format_type_be(argtypes[i]))));
+       }
+
+       ReleaseSysCache(tuple);
+
+       /* Postpone body checks if !check_function_bodies */
+       if (check_function_bodies)
+       {
+               plperl_proc_desc *prodesc;
+
+               plperl_init_all();
+
+               prodesc = compile_plperl_function(funcoid, istrigger);
+       }
+
+       /* the result of a validator is ignored */
+       PG_RETURN_VOID();
+}
+
+
+/* Uses mksafefunc/mkunsafefunc to create an anonymous sub whose text is
+ * supplied in s, and returns a reference to the closure. */
 
-/**********************************************************************
- * plperl_create_sub()         - calls the perl interpreter to
- *             create the anonymous subroutine whose text is in the SV.
- *             Returns the SV containing the RV to the closure.
- **********************************************************************/
 static SV  *
 plperl_create_sub(char *s, bool trusted)
 {
        dSP;
        SV                 *subref;
        int                     count;
+       char       *compile_sub;
 
        if (trusted && !plperl_safe_init_done)
        {
@@ -585,11 +782,20 @@ plperl_create_sub(char *s, bool trusted)
 
        /*
         * G_KEEPERR seems to be needed here, else we don't recognize compile
-        * errors properly.  Perhaps it's because there's another level of
-        * eval inside mksafefunc?
+        * errors properly.  Perhaps it's because there's another level of eval
+        * inside mksafefunc?
         */
-       count = perl_call_pv((trusted ? "mksafefunc" : "mkunsafefunc"),
-                                                G_SCALAR | G_EVAL | G_KEEPERR);
+
+       if (trusted && plperl_use_strict)
+               compile_sub = "::mk_strict_safefunc";
+       else if (plperl_use_strict)
+               compile_sub = "::mk_strict_unsafefunc";
+       else if (trusted)
+               compile_sub = "::mksafefunc";
+       else
+               compile_sub = "::mkunsafefunc";
+
+       count = perl_call_pv(compile_sub, G_SCALAR | G_EVAL | G_KEEPERR);
        SPAGAIN;
 
        if (count != 1)
@@ -618,7 +824,7 @@ plperl_create_sub(char *s, bool trusted)
         */
        subref = newSVsv(POPs);
 
-       if (!SvROK(subref))
+       if (!SvROK(subref) || SvTYPE(SvRV(subref)) != SVt_PVCV)
        {
                PUTBACK;
                FREETMPS;
@@ -638,6 +844,7 @@ plperl_create_sub(char *s, bool trusted)
        return subref;
 }
 
+
 /**********************************************************************
  * plperl_init_shared_libs()           -
  *
@@ -659,10 +866,7 @@ plperl_init_shared_libs(pTHX)
        newXS("SPI::bootstrap", boot_SPI, file);
 }
 
-/**********************************************************************
- * plperl_call_perl_func()             - calls a perl function through the RV
- *     stored in the prodesc structure. massages the input parms properly
- **********************************************************************/
+
 static SV  *
 plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)
 {
@@ -670,13 +874,14 @@ plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)
        SV                 *retval;
        int                     i;
        int                     count;
+       SV                 *sv;
 
        ENTER;
        SAVETMPS;
 
        PUSHMARK(SP);
 
-       XPUSHs(sv_2mortal(newSVpv("undef", 0))); /* no trigger data */
+       XPUSHs(&PL_sv_undef);           /* no trigger data */
 
        for (i = 0; i < desc->nargs; i++)
        {
@@ -709,7 +914,12 @@ plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)
 
                        tmp = DatumGetCString(FunctionCall1(&(desc->arg_out_func[i]),
                                                                                                fcinfo->arg[i]));
-                       XPUSHs(sv_2mortal(newSVpv(tmp, 0)));
+                       sv = newSVpv(tmp, 0);
+#if PERL_BCDVERSION >= 0x5006000L
+                       if (GetDatabaseEncoding() == PG_UTF8)
+                               SvUTF8_on(sv);
+#endif
+                       XPUSHs(sv_2mortal(sv));
                        pfree(tmp);
                }
        }
@@ -749,10 +959,7 @@ plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)
        return retval;
 }
 
-/**********************************************************************
- * plperl_call_perl_trigger_func()     - calls a perl trigger function
- *     through the RV stored in the prodesc structure.
- **********************************************************************/
+
 static SV  *
 plperl_call_perl_trigger_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo,
                                                          SV *td)
@@ -809,40 +1016,45 @@ plperl_call_perl_trigger_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo,
        return retval;
 }
 
-/**********************************************************************
- * plperl_func_handler()               - Handler for regular function calls
- **********************************************************************/
+
 static Datum
 plperl_func_handler(PG_FUNCTION_ARGS)
 {
        plperl_proc_desc *prodesc;
        SV                 *perlret;
        Datum           retval;
+       ReturnSetInfo *rsi;
+       SV                 *array_ret = NULL;
+
+       /*
+        * Create the call_data beforing connecting to SPI, so that it is
+        * not allocated in the SPI memory context
+        */
+       current_call_data = (plperl_call_data *) palloc0(sizeof(plperl_call_data));
+       current_call_data->fcinfo = fcinfo;
 
-       /* Connect to SPI manager */
        if (SPI_connect() != SPI_OK_CONNECT)
                elog(ERROR, "could not connect to SPI manager");
 
-       /* Find or compile the function */
        prodesc = compile_plperl_function(fcinfo->flinfo->fn_oid, false);
+       current_call_data->prodesc = prodesc;
 
-       plperl_current_prodesc = prodesc;
+       rsi = (ReturnSetInfo *) fcinfo->resultinfo;
 
-       /************************************************************
-        * Call the Perl function if not returning set
-        ************************************************************/
-       if (!prodesc->fn_retisset)
-               perlret = plperl_call_perl_func(prodesc, fcinfo);
-       else if (SRF_IS_FIRSTCALL())
-               perlret = plperl_call_perl_func(prodesc, fcinfo);
-       else
+       if (prodesc->fn_retisset)
        {
-               /* Get back the SV stashed on initial call */
-               FuncCallContext *funcctx = (FuncCallContext *) fcinfo->flinfo->fn_extra;
-
-               perlret = (SV *) funcctx->user_fctx;
+               /* Check context before allowing the call to go through */
+               if (!rsi || !IsA(rsi, ReturnSetInfo) ||
+                       (rsi->allowedModes & SFRM_Materialize) == 0 ||
+                       rsi->expectedDesc == NULL)
+                       ereport(ERROR,
+                                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                        errmsg("set-valued function called in context that "
+                                                       "cannot accept a set")));
        }
 
+       perlret = plperl_call_perl_func(prodesc, fcinfo);
+
        /************************************************************
         * Disconnect from SPI manager and then create the return
         * values datum (if the input function does a palloc for it
@@ -852,160 +1064,94 @@ plperl_func_handler(PG_FUNCTION_ARGS)
        if (SPI_finish() != SPI_OK_FINISH)
                elog(ERROR, "SPI_finish() failed");
 
-       if (!(perlret && SvOK(perlret) && SvTYPE(perlret) != SVt_NULL))
-       {
-               /* return NULL if Perl code returned undef */
-               ReturnSetInfo *rsi = (ReturnSetInfo *) fcinfo->resultinfo;
-
-               if (perlret)
-                       SvREFCNT_dec(perlret);
-               if (rsi && IsA(rsi, ReturnSetInfo))
-                       rsi->isDone = ExprEndResult;
-               PG_RETURN_NULL();
-       }
-
-       if (prodesc->fn_retisset && prodesc->fn_retistuple)
+       if (prodesc->fn_retisset)
        {
-               /* set of tuples */
-               AV                 *ret_av;
-               FuncCallContext *funcctx;
-               TupleDesc       tupdesc;
-               AttInMetadata *attinmeta;
-
-               if (!SvOK(perlret) || SvTYPE(perlret) != SVt_RV || SvTYPE(SvRV(perlret)) != SVt_PVAV)
-                       ereport(ERROR,
-                                       (errcode(ERRCODE_DATATYPE_MISMATCH),
-                                        errmsg("set-returning Perl function must return reference to array")));
-               ret_av = (AV *) SvRV(perlret);
-
-               if (SRF_IS_FIRSTCALL())
+               /*
+                * If the Perl function returned an arrayref, we pretend that it
+                * called return_next() for each element of the array, to handle old
+                * SRFs that didn't know about return_next(). Any other sort of return
+                * value is an error.
+                */
+               if (SvTYPE(perlret) == SVt_RV &&
+                       SvTYPE(SvRV(perlret)) == SVt_PVAV)
                {
-                       MemoryContext oldcontext;
+                       int                     i = 0;
+                       SV                **svp = 0;
+                       AV                 *rav = (AV *) SvRV(perlret);
 
-                       funcctx = SRF_FIRSTCALL_INIT();
-
-                       funcctx->user_fctx = (void *) perlret;
-
-                       funcctx->max_calls = av_len(ret_av) + 1;
-
-                       /* Cache a copy of the result's tupdesc and attinmeta */
-                       oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);
-                       tupdesc = get_function_tupdesc(fcinfo);
-                       tupdesc = CreateTupleDescCopy(tupdesc);
-                       funcctx->attinmeta = TupleDescGetAttInMetadata(tupdesc);
-                       MemoryContextSwitchTo(oldcontext);
-               }
-
-               funcctx = SRF_PERCALL_SETUP();
-               attinmeta = funcctx->attinmeta;
-               tupdesc = attinmeta->tupdesc;
-
-               if (funcctx->call_cntr < funcctx->max_calls)
-               {
-                       SV                **svp;
-                       HV                 *row_hv;
-                       HeapTuple       tuple;
-
-                       svp = av_fetch(ret_av, funcctx->call_cntr, FALSE);
-                       Assert(svp != NULL);
-
-                       if (!SvOK(*svp) || SvTYPE(*svp) != SVt_RV || SvTYPE(SvRV(*svp)) != SVt_PVHV)
-                               ereport(ERROR,
-                                               (errcode(ERRCODE_DATATYPE_MISMATCH),
-                                                errmsg("elements of Perl result array must be reference to hash")));
-                       row_hv = (HV *) SvRV(*svp);
-
-                       tuple = plperl_build_tuple_result(row_hv, attinmeta);
-                       retval = HeapTupleGetDatum(tuple);
-                       SRF_RETURN_NEXT(funcctx, retval);
+                       while ((svp = av_fetch(rav, i, FALSE)) != NULL)
+                       {
+                               plperl_return_next(*svp);
+                               i++;
+                       }
                }
-               else
+               else if (SvTYPE(perlret) != SVt_NULL)
                {
-                       SvREFCNT_dec(perlret);
-                       SRF_RETURN_DONE(funcctx);
-               }
-       }
-       else if (prodesc->fn_retisset)
-       {
-               /* set of non-tuples */
-               AV                 *ret_av;
-               FuncCallContext *funcctx;
-
-               if (!SvOK(perlret) || SvTYPE(perlret) != SVt_RV || SvTYPE(SvRV(perlret)) != SVt_PVAV)
                        ereport(ERROR,
                                        (errcode(ERRCODE_DATATYPE_MISMATCH),
-                                        errmsg("set-returning Perl function must return reference to array")));
-               ret_av = (AV *) SvRV(perlret);
-
-               if (SRF_IS_FIRSTCALL())
-               {
-                       funcctx = SRF_FIRSTCALL_INIT();
-
-                       funcctx->user_fctx = (void *) perlret;
-
-                       funcctx->max_calls = av_len(ret_av) + 1;
+                                        errmsg("set-returning Perl function must return "
+                                                       "reference to array or use return_next")));
                }
 
-               funcctx = SRF_PERCALL_SETUP();
-
-               if (funcctx->call_cntr < funcctx->max_calls)
+               rsi->returnMode = SFRM_Materialize;
+               if (current_call_data->tuple_store)
                {
-                       SV                **svp;
-
-                       svp = av_fetch(ret_av, funcctx->call_cntr, FALSE);
-                       Assert(svp != NULL);
-
-                       if (SvOK(*svp) && SvTYPE(*svp) != SVt_NULL)
-                       {
-                               char       *val = SvPV(*svp, PL_na);
-
-                               fcinfo->isnull = false;
-                               retval = FunctionCall3(&prodesc->result_in_func,
-                                                                          PointerGetDatum(val),
-                                                       ObjectIdGetDatum(prodesc->result_typioparam),
-                                                                          Int32GetDatum(-1));
-                       }
-                       else
-                       {
-                               fcinfo->isnull = true;
-                               retval = (Datum) 0;
-                       }
-                       SRF_RETURN_NEXT(funcctx, retval);
-               }
-               else
-               {
-                       SvREFCNT_dec(perlret);
-                       SRF_RETURN_DONE(funcctx);
+                       rsi->setResult = current_call_data->tuple_store;
+                       rsi->setDesc = current_call_data->ret_tdesc;
                }
+               retval = (Datum) 0;
+       }
+       else if (SvTYPE(perlret) == SVt_NULL)
+       {
+               /* Return NULL if Perl code returned undef */
+               if (rsi && IsA(rsi, ReturnSetInfo))
+                       rsi->isDone = ExprEndResult;
+               fcinfo->isnull = true;
+               retval = (Datum) 0;
        }
        else if (prodesc->fn_retistuple)
        {
-               /* singleton perl hash to Datum */
-               HV                 *perlhash;
+               /* Return a perl hash converted to a Datum */
                TupleDesc       td;
                AttInMetadata *attinmeta;
                HeapTuple       tup;
 
-               if (!SvOK(perlret) || SvTYPE(perlret) != SVt_RV || SvTYPE(SvRV(perlret)) != SVt_PVHV)
+               if (!SvOK(perlret) || SvTYPE(perlret) != SVt_RV ||
+                       SvTYPE(SvRV(perlret)) != SVt_PVHV)
+               {
                        ereport(ERROR,
                                        (errcode(ERRCODE_DATATYPE_MISMATCH),
-                                        errmsg("composite-returning Perl function must return reference to hash")));
-               perlhash = (HV *) SvRV(perlret);
+                                        errmsg("composite-returning Perl function "
+                                                       "must return reference to hash")));
+               }
 
-               /*
-                * XXX should cache the attinmeta data instead of recomputing
-                */
-               td = get_function_tupdesc(fcinfo);
-               /* td = CreateTupleDescCopy(td); */
-               attinmeta = TupleDescGetAttInMetadata(td);
+               /* XXX should cache the attinmeta data instead of recomputing */
+               if (get_call_result_type(fcinfo, NULL, &td) != TYPEFUNC_COMPOSITE)
+               {
+                       ereport(ERROR,
+                                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                        errmsg("function returning record called in context "
+                                                       "that cannot accept type record")));
+               }
 
-               tup = plperl_build_tuple_result(perlhash, attinmeta);
+               attinmeta = TupleDescGetAttInMetadata(td);
+               tup = plperl_build_tuple_result((HV *) SvRV(perlret), attinmeta);
                retval = HeapTupleGetDatum(tup);
        }
        else
        {
-               /* perl string to Datum */
-               char       *val = SvPV(perlret, PL_na);
+               /* Return a perl string converted to a Datum */
+               char       *val;
+
+               if (prodesc->fn_retisarray && SvROK(perlret) &&
+                       SvTYPE(SvRV(perlret)) == SVt_PVAV)
+               {
+                       array_ret = plperl_convert_to_pg_array(perlret);
+                       SvREFCNT_dec(perlret);
+                       perlret = array_ret;
+               }
+
+               val = SvPV(perlret, PL_na);
 
                retval = FunctionCall3(&prodesc->result_in_func,
                                                           CStringGetDatum(val),
@@ -1013,13 +1159,14 @@ plperl_func_handler(PG_FUNCTION_ARGS)
                                                           Int32GetDatum(-1));
        }
 
-       SvREFCNT_dec(perlret);
+       if (array_ret == NULL)
+               SvREFCNT_dec(perlret);
+
+       current_call_data = NULL;
        return retval;
 }
 
-/**********************************************************************
- * plperl_trigger_handler()            - Handler for trigger function calls
- **********************************************************************/
+
 static Datum
 plperl_trigger_handler(PG_FUNCTION_ARGS)
 {
@@ -1029,27 +1176,24 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
        SV                 *svTD;
        HV                 *hvTD;
 
+       /*
+        * Create the call_data beforing connecting to SPI, so that it is
+        * not allocated in the SPI memory context
+        */
+       current_call_data = (plperl_call_data *) palloc0(sizeof(plperl_call_data));
+       current_call_data->fcinfo = fcinfo;
+
        /* Connect to SPI manager */
        if (SPI_connect() != SPI_OK_CONNECT)
                elog(ERROR, "could not connect to SPI manager");
 
        /* Find or compile the function */
        prodesc = compile_plperl_function(fcinfo->flinfo->fn_oid, true);
+       current_call_data->prodesc = prodesc;
 
-       plperl_current_prodesc = prodesc;
-
-       /************************************************************
-       * Call the Perl function
-       ************************************************************/
-
-       /*
-        * call perl trigger function and build TD hash
-        */
        svTD = plperl_trigger_build_args(fcinfo);
        perlret = plperl_call_perl_trigger_func(prodesc, fcinfo, svTD);
-
-       hvTD = (HV *) SvRV(svTD);       /* convert SV TD structure to Perl Hash
-                                                                * structure */
+       hvTD = (HV *) SvRV(svTD);
 
        /************************************************************
        * Disconnect from SPI manager and then create the return
@@ -1072,7 +1216,7 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
                else if (TRIGGER_FIRED_BY_DELETE(trigdata->tg_event))
                        retval = (Datum) trigdata->tg_trigtuple;
                else
-                       retval = (Datum) 0;     /* can this happen? */
+                       retval = (Datum) 0; /* can this happen? */
        }
        else
        {
@@ -1097,7 +1241,7 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
                        {
                                ereport(WARNING,
                                                (errcode(ERRCODE_E_R_I_E_TRIGGER_PROTOCOL_VIOLATED),
-                                                errmsg("ignoring modified tuple in DELETE trigger")));
+                                          errmsg("ignoring modified tuple in DELETE trigger")));
                                trv = NULL;
                        }
                }
@@ -1105,7 +1249,8 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
                {
                        ereport(ERROR,
                                        (errcode(ERRCODE_E_R_I_E_TRIGGER_PROTOCOL_VIOLATED),
-                                        errmsg("result of Perl trigger function must be undef, \"SKIP\" or \"MODIFY\"")));
+                                        errmsg("result of Perl trigger function must be undef, "
+                                                       "\"SKIP\" or \"MODIFY\"")));
                        trv = NULL;
                }
                retval = PointerGetDatum(trv);
@@ -1115,12 +1260,11 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
        if (perlret)
                SvREFCNT_dec(perlret);
 
+       current_call_data = NULL;
        return retval;
 }
 
-/**********************************************************************
- * compile_plperl_function     - compile (or hopefully just look up) function
- **********************************************************************/
+
 static plperl_proc_desc *
 compile_plperl_function(Oid fn_oid, bool is_trigger)
 {
@@ -1130,7 +1274,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
        int                     proname_len;
        plperl_proc_desc *prodesc = NULL;
        int                     i;
-       SV                      **svp;
+       SV                **svp;
 
        /* We'll need the pg_proc tuple in any case... */
        procTup = SearchSysCache(PROCOID,
@@ -1141,7 +1285,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
        procStruct = (Form_pg_proc) GETSTRUCT(procTup);
 
        /************************************************************
-        * Build our internal proc name from the functions Oid
+        * Build our internal proc name from the function's Oid
         ************************************************************/
        if (!is_trigger)
                sprintf(internal_proname, "__PLPerl_proc_%u", fn_oid);
@@ -1166,7 +1310,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                 * function's pg_proc entry without changing its OID.
                 ************************************************************/
                uptodate = (prodesc->fn_xmin == HeapTupleHeaderGetXmin(procTup->t_data) &&
-                       prodesc->fn_cmin == HeapTupleHeaderGetCmin(procTup->t_data));
+                               prodesc->fn_cmin == HeapTupleHeaderGetCmin(procTup->t_data));
 
                if (!uptodate)
                {
@@ -1177,7 +1321,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
 
        /************************************************************
         * If we haven't found it in the hashtable, we analyze
-        * the functions arguments and returntype and store
+        * the function's arguments and return type and store
         * the in-/out-functions in the prodesc block and create
         * a new hashtable entry for it.
         *
@@ -1234,7 +1378,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                if (!is_trigger)
                {
                        typeTup = SearchSysCache(TYPEOID,
-                                                               ObjectIdGetDatum(procStruct->prorettype),
+                                                                        ObjectIdGetDatum(procStruct->prorettype),
                                                                         0, 0, 0);
                        if (!HeapTupleIsValid(typeTup))
                        {
@@ -1257,7 +1401,8 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                                        free(prodesc);
                                        ereport(ERROR,
                                                        (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                                        errmsg("trigger functions may only be called as triggers")));
+                                                        errmsg("trigger functions may only be called "
+                                                                       "as triggers")));
                                }
                                else
                                {
@@ -1265,8 +1410,8 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                                        free(prodesc);
                                        ereport(ERROR,
                                                        (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                                errmsg("plperl functions cannot return type %s",
-                                                               format_type_be(procStruct->prorettype))));
+                                                        errmsg("plperl functions cannot return type %s",
+                                                                       format_type_be(procStruct->prorettype))));
                                }
                        }
 
@@ -1275,6 +1420,9 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                        prodesc->fn_retistuple = (typeStruct->typtype == 'c' ||
                                                                          procStruct->prorettype == RECORDOID);
 
+                       prodesc->fn_retisarray =
+                               (typeStruct->typlen == -1 && typeStruct->typelem);
+
                        perm_fmgr_info(typeStruct->typinput, &(prodesc->result_in_func));
                        prodesc->result_typioparam = getTypeIOParam(typeTup);
 
@@ -1291,7 +1439,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                        for (i = 0; i < prodesc->nargs; i++)
                        {
                                typeTup = SearchSysCache(TYPEOID,
-                                                       ObjectIdGetDatum(procStruct->proargtypes.values[i]),
+                                                ObjectIdGetDatum(procStruct->proargtypes.values[i]),
                                                                                 0, 0, 0);
                                if (!HeapTupleIsValid(typeTup))
                                {
@@ -1309,8 +1457,8 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                                        free(prodesc);
                                        ereport(ERROR,
                                                        (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                                  errmsg("plperl functions cannot take type %s",
-                                                  format_type_be(procStruct->proargtypes.values[i]))));
+                                                        errmsg("plperl functions cannot take type %s",
+                                               format_type_be(procStruct->proargtypes.values[i]))));
                                }
 
                                if (typeStruct->typtype == 'c')
@@ -1343,7 +1491,7 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                 ************************************************************/
                prodesc->reference = plperl_create_sub(proc_source, prodesc->lanpltrusted);
                pfree(proc_source);
-               if (!prodesc->reference) /* can this happen? */
+               if (!prodesc->reference)        /* can this happen? */
                {
                        free(prodesc->proname);
                        free(prodesc);
@@ -1351,9 +1499,6 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
                                 internal_proname);
                }
 
-               /************************************************************
-                * Add the proc description block to the hashtable
-                ************************************************************/
                hv_store(plperl_proc_hash, internal_proname, proname_len,
                                 newSViv((IV) prodesc), 0);
        }
@@ -1364,10 +1509,8 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
 }
 
 
-/**********************************************************************
- * plperl_hash_from_tuple() - Build a ref to a hash
- *                               from all attributes of a given tuple
- **********************************************************************/
+/* Build a hash from all attributes of a given tuple. */
+
 static SV  *
 plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
 {
@@ -1385,6 +1528,7 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
                Oid                     typoutput;
                bool            typisvarlena;
                int                     namelen;
+               SV                 *sv;
 
                if (tupdesc->attrs[i]->attisdropped)
                        continue;
@@ -1393,7 +1537,8 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
                namelen = strlen(attname);
                attr = heap_getattr(tuple, i + 1, tupdesc, &isnull);
 
-               if (isnull) {
+               if (isnull)
+               {
                        /* Store (attname => undef) and move on. */
                        hv_store(hv, attname, namelen, newSV(0), 0);
                        continue;
@@ -1404,27 +1549,30 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
                getTypeOutputInfo(tupdesc->attrs[i]->atttypid,
                                                  &typoutput, &typisvarlena);
 
-               outputstr = DatumGetCString(OidFunctionCall1(typoutput,
-                                                                                                        attr));
+               outputstr = DatumGetCString(OidFunctionCall1(typoutput, attr));
+
+               sv = newSVpv(outputstr, 0);
+#if PERL_BCDVERSION >= 0x5006000L
+               if (GetDatabaseEncoding() == PG_UTF8)
+                       SvUTF8_on(sv);
+#endif
+               hv_store(hv, attname, namelen, sv, 0);
 
-               hv_store(hv, attname, namelen, newSVpv(outputstr, 0), 0);
+               pfree(outputstr);
        }
 
        return newRV_noinc((SV *) hv);
 }
 
 
-/*
- * Implementation of spi_exec_query() Perl function
- */
 HV *
 plperl_spi_exec(char *query, int limit)
 {
        HV                 *ret_hv;
 
        /*
-        * Execute the query inside a sub-transaction, so we can cope with
-        * errors sanely
+        * Execute the query inside a sub-transaction, so we can cope with errors
+        * sanely
         */
        MemoryContext oldcontext = CurrentMemoryContext;
        ResourceOwner oldowner = CurrentResourceOwner;
@@ -1437,7 +1585,7 @@ plperl_spi_exec(char *query, int limit)
        {
                int                     spi_rv;
 
-               spi_rv = SPI_execute(query, plperl_current_prodesc->fn_readonly,
+               spi_rv = SPI_execute(query, current_call_data->prodesc->fn_readonly,
                                                         limit);
                ret_hv = plperl_spi_execute_fetch_result(SPI_tuptable, SPI_processed,
                                                                                                 spi_rv);
@@ -1446,9 +1594,10 @@ plperl_spi_exec(char *query, int limit)
                ReleaseCurrentSubTransaction();
                MemoryContextSwitchTo(oldcontext);
                CurrentResourceOwner = oldowner;
+
                /*
-                * AtEOSubXact_SPI() should not have popped any SPI context,
-                * but just in case it did, make sure we remain connected.
+                * AtEOSubXact_SPI() should not have popped any SPI context, but just
+                * in case it did, make sure we remain connected.
                 */
                SPI_restore_connection();
        }
@@ -1467,9 +1616,9 @@ plperl_spi_exec(char *query, int limit)
                CurrentResourceOwner = oldowner;
 
                /*
-                * If AtEOSubXact_SPI() popped any SPI context of the subxact,
-                * it will have left us in a disconnected state.  We need this
-                * hack to return to connected state.
+                * If AtEOSubXact_SPI() popped any SPI context of the subxact, it will
+                * have left us in a disconnected state.  We need this hack to return
+                * to connected state.
                 */
                SPI_restore_connection();
 
@@ -1484,6 +1633,7 @@ plperl_spi_exec(char *query, int limit)
        return ret_hv;
 }
 
+
 static HV  *
 plperl_spi_execute_fetch_result(SPITupleTable *tuptable, int processed,
                                                                int status)
@@ -1517,3 +1667,281 @@ plperl_spi_execute_fetch_result(SPITupleTable *tuptable, int processed,
 
        return result;
 }
+
+
+/*
+ * Note: plperl_return_next is called both in Postgres and Perl contexts.
+ * We report any errors in Postgres fashion (via ereport).     If called in
+ * Perl context, it is SPI.xs's responsibility to catch the error and
+ * convert to a Perl error.  We assume (perhaps without adequate justification)
+ * that we need not abort the current transaction if the Perl code traps the
+ * error.
+ */
+void
+plperl_return_next(SV *sv)
+{
+       plperl_proc_desc *prodesc;
+       FunctionCallInfo fcinfo;
+       ReturnSetInfo *rsi;
+       MemoryContext old_cxt;
+       HeapTuple       tuple;
+
+       if (!sv)
+               return;
+
+       prodesc = current_call_data->prodesc;
+       fcinfo = current_call_data->fcinfo;
+       rsi = (ReturnSetInfo *) fcinfo->resultinfo;
+
+       if (!prodesc->fn_retisset)
+               ereport(ERROR,
+                               (errcode(ERRCODE_SYNTAX_ERROR),
+                                errmsg("cannot use return_next in a non-SETOF function")));
+
+       if (prodesc->fn_retistuple &&
+               !(SvOK(sv) && SvTYPE(sv) == SVt_RV && SvTYPE(SvRV(sv)) == SVt_PVHV))
+               ereport(ERROR,
+                               (errcode(ERRCODE_DATATYPE_MISMATCH),
+                                errmsg("setof-composite-returning Perl function "
+                                               "must call return_next with reference to hash")));
+
+       if (!current_call_data->ret_tdesc)
+       {
+               TupleDesc tupdesc;
+
+               Assert(!current_call_data->tuple_store);
+               Assert(!current_call_data->attinmeta);
+
+               /*
+                * This is the first call to return_next in the current
+                * PL/Perl function call, so memoize some lookups
+                */
+               if (prodesc->fn_retistuple)
+                       (void) get_call_result_type(fcinfo, NULL, &tupdesc);
+               else
+                       tupdesc = rsi->expectedDesc;
+
+               /*
+                * Make sure the tuple_store and ret_tdesc are sufficiently
+                * long-lived.
+                */
+               old_cxt = MemoryContextSwitchTo(rsi->econtext->ecxt_per_query_memory);
+
+               current_call_data->ret_tdesc = CreateTupleDescCopy(tupdesc);
+               current_call_data->tuple_store =
+                       tuplestore_begin_heap(true, false, work_mem);
+               if (prodesc->fn_retistuple)
+               {
+                       current_call_data->attinmeta =
+                               TupleDescGetAttInMetadata(current_call_data->ret_tdesc);
+               }
+
+               MemoryContextSwitchTo(old_cxt);
+       }               
+
+       /*
+        * Producing the tuple we want to return requires making plenty of
+        * palloc() allocations that are not cleaned up. Since this
+        * function can be called many times before the current memory
+        * context is reset, we need to do those allocations in a
+        * temporary context.
+        */
+       if (!current_call_data->tmp_cxt)
+       {
+               current_call_data->tmp_cxt =
+                       AllocSetContextCreate(rsi->econtext->ecxt_per_tuple_memory,
+                                                                 "PL/Perl return_next temporary cxt",
+                                                                 ALLOCSET_DEFAULT_MINSIZE,
+                                                                 ALLOCSET_DEFAULT_INITSIZE,
+                                                                 ALLOCSET_DEFAULT_MAXSIZE);
+       }
+
+       old_cxt = MemoryContextSwitchTo(current_call_data->tmp_cxt);
+
+       if (prodesc->fn_retistuple)
+       {
+               tuple = plperl_build_tuple_result((HV *) SvRV(sv),
+                                                                                 current_call_data->attinmeta);
+       }
+       else
+       {
+               Datum           ret = (Datum) 0;
+               bool            isNull = true;
+
+               if (SvOK(sv) && SvTYPE(sv) != SVt_NULL)
+               {
+                       char       *val = SvPV(sv, PL_na);
+
+                       ret = FunctionCall3(&prodesc->result_in_func,
+                                                               PointerGetDatum(val),
+                                                               ObjectIdGetDatum(prodesc->result_typioparam),
+                                                               Int32GetDatum(-1));
+                       isNull = false;
+               }
+
+               tuple = heap_form_tuple(current_call_data->ret_tdesc, &ret, &isNull);
+       }
+
+       /* Make sure to store the tuple in a long-lived memory context */
+       MemoryContextSwitchTo(rsi->econtext->ecxt_per_query_memory);
+       tuplestore_puttuple(current_call_data->tuple_store, tuple);
+       MemoryContextSwitchTo(old_cxt);
+
+       MemoryContextReset(current_call_data->tmp_cxt);
+}
+
+
+SV *
+plperl_spi_query(char *query)
+{
+       SV                 *cursor;
+
+       /*
+        * Execute the query inside a sub-transaction, so we can cope with errors
+        * sanely
+        */
+       MemoryContext oldcontext = CurrentMemoryContext;
+       ResourceOwner oldowner = CurrentResourceOwner;
+
+       BeginInternalSubTransaction(NULL);
+       /* Want to run inside function's memory context */
+       MemoryContextSwitchTo(oldcontext);
+
+       PG_TRY();
+       {
+               void       *plan;
+               Portal          portal = NULL;
+
+               /* Create a cursor for the query */
+               plan = SPI_prepare(query, 0, NULL);
+               if (plan)
+                       portal = SPI_cursor_open(NULL, plan, NULL, NULL, false);
+               if (portal)
+                       cursor = newSVpv(portal->name, 0);
+               else
+                       cursor = newSV(0);
+
+               /* Commit the inner transaction, return to outer xact context */
+               ReleaseCurrentSubTransaction();
+               MemoryContextSwitchTo(oldcontext);
+               CurrentResourceOwner = oldowner;
+
+               /*
+                * AtEOSubXact_SPI() should not have popped any SPI context, but just
+                * in case it did, make sure we remain connected.
+                */
+               SPI_restore_connection();
+       }
+       PG_CATCH();
+       {
+               ErrorData  *edata;
+
+               /* Save error info */
+               MemoryContextSwitchTo(oldcontext);
+               edata = CopyErrorData();
+               FlushErrorState();
+
+               /* Abort the inner transaction */
+               RollbackAndReleaseCurrentSubTransaction();
+               MemoryContextSwitchTo(oldcontext);
+               CurrentResourceOwner = oldowner;
+
+               /*
+                * If AtEOSubXact_SPI() popped any SPI context of the subxact, it will
+                * have left us in a disconnected state.  We need this hack to return
+                * to connected state.
+                */
+               SPI_restore_connection();
+
+               /* Punt the error to Perl */
+               croak("%s", edata->message);
+
+               /* Can't get here, but keep compiler quiet */
+               return NULL;
+       }
+       PG_END_TRY();
+
+       return cursor;
+}
+
+
+SV *
+plperl_spi_fetchrow(char *cursor)
+{
+       SV                 *row;
+
+       /*
+        * Execute the FETCH inside a sub-transaction, so we can cope with errors
+        * sanely
+        */
+       MemoryContext oldcontext = CurrentMemoryContext;
+       ResourceOwner oldowner = CurrentResourceOwner;
+
+       BeginInternalSubTransaction(NULL);
+       /* Want to run inside function's memory context */
+       MemoryContextSwitchTo(oldcontext);
+
+       PG_TRY();
+       {
+               Portal          p = SPI_cursor_find(cursor);
+
+               if (!p)
+                       row = newSV(0);
+               else
+               {
+                       SPI_cursor_fetch(p, true, 1);
+                       if (SPI_processed == 0)
+                       {
+                               SPI_cursor_close(p);
+                               row = newSV(0);
+                       }
+                       else
+                       {
+                               row = plperl_hash_from_tuple(SPI_tuptable->vals[0],
+                                                                                        SPI_tuptable->tupdesc);
+                       }
+                       SPI_freetuptable(SPI_tuptable);
+               }
+
+               /* Commit the inner transaction, return to outer xact context */
+               ReleaseCurrentSubTransaction();
+               MemoryContextSwitchTo(oldcontext);
+               CurrentResourceOwner = oldowner;
+
+               /*
+                * AtEOSubXact_SPI() should not have popped any SPI context, but just
+                * in case it did, make sure we remain connected.
+                */
+               SPI_restore_connection();
+       }
+       PG_CATCH();
+       {
+               ErrorData  *edata;
+
+               /* Save error info */
+               MemoryContextSwitchTo(oldcontext);
+               edata = CopyErrorData();
+               FlushErrorState();
+
+               /* Abort the inner transaction */
+               RollbackAndReleaseCurrentSubTransaction();
+               MemoryContextSwitchTo(oldcontext);
+               CurrentResourceOwner = oldowner;
+
+               /*
+                * If AtEOSubXact_SPI() popped any SPI context of the subxact, it will
+                * have left us in a disconnected state.  We need this hack to return
+                * to connected state.
+                */
+               SPI_restore_connection();
+
+               /* Punt the error to Perl */
+               croak("%s", edata->message);
+
+               /* Can't get here, but keep compiler quiet */
+               return NULL;
+       }
+       PG_END_TRY();
+
+       return row;
+}