]> granicus.if.org Git - shadow/blobdiff - src/groupadd.c
* src/passwd.c: Overflow when computing the number of days based
[shadow] / src / groupadd.c
index 8b47653c99ddf56a53506cc51880270a81975cb9..7ec21e942d33bd95c3e8990f5ffb05593733b693 100644 (file)
@@ -1,5 +1,8 @@
 /*
- * Copyright 1991 - 1993, Julianne Frances Haugh
+ * Copyright (c) 1991 - 1993, Julianne Frances Haugh
+ * Copyright (c) 1996 - 2000, Marek Michałkiewicz
+ * Copyright (c) 2000 - 2006, Tomasz Kłoczko
+ * Copyright (c) 2007 - 2009, Nicolas François
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Julianne F. Haugh nor the names of its contributors
- *    may be used to endorse or promote products derived from this software
- *    without specific prior written permission.
+ * 3. The name of the copyright holders or contributors may not be used to
+ *    endorse or promote products derived from this software without
+ *    specific prior written permission.
  *
- * THIS SOFTWARE IS PROVIDED BY JULIE HAUGH AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL JULIE HAUGH OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+ * PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT
+ * HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include <config.h>
 #include <grp.h>
 #include <stdio.h>
 #include <sys/types.h>
+#ifdef ACCT_TOOLS_SETUID
 #ifdef USE_PAM
 #include "pam_defs.h"
 #include <pwd.h>
 #endif                         /* USE_PAM */
+#endif                         /* ACCT_TOOLS_SETUID */
 #include "chkname.h"
 #include "defines.h"
 #include "getdef.h"
 #include "prototypes.h"
 #ifdef SHADOWGRP
 #include "sgroupio.h"
-static int is_shadow_grp;
 #endif
 
 /*
  * exit status values
  */
+/*@-exitarg@*/
 #define E_SUCCESS      0       /* success */
 #define E_USAGE                2       /* invalid command syntax */
 #define E_BAD_ARG      3       /* invalid argument to option */
@@ -65,48 +70,60 @@ static int is_shadow_grp;
 /*
  * Global variables
  */
-static char *group_name;
+const char *Prog;
+
+static /*@null@*/char *group_name;
 static gid_t group_id;
-static char *empty_list = NULL;
+static /*@null@*/char *group_passwd;
+static /*@null@*/char *empty_list = NULL;
 
-static char *Prog;
+static bool oflg = false;      /* permit non-unique group ID to be specified with -g */
+static bool gflg = false;      /* ID value for the new group */
+static bool fflg = false;      /* if group already exists, do nothing and exit(0) */
+static bool rflg = false;      /* create a system account */
+static bool pflg = false;      /* new encrypted password */
 
-static int oflg = 0;           /* permit non-unique group ID to be specified with -g */
-static int gflg = 0;           /* ID value for the new group */
-static int fflg = 0;           /* if group already exists, do nothing and exit(0) */
+#ifdef SHADOWGRP
+static bool is_shadow_grp;
+#endif
 
 /* local function prototypes */
-static void usage (void);
-static void new_grent (struct group *);
+static void usage (int status);
+static void new_grent (struct group *grent);
 
 #ifdef SHADOWGRP
-static void new_sgent (struct sgrp *);
+static void new_sgent (struct sgrp *sgent);
 #endif
 static void grp_update (void);
-static void find_new_gid (void);
 static void check_new_name (void);
 static void close_files (void);
 static void open_files (void);
-static void fail_exit (int);
-static gid_t get_gid (const char *gidstr);
+static void process_flags (int argc, char **argv);
+static void check_flags (void);
+static void check_perms (void);
 
 /*
  * usage - display usage message and exit
  */
-static void usage (void)
+static void usage (int status)
 {
-       fprintf (stderr, _("Usage: groupadd [options] GROUP\n"
-                          "\n"
-                          "Options:\n"
-                          "  -f, --force                   force exit with success status if the\n"
-                          "                                specified group already exists\n"
-                          "  -g, --gid GID                 use GID for the new group\n"
-                          "  -h, --help                    display this help message and exit\n"
-                          "  -K, --key KEY=VALUE           overrides /etc/login.defs defaults\n"
-                          "  -o, --non-unique              allow create group with duplicate\n"
-                          "                                (non-unique) GID\n"
-                          "\n"));
-       exit (E_USAGE);
+       FILE *usageout = (E_SUCCESS != status) ? stderr : stdout;
+       (void) fprintf (usageout,
+                       _("Usage: %s [options] GROUP\n"
+                         "\n"
+                         "Options:\n"),
+                       Prog);
+       (void) fputs (_("  -f, --force                   exit successfully if the group already exists,\n"
+                       "                                and cancel -g if the GID is already used\n"), usageout);
+       (void) fputs (_("  -g, --gid GID                 use GID for the new group\n"), usageout);
+       (void) fputs (_("  -h, --help                    display this help message and exit\n"), usageout);
+       (void) fputs (_("  -K, --key KEY=VALUE           override /etc/login.defs defaults\n"), usageout);
+       (void) fputs (_("  -o, --non-unique              allow to create groups with duplicate\n"
+                       "                                (non-unique) GID\n"), usageout);
+       (void) fputs (_("  -p, --password PASSWORD       use this encrypted password for the new group\n"), usageout);
+       (void) fputs (_("  -r, --system                  create a system account\n"), usageout);
+       (void) fputs ("\n", usageout);
+       exit (status);
 }
 
 /*
@@ -119,7 +136,11 @@ static void new_grent (struct group *grent)
 {
        memzero (grent, sizeof *grent);
        grent->gr_name = group_name;
-       grent->gr_passwd = SHADOW_PASSWD_STRING;        /* XXX warning: const */
+       if (pflg) {
+               grent->gr_passwd = group_passwd;
+       } else {
+               grent->gr_passwd = SHADOW_PASSWD_STRING;        /* XXX warning: const */
+       }
        grent->gr_gid = group_id;
        grent->gr_mem = &empty_list;
 }
@@ -135,7 +156,11 @@ static void new_sgent (struct sgrp *sgent)
 {
        memzero (sgent, sizeof *sgent);
        sgent->sg_name = group_name;
-       sgent->sg_passwd = "!"; /* XXX warning: const */
+       if (pflg) {
+               sgent->sg_passwd = group_passwd;
+       } else {
+               sgent->sg_passwd = "!"; /* XXX warning: const */
+       }
        sgent->sg_adm = &empty_list;
        sgent->sg_mem = &empty_list;
 }
@@ -154,104 +179,49 @@ static void grp_update (void)
        struct sgrp sgrp;
 #endif                         /* SHADOWGRP */
 
+       /*
+        * To add the group, we need to update /etc/group.
+        * Make sure failures will be reported.
+        */
+       add_cleanup (cleanup_report_add_group_group, group_name);
+#ifdef SHADOWGRP
+       if (is_shadow_grp) {
+               /* We also need to update /etc/gshadow */
+               add_cleanup (cleanup_report_add_group_gshadow, group_name);
+       }
+#endif
+
        /*
         * Create the initial entries for this new group.
         */
        new_grent (&grp);
 #ifdef SHADOWGRP
        new_sgent (&sgrp);
+       if (is_shadow_grp && pflg) {
+               grp.gr_passwd = SHADOW_PASSWD_STRING;   /* XXX warning: const */
+       }
 #endif                         /* SHADOWGRP */
 
        /*
         * Write out the new group file entry.
         */
-       if (!gr_update (&grp)) {
-               fprintf (stderr, _("%s: error adding new group entry\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
+       if (gr_update (&grp) == 0) {
+               fprintf (stderr,
+                        _("%s: failed to prepare the new %s entry '%s'\n"),
+                        Prog, gr_dbname (), grp.gr_name);
+               exit (E_GRP_UPDATE);
        }
 #ifdef SHADOWGRP
        /*
         * Write out the new shadow group entries as well.
         */
-       if (is_shadow_grp && !sgr_update (&sgrp)) {
-               fprintf (stderr, _("%s: error adding new group entry\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
+       if (is_shadow_grp && (sgr_update (&sgrp) == 0)) {
+               fprintf (stderr,
+                        _("%s: failed to prepare the new %s entry '%s'\n"),
+                        Prog, sgr_dbname (), sgrp.sg_name);
+               exit (E_GRP_UPDATE);
        }
 #endif                         /* SHADOWGRP */
-#ifdef WITH_AUDIT
-       audit_logger (AUDIT_USER_CHAUTHTOK, Prog, "adding group", group_name,
-                     group_id, 1);
-#endif
-       SYSLOG ((LOG_INFO, "new group: name=%s, GID=%u",
-                group_name, (unsigned int) group_id));
-}
-
-/*
- * find_new_gid - find the next available GID
- *
- *     find_new_gid() locates the next highest unused GID in the group
- *     file, or checks the given group ID against the existing ones for
- *     uniqueness.
- */
-static void find_new_gid (void)
-{
-       const struct group *grp;
-       gid_t gid_min, gid_max;
-
-       gid_min = getdef_unum ("GID_MIN", 1000);
-       gid_max = getdef_unum ("GID_MAX", 60000);
-
-       /*
-        * Start with some GID value if the user didn't provide us with
-        * one already.
-        */
-
-       if (!gflg)
-               group_id = gid_min;
-
-       /*
-        * Search the entire group file, either looking for this GID (if the
-        * user specified one with -g) or looking for the largest unused
-        * value.
-        */
-       setgrent ();
-       while ((grp = getgrent ())) {
-               if (strcmp (group_name, grp->gr_name) == 0) {
-                       if (fflg) {
-                               fail_exit (E_SUCCESS);
-                       }
-                       fprintf (stderr, _("%s: name %s is not unique\n"),
-                                Prog, group_name);
-                       fail_exit (E_NAME_IN_USE);
-               }
-               if (gflg && group_id == grp->gr_gid) {
-                       if (fflg) {
-                               /* turn off -g and search again */
-                               gflg = 0;
-                               setgrent ();
-                               continue;
-                       }
-                       fprintf (stderr, _("%s: GID %u is not unique\n"),
-                                Prog, (unsigned int) group_id);
-                       fail_exit (E_GID_IN_USE);
-               }
-               if (!gflg && grp->gr_gid >= group_id) {
-                       if (grp->gr_gid > gid_max)
-                               continue;
-                       group_id = grp->gr_gid + 1;
-               }
-       }
-       if (!gflg && group_id == gid_max + 1) {
-               for (group_id = gid_min; group_id < gid_max; group_id++) {
-                       /* local, no need for xgetgrgid */
-                       if (!getgrgid (group_id))
-                               break;
-               }
-               if (group_id == gid_max) {
-                       fprintf (stderr, _("%s: can't get unique GID\n"), Prog);
-                       fail_exit (E_GID_IN_USE);
-               }
-       }
 }
 
 /*
@@ -262,15 +232,16 @@ static void find_new_gid (void)
  */
 static void check_new_name (void)
 {
-       if (check_group_name (group_name))
+       if (is_valid_group_name (group_name)) {
                return;
+       }
 
        /*
         * All invalid group names land here.
         */
 
-       fprintf (stderr, _("%s: %s is not a valid group name\n"),
-                Prog, group_name);
+       fprintf (stderr, _("%s: '%s' is not a valid group name\n"),
+                Prog, group_name);
 
        exit (E_BAD_ARG);
 }
@@ -283,20 +254,60 @@ static void check_new_name (void)
  */
 static void close_files (void)
 {
-       if (!gr_close ()) {
-               fprintf (stderr, _("%s: cannot rewrite group file\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
+       /* First, write the changes in the regular group database */
+       if (gr_close () == 0) {
+               fprintf (stderr,
+                        _("%s: failure while writing changes to %s\n"),
+                        Prog, gr_dbname ());
+               exit (E_GRP_UPDATE);
        }
-       gr_unlock ();
+#ifdef WITH_AUDIT
+       audit_logger (AUDIT_ADD_GROUP, Prog,
+                     "adding group to /etc/group",
+                     group_name, (unsigned int) group_id,
+                     SHADOW_AUDIT_SUCCESS);
+#endif
+       SYSLOG ((LOG_INFO, "group added to %s: name=%s, GID=%u",
+                gr_dbname (), group_name, (unsigned int) group_id));
+       del_cleanup (cleanup_report_add_group_group);
+
+       cleanup_unlock_group (NULL);
+       del_cleanup (cleanup_unlock_group);
+
+       /* Now, write the changes in the shadow database */
 #ifdef SHADOWGRP
-       if (is_shadow_grp && !sgr_close ()) {
-               fprintf (stderr,
-                        _("%s: cannot rewrite shadow group file\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
+       if (is_shadow_grp) {
+               if (sgr_close () == 0) {
+                       fprintf (stderr,
+                                _("%s: failure while writing changes to %s\n"),
+                                Prog, sgr_dbname ());
+                       exit (E_GRP_UPDATE);
+               }
+#ifdef WITH_AUDIT
+               audit_logger (AUDIT_ADD_GROUP, Prog,
+                             "adding group to /etc/gshadow",
+                             group_name, (unsigned int) group_id,
+                             SHADOW_AUDIT_SUCCESS);
+#endif
+               SYSLOG ((LOG_INFO, "group added to %s: name=%s",
+                        sgr_dbname (), group_name));
+               del_cleanup (cleanup_report_add_group_gshadow);
+
+               cleanup_unlock_gshadow (NULL);
+               del_cleanup (cleanup_unlock_gshadow);
        }
-       if (is_shadow_grp)
-               sgr_unlock ();
 #endif                         /* SHADOWGRP */
+
+       /* Report success at the system level */
+#ifdef WITH_AUDIT
+       audit_logger (AUDIT_ADD_GROUP, Prog,
+                     "",
+                     group_name, (unsigned int) group_id,
+                     SHADOW_AUDIT_SUCCESS);
+#endif
+       SYSLOG ((LOG_INFO, "new group: name=%s, GID=%u",
+                group_name, (unsigned int) group_id));
+       del_cleanup (cleanup_report_add_group);
 }
 
 /*
@@ -306,224 +317,278 @@ static void close_files (void)
  */
 static void open_files (void)
 {
-       if (!gr_lock ()) {
-               fprintf (stderr, _("%s: unable to lock group file\n"), Prog);
-#ifdef WITH_AUDIT
-               audit_logger (AUDIT_USER_CHAUTHTOK, Prog, "locking group file",
-                             group_name, -1, 0);
-#endif
+       /* First, lock the databases */
+       if (gr_lock () == 0) {
+               fprintf (stderr,
+                        _("%s: cannot lock %s; try again later.\n"),
+                        Prog, gr_dbname ());
                exit (E_GRP_UPDATE);
        }
-       if (!gr_open (O_RDWR)) {
-               fprintf (stderr, _("%s: unable to open group file\n"), Prog);
-#ifdef WITH_AUDIT
-               audit_logger (AUDIT_USER_CHAUTHTOK, Prog, "opening group file",
-                             group_name, -1, 0);
-#endif
-               fail_exit (E_GRP_UPDATE);
-       }
+       add_cleanup (cleanup_unlock_group, NULL);
+
 #ifdef SHADOWGRP
-       if (is_shadow_grp && !sgr_lock ()) {
-               fprintf (stderr,
-                        _("%s: unable to lock shadow group file\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
-       }
-       if (is_shadow_grp && !sgr_open (O_RDWR)) {
-               fprintf (stderr,
-                        _("%s: unable to open shadow group file\n"), Prog);
-               fail_exit (E_GRP_UPDATE);
+       if (is_shadow_grp) {
+               if (sgr_lock () == 0) {
+                       fprintf (stderr,
+                                _("%s: cannot lock %s; try again later.\n"),
+                                Prog, sgr_dbname ());
+                       exit (E_GRP_UPDATE);
+               }
+               add_cleanup (cleanup_unlock_gshadow, NULL);
        }
 #endif                         /* SHADOWGRP */
-}
 
-/*
- * fail_exit - exit with an error code after unlocking files
- */
-static void fail_exit (int code)
-{
-       (void) gr_unlock ();
+       /*
+        * Now if the group is not added, it's our fault.
+        * Make sure failures will be reported.
+        */
+       add_cleanup (cleanup_report_add_group, group_name);
+
+       /* And now open the databases */
+       if (gr_open (O_RDWR) == 0) {
+               fprintf (stderr, _("%s: cannot open %s\n"), Prog, gr_dbname ());
+               SYSLOG ((LOG_WARN, "cannot open %s", gr_dbname ()));
+               exit (E_GRP_UPDATE);
+       }
+
 #ifdef SHADOWGRP
-       if (is_shadow_grp)
-               sgr_unlock ();
-#endif
-#ifdef WITH_AUDIT
-       if (code != E_SUCCESS)
-               audit_logger (AUDIT_USER_CHAUTHTOK, Prog, "adding group",
-                             group_name, -1, 0);
-#endif
-       exit (code);
+       if (is_shadow_grp) {
+               if (sgr_open (O_RDWR) == 0) {
+                       fprintf (stderr,
+                                _("%s: cannot open %s\n"),
+                                Prog, sgr_dbname ());
+                       SYSLOG ((LOG_WARN, "cannot open %s", sgr_dbname ()));
+                       exit (E_GRP_UPDATE);
+               }
+       }
+#endif                         /* SHADOWGRP */
 }
 
 /*
- * get_id - validate and get group ID
+ * process_flags - parse the command line options
+ *
+ *     It will not return if an error is encountered.
  */
-static gid_t get_gid (const char *gidstr)
+static void process_flags (int argc, char **argv)
 {
-       long val;
-       char *errptr;
-
-       val = strtol (gidstr, &errptr, 10);
-       if (*errptr || errno == ERANGE || val < 0) {
-               fprintf (stderr, _("%s: invalid numeric argument '%s'\n"), Prog,
-                        gidstr);
-               exit (E_BAD_ARG);
+       /*
+        * Parse the command line options.
+        */
+       char *cp;
+       int option_index = 0;
+       int c;
+       static struct option long_options[] = {
+               {"force", no_argument, NULL, 'f'},
+               {"gid", required_argument, NULL, 'g'},
+               {"help", no_argument, NULL, 'h'},
+               {"key", required_argument, NULL, 'K'},
+               {"non-unique", no_argument, NULL, 'o'},
+               {"password", required_argument, NULL, 'p'},
+               {"system", no_argument, NULL, 'r'},
+               {NULL, 0, NULL, '\0'}
+       };
+
+       while ((c =
+               getopt_long (argc, argv, "fg:hK:op:r", long_options,
+                            &option_index)) != -1) {
+               switch (c) {
+               case 'f':
+                       /*
+                        * "force" - do nothing, just exit(0), if the
+                        * specified group already exists. With -g, if
+                        * specified gid already exists, choose another
+                        * (unique) gid (turn off -g). Based on the RedHat's
+                        * patch from shadow-utils-970616-9.
+                        */
+                       fflg = true;
+                       break;
+               case 'g':
+                       gflg = true;
+                       if (   (get_gid (optarg, &group_id) == 0)
+                           || (group_id == (gid_t)-1)) {
+                               fprintf (stderr,
+                                        _("%s: invalid group ID '%s'\n"),
+                                        Prog, optarg);
+                               exit (E_BAD_ARG);
+                       }
+                       break;
+               case 'h':
+                       usage (E_SUCCESS);
+                       break;
+               case 'K':
+                       /*
+                        * override login.defs defaults (-K name=value)
+                        * example: -K GID_MIN=100 -K GID_MAX=499
+                        * note: -K GID_MIN=10,GID_MAX=499 doesn't work yet
+                        */
+                       cp = strchr (optarg, '=');
+                       if (NULL == cp) {
+                               fprintf (stderr,
+                                        _("%s: -K requires KEY=VALUE\n"),
+                                        Prog);
+                               exit (E_BAD_ARG);
+                       }
+                       /* terminate name, point to value */
+                       *cp++ = '\0';
+                       if (putdef_str (optarg, cp) < 0) {
+                               exit (E_BAD_ARG);
+                       }
+                       break;
+               case 'o':
+                       oflg = true;
+                       break;
+               case 'p':
+                       pflg = true;
+                       group_passwd = optarg;
+                       break;
+               case 'r':
+                       rflg = true;
+                       break;
+               default:
+                       usage (E_USAGE);
+               }
        }
-       return val;
+
+       /*
+        * Check the flags consistency
+        */
+       if (optind != argc - 1) {
+               usage (E_USAGE);
+       }
+       group_name = argv[optind];
+
+       check_flags ();
 }
 
 /*
- * main - groupadd command
+ * check_flags - check flags and parameters consistency
+ *
+ *     It will not return if an error is encountered.
  */
-
-int main (int argc, char **argv)
+static void check_flags (void)
 {
-#ifdef USE_PAM
-       pam_handle_t *pamh = NULL;
-       int retval;
-#endif
+       /* -o does not make sense without -g */
+       if (oflg && !gflg) {
+               usage (E_USAGE);
+       }
+
+       check_new_name ();
 
-#ifdef WITH_AUDIT
-       audit_help_open ();
-#endif
        /*
-        * Get my name so that I can use it to report errors.
+        * Check if the group already exist.
         */
-       Prog = Basename (argv[0]);
-
-       setlocale (LC_ALL, "");
-       bindtextdomain (PACKAGE, LOCALEDIR);
-       textdomain (PACKAGE);
-
-       OPENLOG ("groupadd");
+       /* local, no need for xgetgrnam */
+       if (getgrnam (group_name) != NULL) {
+               /* The group already exist */
+               if (fflg) {
+                       /* OK, no need to do anything */
+                       exit (E_SUCCESS);
+               }
+               fprintf (stderr,
+                        _("%s: group '%s' already exists\n"),
+                        Prog, group_name);
+               exit (E_NAME_IN_USE);
+       }
 
-       {
-               /*
-                * Parse the command line options.
+       if (gflg && (getgrgid (group_id) != NULL)) {
+               /* A GID was specified, and a group already exist with that GID
+                *  - either we will use this GID anyway (-o)
+                *  - either we ignore the specified GID and
+                *    we will use another one (-f)
+                *  - either it is a failure
                 */
-               char *cp;
-               int option_index = 0;
-               int c;
-               static struct option long_options[] = {
-                       {"force", no_argument, NULL, 'f'},
-                       {"gid", required_argument, NULL, 'g'},
-                       {"help", no_argument, NULL, 'h'},
-                       {"key", required_argument, NULL, 'K'},
-                       {"non-unique", required_argument, NULL, 'o'},
-                       {NULL, 0, NULL, '\0'}
-               };
-
-               while ((c =
-                       getopt_long (argc, argv, "fg:hK:o", long_options,
-                                    &option_index)) != -1) {
-                       switch (c) {
-                       case 'f':
-                               /*
-                                * "force" - do nothing, just exit(0), if the
-                                * specified group already exists. With -g, if
-                                * specified gid already exists, choose another
-                                * (unique) gid (turn off -g). Based on the RedHat's
-                                * patch from shadow-utils-970616-9.
-                                */
-                               fflg++;
-                               break;
-                       case 'g':
-                               gflg++;
-                               group_id = get_gid (optarg);
-                               break;
-                       case 'h':
-                               usage ();
-                               break;
-                       case 'K':
-                               /*
-                                * override login.defs defaults (-K name=value)
-                                * example: -K GID_MIN=100 -K GID_MAX=499
-                                * note: -K GID_MIN=10,GID_MAX=499 doesn't work yet
-                                */
-                               cp = strchr (optarg, '=');
-                               if (!cp) {
-                                       fprintf (stderr,
-                                                _
-                                                ("%s: -K requires KEY=VALUE\n"),
-                                                Prog);
-                                       exit (E_BAD_ARG);
-                               }
-                               /* terminate name, point to value */
-                               *cp++ = '\0';
-                               if (putdef_str (optarg, cp) < 0)
-                                       exit (E_BAD_ARG);
-                               break;
-                       case 'o':
-                               oflg++;
-                               break;
-                       default:
-                               usage ();
-                       }
+               if (oflg) {
+                       /* Continue with this GID */
+               } else if (fflg) {
+                       /* Turn off -g, we can use any GID */
+                       gflg = false;
+               } else {
+                       fprintf (stderr,
+                                _("%s: GID '%lu' already exists\n"),
+                                Prog, (unsigned long int) group_id);
+                       exit (E_GID_IN_USE);
                }
        }
+}
 
-       if (oflg && !gflg)
-               usage ();
-
-       if (optind != argc - 1)
-               usage ();
-
-       group_name = argv[argc - 1];
-       check_new_name ();
-
+/*
+ * check_perms - check if the caller is allowed to add a group
+ *
+ *     With PAM support, the setuid bit can be set on groupadd to allow
+ *     non-root users to groups.
+ *     Without PAM support, only users who can write in the group databases
+ *     can add groups.
+ *
+ *     It will not return if the user is not allowed.
+ */
+static void check_perms (void)
+{
+#ifdef ACCT_TOOLS_SETUID
 #ifdef USE_PAM
-       retval = PAM_SUCCESS;
-
-       {
-               struct passwd *pampw;
-               pampw = getpwuid (getuid ()); /* local, no need for xgetpwuid */
-               if (pampw == NULL) {
-                       retval = PAM_USER_UNKNOWN;
-               }
+       pam_handle_t *pamh = NULL;
+       int retval;
+       struct passwd *pampw;
 
-               if (retval == PAM_SUCCESS) {
-                       retval = pam_start ("groupadd", pampw->pw_name,
-                                           &conv, &pamh);
-               }
+       pampw = getpwuid (getuid ()); /* local, no need for xgetpwuid */
+       if (NULL == pampw) {
+               fprintf (stderr,
+                        _("%s: Cannot determine your user name.\n"),
+                        Prog);
+               exit (1);
        }
 
-       if (retval == PAM_SUCCESS) {
+       retval = pam_start ("groupadd", pampw->pw_name, &conv, &pamh);
+
+       if (PAM_SUCCESS == retval) {
                retval = pam_authenticate (pamh, 0);
-               if (retval != PAM_SUCCESS) {
-                       pam_end (pamh, retval);
-               }
        }
 
-       if (retval == PAM_SUCCESS) {
+       if (PAM_SUCCESS == retval) {
                retval = pam_acct_mgmt (pamh, 0);
-               if (retval != PAM_SUCCESS) {
-                       pam_end (pamh, retval);
-               }
        }
 
-       if (retval != PAM_SUCCESS) {
+       if (NULL != pamh) {
+               (void) pam_end (pamh, retval);
+       }
+       if (PAM_SUCCESS != retval) {
                fprintf (stderr, _("%s: PAM authentication failed\n"), Prog);
                exit (1);
        }
 #endif                         /* USE_PAM */
+#endif                         /* ACCT_TOOLS_SETUID */
+}
 
-#ifdef SHADOWGRP
-       is_shadow_grp = sgr_file_present ();
+/*
+ * main - groupadd command
+ */
+int main (int argc, char **argv)
+{
+#ifdef WITH_AUDIT
+       audit_help_open ();
 #endif
+       atexit (do_cleanups);
+
+       /*
+        * Get my name so that I can use it to report errors.
+        */
+       Prog = Basename (argv[0]);
+
+       (void) setlocale (LC_ALL, "");
+       (void) bindtextdomain (PACKAGE, LOCALEDIR);
+       (void) textdomain (PACKAGE);
+
+       OPENLOG ("groupadd");
 
        /*
-        * Start with a quick check to see if the group exists.
+        * Parse the command line options.
         */
-       if (getgrnam (group_name)) { /* local, no need for xgetgrnam */
-               if (fflg) {
-                       exit (E_SUCCESS);
-               }
-               fprintf (stderr, _("%s: group %s exists\n"), Prog, group_name);
-#ifdef WITH_AUDIT
-               audit_logger (AUDIT_USER_CHAUTHTOK, Prog, "adding group",
-                             group_name, -1, 0);
+       process_flags (argc, argv);
+
+       check_perms ();
+
+#ifdef SHADOWGRP
+       is_shadow_grp = sgr_file_present ();
 #endif
-               exit (E_NAME_IN_USE);
-       }
 
        /*
         * Do the hard stuff - open the files, create the group entries,
@@ -531,18 +596,18 @@ int main (int argc, char **argv)
         */
        open_files ();
 
-       if (!gflg || !oflg)
-               find_new_gid ();
+       if (!gflg) {
+               if (find_new_gid (rflg, &group_id, NULL) < 0) {
+                       exit (E_GID_IN_USE);
+               }
+       }
 
        grp_update ();
        close_files ();
 
        nscd_flush_cache ("group");
 
-#ifdef USE_PAM
-       if (retval == PAM_SUCCESS)
-               pam_end (pamh, PAM_SUCCESS);
-#endif                         /* USE_PAM */
        exit (E_SUCCESS);
-       /* NOT REACHED */
+       /*@notreached@*/
 }
+