]> granicus.if.org Git - icinga2/blobdiff - plugins/check_update.cpp
Merge pull request #7113 from Elias481/fix/incorrect-usage-of-global-namespace-6874...
[icinga2] / plugins / check_update.cpp
index 965f5bb83cce8b771570ceeaa56a359d261deb81..161b2d6926f6f44047313812dc40c259d94b4781 100644 (file)
@@ -1,54 +1,32 @@
-/******************************************************************************
- * Icinga 2                                                                   *
- * Copyright (C) 2012-2018 Icinga Development Team (https://www.icinga.com/)  *
- *                                                                            *
- * This program is free software; you can redistribute it and/or              *
- * modify it under the terms of the GNU General Public License                *
- * as published by the Free Software Foundation; either version 2             *
- * of the License, or (at your option) any later version.                     *
- *                                                                            *
- * This program is distributed in the hope that it will be useful,            *
- * but WITHOUT ANY WARRANTY; without even the implied warranty of             *
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the              *
- * GNU General Public License for more details.                               *
- *                                                                            *
- * You should have received a copy of the GNU General Public License          *
- * along with this program; if not, write to the Free Software Foundation     *
- * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.             *
- ******************************************************************************/
-#include <windows.h>
-#include <Shlwapi.h>
+/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */
+
+#include "plugins/thresholds.hpp"
+#include <boost/program_options.hpp>
 #include <iostream>
+#include <windows.h>
+#include <shlwapi.h>
 #include <wuapi.h>
 #include <wuerror.h>
 
-#include "check_update.h"
-
 #define VERSION 1.0
 
 #define CRITERIA L"(IsInstalled = 0 and CategoryIDs contains '0fa1201d-4330-4fa8-8ae9-b877473b6441') or (IsInstalled = 0 and CategoryIDs contains 'E6CF1350-C01B-414D-A61F-263D14D133B4')"
 
 namespace po = boost::program_options;
 
-static BOOL debug = FALSE;
-
-INT wmain(INT argc, WCHAR **argv)
+struct printInfoStruct
 {
-       printInfoStruct printInfo = { FALSE, FALSE, 0, FALSE, FALSE, FALSE };
-       po::variables_map vm;
+       int warn{0};
+       int crit{0};
+       LONG numUpdates{0};
+       bool ignoreReboot{false};
+       int reboot{0};
+       bool careForCanRequest{false};
+};
 
-       INT ret = parseArguments(argc, argv, vm, printInfo);
-       if (ret != -1)
-               return ret;
+static bool l_Debug;
 
-       ret = check_update(printInfo);
-       if (ret != -1)
-               return ret;
-
-       return printOutput(printInfo);
-}
-
-INT parseArguments(INT ac, WCHAR **av, po::variables_map& vm, printInfoStruct& printInfo)
+static int parseArguments(int ac, WCHAR **av, po::variables_map& vm, printInfoStruct& printInfo)
 {
        WCHAR namePath[MAX_PATH];
        GetModuleFileName(NULL, namePath, MAX_PATH);
@@ -60,24 +38,25 @@ INT parseArguments(INT ac, WCHAR **av, po::variables_map& vm, printInfoStruct& p
                ("help,h", "Print help message and exit")
                ("version,V", "Print version and exit")
                ("debug,d", "Verbose/Debug output")
-               ("warning,w", "Warn if there are important updates available")
-               ("critical,c", "Critical if there are important updates that require a reboot")
+               ("warning,w", po::value<int>(), "Number of updates to trigger a warning.")
+               ("critical,c", po::value<int>(), "Number of updates to trigger a critical.")
                ("possible-reboot", "Treat \"update may need reboot\" as \"update needs reboot\"")
+               ("no-reboot-critical", "Do not automatically return critical if an update requiring reboot is present.")
                ;
 
-       po::basic_command_line_parser<WCHAR> parser(ac, av);
+       po::wcommand_line_parser parser(ac, av);
 
        try {
                po::store(
                        parser
                        .options(desc)
                        .style(
-                       po::command_line_style::unix_style |
-                       po::command_line_style::allow_long_disguise)
+                               po::command_line_style::unix_style |
+                               po::command_line_style::allow_long_disguise)
                        .run(),
                        vm);
                vm.notify();
-       } catch (std::exception& e) {
+       } catch (const std::exception& e) {
                std::cout << e.what() << '\n' << desc << '\n';
                return 3;
        }
@@ -92,23 +71,20 @@ INT parseArguments(INT ac, WCHAR **av, po::variables_map& vm, printInfoStruct& p
                        L"\nAfter some time, it will then output a string like this one:\n\n"
                        L"\tUPDATE WARNING 8 | updates=8;1;1;0\n\n"
                        L"\"UPDATE\" being the type of the check, \"WARNING\" the returned status\n"
-                       L"and \"8\" is the number of important updates updates.\n"
+                       L"and \"8\" is the number of important updates.\n"
                        L"The performance data is found behind the \"|\", in order:\n"
                        L"returned value, warning threshold, critical threshold, minimal value and,\n"
-                       L"if applicable, the maximal value. Performance data will only be displayed when\n"
-                       L"you set at least one threshold\n\n"
+                       L"if applicable, the maximal value.\n\n"
                        L"An update counts as important when it is part of the Security- or\n"
                        L"CriticalUpdates group.\n"
                        L"Consult the msdn on WSUS Classification GUIDs for more information.\n"
                        L"%s' exit codes denote the following:\n"
                        L" 0\tOK,\n\tNo Thresholds were broken or the programs check part was not executed\n"
                        L" 1\tWARNING,\n\tThe warning, but not the critical threshold was broken\n"
-                       L" 2\tCRITICAL,\n\tThe critical threshold was broken\n"
+                       L" 2\tCRITICAL,\n\tThe critical threshold was broken or an update required reboot.\n"
                        L" 3\tUNKNOWN, \n\tThe program experienced an internal or input error\n\n"
-                       L"%s works different from other plugins in that you do not set thresholds\n"
-                       L"but only activate them. Using \"-w\" triggers warning state if there are not\n"
-                       L"installed and non-optional updates. \"-c\" triggers critical if there are\n"
-                       L"non-optional updates that require a reboot.\n"
+                       L"If a warning threshold is set but not a critical threshold, the critical\n"
+                       L"threshold will be set to one greater than the set warning threshold.\n\n"
                        L"The \"possible-reboot\" option is not recommended since this true for nearly\n"
                        L"every update."
                        , progName, progName);
@@ -118,34 +94,32 @@ INT parseArguments(INT ac, WCHAR **av, po::variables_map& vm, printInfoStruct& p
                std::cout << "Version: " << VERSION << '\n';
                return 0;
        }
-
-       if (vm.count("warning"))
-               printInfo.warn = TRUE;
-
+       if(vm.count("warning"))
+               printInfo.warn = vm["warning"].as<int>();
        if (vm.count("critical"))
-               printInfo.crit = TRUE;
+               printInfo.crit = vm["critical"].as<int>();
+       else if (vm.count("warning"))
+               printInfo.crit = printInfo.warn + 1;
+       printInfo.careForCanRequest = vm.count("possible-reboot") > 0;
+       printInfo.ignoreReboot = vm.count("no-reboot-critical") > 0;
 
-       if (vm.count("possible-reboot"))
-               printInfo.careForCanRequest = TRUE;
-
-       if (vm.count("debug"))
-               debug = TRUE;
+       l_Debug = vm.count("debug") > 0;
 
        return -1;
 }
 
-INT printOutput(const printInfoStruct& printInfo)
+static int printOutput(const printInfoStruct& printInfo)
 {
-       if (debug)
+       if (l_Debug)
                std::wcout << L"Constructing output string" << '\n';
 
        state state = OK;
        std::wstring output = L"UPDATE ";
 
-       if (printInfo.important)
+       if (printInfo.numUpdates >= printInfo.warn && printInfo.warn)
                state = WARNING;
 
-       if (printInfo.reboot)
+       if ((printInfo.reboot && !printInfo.ignoreReboot) || (printInfo.numUpdates >= printInfo.crit && printInfo.crit))
                state = CRITICAL;
 
        switch (state) {
@@ -159,16 +133,21 @@ INT printOutput(const printInfoStruct& printInfo)
                output.append(L"CRITICAL ");
                break;
        }
-
-       std::wcout << output << printInfo.numUpdates << L" | update=" << printInfo.numUpdates << L";"
+       output.append(std::to_wstring(printInfo.numUpdates));
+       if (printInfo.reboot) {
+               output.append(L"; ");
+               output.append(std::to_wstring(printInfo.reboot));
+               output.append(L" NEED REBOOT ");
+       }
+       std::wcout << output << L" | 'update'=" << printInfo.numUpdates << L";"
                << printInfo.warn << L";" << printInfo.crit << L";0;" << '\n';
 
        return state;
 }
 
-INT check_update(printInfoStruct& printInfo)
+static int check_update(printInfoStruct& printInfo)
 {
-       if (debug)
+       if (l_Debug)
                std::wcout << "Initializing COM library" << '\n';
        CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);
        ISearchResult *pResult;
@@ -177,24 +156,24 @@ INT check_update(printInfoStruct& printInfo)
        BSTR criteria = NULL;
 
        HRESULT err;
-       if (debug)
+       if (l_Debug)
                std::wcout << "Creating UpdateSession and UpdateSearcher" << '\n';
-       CoCreateInstance(CLSID_UpdateSession, NULL, CLSCTX_INPROC_SERVER, IID_IUpdateSession, (LPVOID*)&pSession);
+       CoCreateInstance(CLSID_UpdateSession, NULL, CLSCTX_INPROC_SERVER, IID_IUpdateSession, (void **)&pSession);
        pSession->CreateUpdateSearcher(&pSearcher);
 
        /*
-        * IsInstalled = 0: All updates, including languagepacks and features
-        * BrowseOnly = 0: No features or languagepacks, security and unnamed
-        * BrowseOnly = 1: Nothing, broken
-        * RebootRequired = 1: Reboot required
-        */
+       * IsInstalled = 0: All updates, including languagepacks and features
+       * BrowseOnly = 0: No features or languagepacks, security and unnamed
+       * BrowseOnly = 1: Nothing, broken
+       * RebootRequired = 1: Reboot required
+       */
 
        criteria = SysAllocString(CRITERIA);
        // https://msdn.microsoft.com/en-us/library/windows/desktop/aa386526%28v=vs.85%29.aspx
        // https://msdn.microsoft.com/en-us/library/ff357803%28v=vs.85%29.aspx
 
-       if (debug)
-               std::wcout << L"Querrying updates from server" << '\n';
+       if (l_Debug)
+               std::wcout << L"Querying updates from server" << '\n';
 
        err = pSearcher->Search(criteria, &pResult);
        if (!SUCCEEDED(err))
@@ -212,31 +191,32 @@ INT check_update(printInfoStruct& printInfo)
                return -1;
 
        printInfo.numUpdates = updateSize;
-//     printInfo.important = printInfo.warn;
+       //      printInfo.important = printInfo.warn;
 
        IInstallationBehavior *pIbehav;
        InstallationRebootBehavior updateReboot;
 
        for (LONG i = 0; i < updateSize; i++) {
                pCollection->get_Item(i, &pUpdate);
-               if (debug) {
+               if (l_Debug) {
                        std::wcout << L"Checking reboot behaviour of update number " << i << '\n';
                }
                pUpdate->get_InstallationBehavior(&pIbehav);
                pIbehav->get_RebootBehavior(&updateReboot);
                if (updateReboot == irbAlwaysRequiresReboot) {
-                       printInfo.reboot = TRUE;
-                       if (debug)
+                       printInfo.reboot++;
+                       if (l_Debug)
                                std::wcout << L"It requires reboot" << '\n';
                        continue;
                }
-               if (printInfo.careForCanRequest && updateReboot == irbCanRequestReboot)
-                       if (debug)
+               if (printInfo.careForCanRequest && updateReboot == irbCanRequestReboot) {
+                       if (l_Debug)
                                std::wcout << L"It requires reboot" << '\n';
-                       printInfo.reboot = TRUE;
+                       printInfo.reboot++;
+               }
        }
 
-       if (debug)
+       if (l_Debug)
                std::wcout << L"Cleaning up and returning" << '\n';
 
        SysFreeString(criteria);
@@ -244,9 +224,25 @@ INT check_update(printInfoStruct& printInfo)
        return -1;
 
 die:
-       die(err);
+       printErrorInfo(err);
        CoUninitialize();
        if (criteria)
                SysFreeString(criteria);
        return 3;
 }
+
+int wmain(int argc, WCHAR **argv)
+{
+       printInfoStruct printInfo;
+       po::variables_map vm;
+
+       int ret = parseArguments(argc, argv, vm, printInfo);
+       if (ret != -1)
+               return ret;
+
+       ret = check_update(printInfo);
+       if (ret != -1)
+               return ret;
+
+       return printOutput(printInfo);
+}