Service: be handled while host is down

[icinga2] / lib / icinga / servicegroup.cpp

diff --git a/lib/icinga/servicegroup.cpp b/lib/icinga/servicegroup.cpp
index 8e4a393045bb24761a95c2d1f23f873a2cd5259b..45d953f63febba5e1d12f941c93479d57b41cf2b 100644 (file)
--- a/lib/icinga/servicegroup.cpp
+++ b/lib/icinga/servicegroup.cpp
@@ -1,24 +1,7 @@
-/******************************************************************************
- * Icinga 2                                                                   *
- * Copyright (C) 2012-2015 Icinga Development Team (http://www.icinga.org)    *
- *                                                                            *
- * This program is free software; you can redistribute it and/or              *
- * modify it under the terms of the GNU General Public License                *
- * as published by the Free Software Foundation; either version 2             *
- * of the License, or (at your option) any later version.                     *
- *                                                                            *
- * This program is distributed in the hope that it will be useful,            *
- * but WITHOUT ANY WARRANTY; without even the implied warranty of             *
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the              *
- * GNU General Public License for more details.                               *
- *                                                                            *
- * You should have received a copy of the GNU General Public License          *
- * along with this program; if not, write to the Free Software Foundation     *
- * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.             *
- ******************************************************************************/
+/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */
 
 #include "icinga/servicegroup.hpp"
-#include "icinga/servicegroup.tcpp"
+#include "icinga/servicegroup-ti.cpp"
 #include "config/objectrule.hpp"
 #include "config/configitem.hpp"
 #include "base/configtype.hpp"
@@ -26,28 +9,24 @@
 #include "base/logger.hpp"
 #include "base/context.hpp"
 #include "base/workqueue.hpp"
-#include <boost/foreach.hpp>
 
 using namespace icinga;
 
 REGISTER_TYPE(ServiceGroup);
 
-INITIALIZE_ONCE(&ServiceGroup::RegisterObjectRuleHandler);
-
-void ServiceGroup::RegisterObjectRuleHandler(void)
-{
+INITIALIZE_ONCE([]() {
        ObjectRule::RegisterType("ServiceGroup");
-}
+});
 
 bool ServiceGroup::EvaluateObjectRule(const Service::Ptr& service, const ConfigItem::Ptr& group)
 {
-       String group_name = group->GetName();
+       String groupName = group->GetName();
 
-       CONTEXT("Evaluating rule for group '" + group_name + "'");
+       CONTEXT("Evaluating rule for group '" + groupName + "'");
 
        Host::Ptr host = service->GetHost();
 
-       ScriptFrame frame;
+       ScriptFrame frame(true);
        if (group->GetScope())
                group->GetScope()->CopyTo(frame.Locals);
        frame.Locals->Set("host", host);
@@ -57,10 +36,12 @@ bool ServiceGroup::EvaluateObjectRule(const Service::Ptr& service, const ConfigI
                return false;
 
        Log(LogDebug, "ServiceGroup")
-           << "Assigning membership for group '" << group_name << "' to service '" << service->GetName() << "'";
+               << "Assigning membership for group '" << groupName << "' to service '" << service->GetName() << "'";
 
        Array::Ptr groups = service->GetGroups();
-       groups->Add(group_name);
+
+       if (groups && !groups->Contains(groupName))
+               groups->Add(groupName);
 
        return true;
 }
@@ -69,7 +50,7 @@ void ServiceGroup::EvaluateObjectRules(const Service::Ptr& service)
 {
        CONTEXT("Evaluating group membership for service '" + service->GetName() + "'");
 
-       BOOST_FOREACH(const ConfigItem::Ptr& group, ConfigItem::GetItems("ServiceGroup"))
+       for (const ConfigItem::Ptr& group : ConfigItem::GetItems(ServiceGroup::TypeInstance))
        {
                if (!group->GetFilter())
                        continue;
@@ -78,7 +59,7 @@ void ServiceGroup::EvaluateObjectRules(const Service::Ptr& service)
        }
 }
 
-std::set<Service::Ptr> ServiceGroup::GetMembers(void) const
+std::set<Service::Ptr> ServiceGroup::GetMembers() const
 {
        boost::mutex::scoped_lock lock(m_ServiceGroupMutex);
        return m_Members;
@@ -102,8 +83,8 @@ bool ServiceGroup::ResolveGroupMembership(const Service::Ptr& service, bool add,
 
        if (add && rstack > 20) {
                Log(LogWarning, "ServiceGroup")
-                   << "Too many nested groups for group '" << GetName() << "': Service '"
-                   << service->GetName() << "' membership assignment failed.";
+                       << "Too many nested groups for group '" << GetName() << "': Service '"
+                       << service->GetName() << "' membership assignment failed.";
 
                return false;
        }
@@ -113,7 +94,7 @@ bool ServiceGroup::ResolveGroupMembership(const Service::Ptr& service, bool add,
        if (groups && groups->GetLength() > 0) {
                ObjectLock olock(groups);
 
-               BOOST_FOREACH(const String& name, groups) {
+               for (const String& name : groups) {
                        ServiceGroup::Ptr group = ServiceGroup::GetByName(name);
 
                        if (group && !group->ResolveGroupMembership(service, add, rstack + 1))