Use std::vector::emplace_back instead of std::vector::push_back

[icinga2] / lib / db_ido / hostdbobject.cpp

diff --git a/lib/db_ido/hostdbobject.cpp b/lib/db_ido/hostdbobject.cpp
index aa1a32a08545cd5ac7773f49a36f7dfd32de6700..eb5ae574110a8d689ee431158728786b650149d3 100644 (file)
--- a/lib/db_ido/hostdbobject.cpp
+++ b/lib/db_ido/hostdbobject.cpp
@@ -191,8 +191,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
        query1.Category = DbCatConfig;
        query1.WhereCriteria = new Dictionary();
        query1.WhereCriteria->Set("host_object_id", host);
-
-       queries.push_back(query1);
+       queries.emplace_back(std::move(query1));
 
        if (groups) {
                ObjectLock olock(groups);
@@ -211,8 +210,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
                        query2.WhereCriteria->Set("instance_id", 0); /* DbConnection class fills in real ID */
                        query2.WhereCriteria->Set("hostgroup_id", DbValue::FromObjectInsertID(group));
                        query2.WhereCriteria->Set("host_object_id", host);
-
-                       queries.push_back(query2);
+                       queries.emplace_back(std::move(query2));
                }
        }
 
@@ -226,8 +224,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
        query2.Category = DbCatConfig;
        query2.WhereCriteria = new Dictionary();
        query2.WhereCriteria->Set(GetType()->GetTable() + "_id", DbValue::FromObjectInsertID(GetObject()));
-
-       queries.push_back(query2);
+       queries.emplace_back(std::move(query2));
 
        /* parents */
        for (const Checkable::Ptr& checkable : host->GetParents()) {
@@ -250,8 +247,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
                query1.Type = DbQueryInsert;
                query1.Category = DbCatConfig;
                query1.Fields = fields1;
-
-               queries.push_back(query1);
+               queries.emplace_back(std::move(query1));
        }
 
        DbObject::OnMultipleQueries(queries);
@@ -268,8 +264,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
        query3.Category = DbCatConfig;
        query3.WhereCriteria = new Dictionary();
        query3.WhereCriteria->Set("dependent_host_object_id", host);
-
-       queries.push_back(query3);
+       queries.emplace_back(std::move(query3));
 
        for (const Dependency::Ptr& dep : host->GetDependencies()) {
                Checkable::Ptr parent = dep->GetParent();
@@ -299,8 +294,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
                query2.Type = DbQueryInsert;
                query2.Category = DbCatConfig;
                query2.Fields = fields2;
-
-               queries.push_back(query2);
+               queries.emplace_back(std::move(query2));
        }
 
        DbObject::OnMultipleQueries(queries);
@@ -316,8 +310,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
        query4.Category = DbCatConfig;
        query4.WhereCriteria = new Dictionary();
        query4.WhereCriteria->Set("host_id", DbValue::FromObjectInsertID(host));
-
-       queries.push_back(query4);
+       queries.emplace_back(std::move(query4));
 
        for (const User::Ptr& user : CompatUtility::GetCheckableNotificationUsers(host)) {
                Log(LogDebug, "HostDbObject")
@@ -333,8 +326,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
                query_contact.Type = DbQueryInsert;
                query_contact.Category = DbCatConfig;
                query_contact.Fields = fields_contact;
-
-               queries.push_back(query_contact);
+               queries.emplace_back(std::move(query_contact));
        }
 
        DbObject::OnMultipleQueries(queries);
@@ -350,8 +342,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
        query5.Category = DbCatConfig;
        query5.WhereCriteria = new Dictionary();
        query5.WhereCriteria->Set("host_id", DbValue::FromObjectInsertID(host));
-
-       queries.push_back(query5);
+       queries.emplace_back(std::move(query5));
 
        for (const UserGroup::Ptr& usergroup : CompatUtility::GetCheckableNotificationUserGroups(host)) {
                Log(LogDebug, "HostDbObject")
@@ -367,8 +358,7 @@ void HostDbObject::OnConfigUpdateHeavy(void)
                query_contact.Type = DbQueryInsert;
                query_contact.Category = DbCatConfig;
                query_contact.Fields = fields_contact;
-
-               queries.push_back(query_contact);
+               queries.emplace_back(std::move(query_contact));
        }
 
        DbObject::OnMultipleQueries(queries);