if (syserror(tcp))
printaddr(tcp->u_arg[1]);
else
- printstr(tcp, tcp->u_arg[1], tcp->u_rval);
- tprintf(", %lu", tcp->u_arg[2]);
+ printstrn(tcp, tcp->u_arg[1], tcp->u_rval);
+ tprintf(", %" PRI_klu, tcp->u_arg[2]);
}
return 0;
}
{
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
- printstr(tcp, tcp->u_arg[1], tcp->u_arg[2]);
- tprintf(", %lu", tcp->u_arg[2]);
+ printstrn(tcp, tcp->u_arg[1], tcp->u_arg[2]);
+ tprintf(", %" PRI_klu, tcp->u_arg[2]);
return RVAL_DECODED;
}
struct print_iovec_config {
enum iov_decode decode_iov;
- unsigned long data_size;
+ kernel_ulong_t data_size;
};
static bool
print_iovec(struct tcb *tcp, void *elem_buf, size_t elem_size, void *data)
{
- const unsigned long *iov;
- unsigned long iov_buf[2], len;
+ const kernel_ulong_t *iov;
+ kernel_ulong_t iov_buf[2], len;
struct print_iovec_config *c = data;
if (elem_size < sizeof(iov_buf)) {
case IOV_DECODE_STR:
if (len > c->data_size)
len = c->data_size;
- c->data_size -= len;
- printstr(tcp, iov[0], len);
+ if (c->data_size != (kernel_ulong_t) -1)
+ c->data_size -= len;
+ printstrn(tcp, iov[0], len);
break;
case IOV_DECODE_NETLINK:
if (len > c->data_size)
len = c->data_size;
- c->data_size -= len;
+ if (c->data_size != (kernel_ulong_t) -1)
+ c->data_size -= len;
decode_netlink(tcp, iov[0], iov[1]);
break;
default:
break;
}
- tprintf(", iov_len=%lu}", iov[1]);
+ tprintf(", iov_len=%" PRI_klu "}", iov[1]);
return true;
}
* Example: recvmsg returing a short read.
*/
void
-tprint_iov_upto(struct tcb *tcp, unsigned long len, unsigned long addr,
- enum iov_decode decode_iov, unsigned long data_size)
+tprint_iov_upto(struct tcb *const tcp, const kernel_ulong_t len,
+ const kernel_ulong_t addr, const enum iov_decode decode_iov,
+ const kernel_ulong_t data_size)
{
- unsigned long iov[2];
+ kernel_ulong_t iov[2];
struct print_iovec_config config =
{ .decode_iov = decode_iov, .data_size = data_size };
print_array(tcp, addr, len, iov, current_wordsize * 2,
- umoven_or_printaddr, print_iovec, &config);
-}
-
-void
-tprint_iov(struct tcb *tcp, unsigned long len, unsigned long addr,
- enum iov_decode decode_iov)
-{
- tprint_iov_upto(tcp, len, addr, decode_iov, (unsigned long) -1L);
+ umoven_or_printaddr_ignore_syserror, print_iovec, &config);
}
SYS_FUNC(readv)
tprints(", ");
} else {
tprint_iov_upto(tcp, tcp->u_arg[2], tcp->u_arg[1],
+ syserror(tcp) ? IOV_DECODE_ADDR :
IOV_DECODE_STR, tcp->u_rval);
- tprintf(", %lu", tcp->u_arg[2]);
+ tprintf(", %" PRI_klu, tcp->u_arg[2]);
}
return 0;
}
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
tprint_iov(tcp, tcp->u_arg[2], tcp->u_arg[1], IOV_DECODE_STR);
- tprintf(", %lu", tcp->u_arg[2]);
+ tprintf(", %" PRI_klu, tcp->u_arg[2]);
return RVAL_DECODED;
}
-/* The SH4 ABI does allow long longs in odd-numbered registers, but
- does not allow them to be split between registers and memory - and
- there are only four argument registers for normal functions. As a
- result pread takes an extra padding argument before the offset. This
- was changed late in the 2.4 series (around 2.4.20). */
-#if defined(SH)
-#define PREAD_OFFSET_ARG 4
-#else
-#define PREAD_OFFSET_ARG 3
-#endif
-
SYS_FUNC(pread)
{
if (entering(tcp)) {
if (syserror(tcp))
printaddr(tcp->u_arg[1]);
else
- printstr(tcp, tcp->u_arg[1], tcp->u_rval);
- tprintf(", %lu, ", tcp->u_arg[2]);
- printllval(tcp, "%lld", PREAD_OFFSET_ARG);
+ printstrn(tcp, tcp->u_arg[1], tcp->u_rval);
+ tprintf(", %" PRI_klu ", ", tcp->u_arg[2]);
+ printllval(tcp, "%lld", 3);
}
return 0;
}
{
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
- printstr(tcp, tcp->u_arg[1], tcp->u_arg[2]);
- tprintf(", %lu, ", tcp->u_arg[2]);
- printllval(tcp, "%lld", PREAD_OFFSET_ARG);
+ printstrn(tcp, tcp->u_arg[1], tcp->u_arg[2]);
+ tprintf(", %" PRI_klu ", ", tcp->u_arg[2]);
+ printllval(tcp, "%lld", 3);
return RVAL_DECODED;
}
static void
print_lld_from_low_high_val(struct tcb *tcp, int arg)
{
-#if SIZEOF_LONG > 4 && SIZEOF_LONG == SIZEOF_LONG_LONG
-# if SUPPORTED_PERSONALITIES > 1
-# ifdef X86_64
- if (current_personality != 1)
-# else
- if (current_wordsize == sizeof(long))
-# endif
-# endif
- tprintf("%ld", tcp->u_arg[arg]);
-# if SUPPORTED_PERSONALITIES > 1
- else
- tprintf("%ld",
- ((unsigned long) tcp->u_arg[arg + 1] << current_wordsize * 8)
- | (unsigned long) tcp->u_arg[arg]);
-# endif
-#elif SIZEOF_LONG > 4
-# error Unsupported configuration: SIZEOF_LONG > 4 && SIZEOF_LONG_LONG > SIZEOF_LONG
-#elif HAVE_STRUCT_TCB_EXT_ARG
-# if SUPPORTED_PERSONALITIES > 1
- if (current_personality == 1) {
- tprintf("%lld",
- (widen_to_ull(tcp->u_arg[arg + 1]) << sizeof(long) * 8)
- | widen_to_ull(tcp->u_arg[arg]));
+#if SIZEOF_KERNEL_LONG_T > 4
+# ifndef current_klongsize
+ if (current_klongsize < SIZEOF_KERNEL_LONG_T) {
+ tprintf("%" PRI_kld, (tcp->u_arg[arg + 1] << 32)
+ | tcp->u_arg[arg]);
} else
-# endif
+# endif /* !current_klongsize */
{
- tprintf("%lld", tcp->ext_arg[arg]);
+ tprintf("%" PRI_kld, tcp->u_arg[arg]);
}
-#else /* SIZEOF_LONG_LONG > SIZEOF_LONG && !HAVE_STRUCT_TCB_EXT_ARG */
+#else /* SIZEOF_KERNEL_LONG_T == 4 */
tprintf("%lld",
- (widen_to_ull(tcp->u_arg[arg + 1]) << sizeof(long) * 8)
- | widen_to_ull(tcp->u_arg[arg]));
+ ((long long) tcp->u_arg[arg + 1] << 32)
+ | ((long long) tcp->u_arg[arg]));
#endif
}
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
} else {
- tprint_iov_upto(tcp, tcp->u_arg[2], tcp->u_arg[1], IOV_DECODE_STR,
- tcp->u_rval);
- tprintf(", %lu, ", tcp->u_arg[2]);
+ unsigned long len = widen_to_ulong(tcp->u_arg[2]);
+
+ tprint_iov_upto(tcp, len, tcp->u_arg[1],
+ syserror(tcp) ? IOV_DECODE_ADDR :
+ IOV_DECODE_STR, tcp->u_rval);
+ tprintf(", %lu, ", len);
print_lld_from_low_high_val(tcp, 3);
if (flags_arg >= 0) {
tprints(", ");
static int
do_pwritev(struct tcb *tcp, const int flags_arg)
{
+ unsigned long len = widen_to_ulong(tcp->u_arg[2]);
+
printfd(tcp, tcp->u_arg[0]);
tprints(", ");
- tprint_iov(tcp, tcp->u_arg[2], tcp->u_arg[1], IOV_DECODE_STR);
- tprintf(", %lu, ", tcp->u_arg[2]);
+ tprint_iov(tcp, len, tcp->u_arg[1], IOV_DECODE_STR);
+ tprintf(", %lu, ", len);
print_lld_from_low_high_val(tcp, 3);
if (flags_arg >= 0) {
tprints(", ");
printfd(tcp, tcp->u_arg[1]);
tprints(", ");
/* size_t len */
- tprintf("%lu, ", tcp->u_arg[2]);
+ tprintf("%" PRI_klu ", ", tcp->u_arg[2]);
/* unsigned int flags */
printflags(splice_flags, tcp->u_arg[3], "SPLICE_F_???");
printnum_int64(tcp, tcp->u_arg[3], "%" PRId64);
tprints(", ");
/* size_t len */
- tprintf("%lu, ", tcp->u_arg[4]);
+ tprintf("%" PRI_klu ", ", tcp->u_arg[4]);
/* unsigned int flags */
printflags(splice_flags, tcp->u_arg[5], "SPLICE_F_???");
tprints(", ");
/* const struct iovec *iov, unsigned long nr_segs */
tprint_iov(tcp, tcp->u_arg[2], tcp->u_arg[1], IOV_DECODE_STR);
- tprintf(", %lu, ", tcp->u_arg[2]);
+ tprintf(", %" PRI_klu ", ", tcp->u_arg[2]);
/* unsigned int flags */
printflags(splice_flags, tcp->u_arg[3], "SPLICE_F_???");