travis: add build environment information to the travis log

[strace] / desc.c

diff --git a/desc.c b/desc.c
index 662af305904689bb236aaa573e28b563c5af0f7a..52e58c86e95610952d3bdc554078e30e8b9ebadf 100644 (file)
--- a/desc.c
+++ b/desc.c
@@ -3,6 +3,7 @@
  * Copyright (c) 1993 Branko Lankester <branko@hacktic.nl>
  * Copyright (c) 1993, 1994, 1995, 1996 Rick Sladkey <jrs@world.std.com>
  * Copyright (c) 1996-1999 Wichert Akkerman <wichert@cistron.nl>
+ * Copyright (c) 1999-2017 The strace developers.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -68,25 +69,18 @@ SYS_FUNC(dup3)
        return do_dup2(tcp, 2);
 }
 
-#if defined(ALPHA)
-SYS_FUNC(getdtablesize)
-{
-       return 0;
-}
-#endif
-
 static int
-decode_select(struct tcb *tcp, long *args,
-             void (*print_tv_ts) (struct tcb *, const long),
-             const char * (*sprint_tv_ts) (struct tcb *, const long))
+decode_select(struct tcb *const tcp, const kernel_ulong_t *const args,
+             void (*const print_tv_ts) (struct tcb *, kernel_ulong_t),
+             const char * (*const sprint_tv_ts) (struct tcb *, kernel_ulong_t))
 {
        int i, j;
        int nfds, fdsize;
        fd_set *fds = NULL;
        const char *sep;
-       long arg;
+       kernel_ulong_t addr;
 
-       /* Kernel truncates arg[0] to int, we do the same. */
+       /* Kernel truncates args[0] to int, we do the same. */
        nfds = (int) args[0];
 
        /* Kernel rejects negative nfds, so we don't parse it either. */
@@ -109,13 +103,13 @@ decode_select(struct tcb *tcp, long *args,
                if (verbose(tcp) && fdsize > 0)
                        fds = malloc(fdsize);
                for (i = 0; i < 3; i++) {
-                       arg = args[i+1];
+                       addr = args[i+1];
                        tprints(", ");
                        if (!fds) {
-                               printaddr(arg);
+                               printaddr(addr);
                                continue;
                        }
-                       if (umoven_or_printaddr(tcp, arg, fdsize, fds))
+                       if (umoven_or_printaddr(tcp, addr, fdsize, fds))
                                continue;
                        tprints("[");
                        for (j = 0, sep = "";; j++) {
@@ -153,8 +147,8 @@ decode_select(struct tcb *tcp, long *args,
                for (i = 0; i < 3 && ready_fds > 0; i++) {
                        int first = 1;
 
-                       arg = args[i+1];
-                       if (!arg || !fds || umoven(tcp, arg, fdsize, fds) < 0)
+                       addr = args[i+1];
+                       if (!addr || !fds || umoven(tcp, addr, fdsize, fds) < 0)
                                continue;
                        for (j = 0;; j++) {
                                j = next_set_bit(fds, j, nfds);
@@ -170,8 +164,7 @@ decode_select(struct tcb *tcp, long *args,
                                                );
                                                first = 0;
                                                sep = ", ";
-                                       }
-                                       else {
+                                       } else {
                                                outptr += sprintf(outptr, " %u", j);
                                        }
                                }
@@ -199,26 +192,26 @@ decode_select(struct tcb *tcp, long *args,
 
 SYS_FUNC(oldselect)
 {
-       long long_args[5];
-#undef oldselect_args
-#if SIZEOF_LONG == 4
-# define oldselect_args long_args
-#else
+       kernel_ulong_t select_args[5];
        unsigned int oldselect_args[5];
-       unsigned int i;
-#endif
 
-       if (umove(tcp, tcp->u_arg[0], &oldselect_args) < 0) {
-               printaddr(tcp->u_arg[0]);
-               return 0;
-       }
-#ifndef oldselect_args
-       for (i = 0; i < 5; i++) {
-               long_args[i] = oldselect_args[i];
+       if (sizeof(*select_args) == sizeof(*oldselect_args)) {
+               if (umove_or_printaddr(tcp, tcp->u_arg[0], &select_args)) {
+                       return 0;
+               }
+       } else {
+               unsigned int i;
+
+               if (umove_or_printaddr(tcp, tcp->u_arg[0], &oldselect_args)) {
+                       return 0;
+               }
+
+               for (i = 0; i < 5; ++i) {
+                       select_args[i] = oldselect_args[i];
+               }
        }
-#endif
-       return decode_select(tcp, long_args, print_timeval, sprint_timeval);
-#undef oldselect_args
+
+       return decode_select(tcp, select_args, print_timeval, sprint_timeval);
 }
 
 #ifdef ALPHA
@@ -233,20 +226,41 @@ SYS_FUNC(select)
        return decode_select(tcp, tcp->u_arg, print_timeval, sprint_timeval);
 }
 
+static int
+umove_kulong_array_or_printaddr(struct tcb *const tcp, const kernel_ulong_t addr,
+                               kernel_ulong_t *const ptr, const size_t n)
+{
+#ifndef current_klongsize
+       if (current_klongsize < sizeof(*ptr)) {
+               uint32_t ptr32[n];
+               int r = umove_or_printaddr(tcp, addr, &ptr32);
+               if (!r) {
+                       size_t i;
+
+                       for (i = 0; i < n; ++i)
+                               ptr[i] = ptr32[i];
+               }
+               return r;
+       }
+#endif /* !current_klongsize */
+       return umoven_or_printaddr(tcp, addr, n * sizeof(*ptr), ptr);
+}
+
 SYS_FUNC(pselect6)
 {
        int rc = decode_select(tcp, tcp->u_arg, print_timespec, sprint_timespec);
        if (entering(tcp)) {
-               unsigned long data[2];
+               kernel_ulong_t data[2];
 
                tprints(", ");
-               if (!umove_ulong_array_or_printaddr(tcp, tcp->u_arg[5], data,
-                                                   ARRAY_SIZE(data))) {
+               if (!umove_kulong_array_or_printaddr(tcp, tcp->u_arg[5],
+                                                    data, ARRAY_SIZE(data))) {
                        tprints("{");
-                       /* NB: kernel requires data[1] == NSIG / 8 */
+                       /* NB: kernel requires data[1] == NSIG_BYTES */
                        print_sigset_addr_len(tcp, data[0], data[1]);
-                       tprintf(", %lu}", data[1]);
+                       tprintf(", %" PRI_klu "}", data[1]);
                }
        }
+
        return rc;
 }