]> granicus.if.org Git - postgresql/blobdiff - contrib/pgbench/pgbench.c
Enhance pgbench -l option to add timestamp. Patch contributed by Greg
[postgresql] / contrib / pgbench / pgbench.c
index 206b3a66ae286a90e7942e0b312a8fd529e0aef4..2ffd24b25b907d2242e9331a18b8f070724fcd8d 100644 (file)
@@ -1,10 +1,10 @@
 /*
- * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.52 2006/07/31 05:15:14 ishii Exp $
+ * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.64 2007/04/06 09:16:16 ishii Exp $
  *
  * pgbench: a simple benchmark program for PostgreSQL
  * written by Tatsuo Ishii
  *
- * Copyright (c) 2000-2005     Tatsuo Ishii
+ * Copyright (c) 2000-2007     Tatsuo Ishii
  *
  * Permission to use, copy, modify, and distribute this software and
  * its documentation for any purpose and without fee is hereby
@@ -37,8 +37,9 @@
 #include <sys/select.h>
 #endif
 
-/* for getrlimit */
-#include <sys/resource.h>
+#ifdef HAVE_SYS_RESOURCE_H
+#include <sys/resource.h>              /* for getrlimit */
+#endif
 #endif   /* ! WIN32 */
 
 extern char *optarg;
@@ -58,10 +59,10 @@ int                 nclients = 1;           /* default number of simulated clients */
 int                    nxacts = 10;            /* default number of transactions per clients */
 
 /*
- * scaling factor. for example, tps = 10 will make 1000000 tuples of
+ * scaling factor. for example, scale = 10 will make 1000000 tuples of
  * accounts table.
  */
-int                    tps = 1;
+int                    scale = 1;
 
 /*
  * end of configurable parameters
@@ -134,9 +135,9 @@ int                 num_files;                      /* its number */
 
 /* default scenario */
 static char *tpc_b = {
-       "\\set nbranches :tps\n"
-       "\\set ntellers 10 * :tps\n"
-    "\\set naccounts 100000 * :tps\n"
+       "\\set nbranches :scale\n"
+       "\\set ntellers 10 * :scale\n"
+       "\\set naccounts 100000 * :scale\n"
        "\\setrandom aid 1 :naccounts\n"
        "\\setrandom bid 1 :nbranches\n"
        "\\setrandom tid 1 :ntellers\n"
@@ -152,9 +153,9 @@ static char *tpc_b = {
 
 /* -N case */
 static char *simple_update = {
-       "\\set nbranches :tps\n"
-       "\\set ntellers 10 * :tps\n"
-    "\\set naccounts 100000 * :tps\n"
+       "\\set nbranches :scale\n"
+       "\\set ntellers 10 * :scale\n"
+       "\\set naccounts 100000 * :scale\n"
        "\\setrandom aid 1 :naccounts\n"
        "\\setrandom bid 1 :nbranches\n"
        "\\setrandom tid 1 :ntellers\n"
@@ -168,7 +169,7 @@ static char *simple_update = {
 
 /* -S case */
 static char *select_only = {
-    "\\set naccounts 100000 * :tps\n"
+       "\\set naccounts 100000 * :scale\n"
        "\\setrandom aid 1 :naccounts\n"
        "SELECT abalance FROM accounts WHERE aid = :aid;\n"
 };
@@ -187,12 +188,26 @@ getrand(int min, int max)
        return min + (int) (((max - min) * (double) random()) / MAX_RANDOM_VALUE + 0.5);
 }
 
+/* call PQexec() and exit() on failure */
+static void
+executeStatement(PGconn *con, const char* sql)
+{
+       PGresult   *res;
+
+       res = PQexec(con, sql);
+       if (PQresultStatus(res) != PGRES_COMMAND_OK)
+       {
+               fprintf(stderr, "%s", PQerrorMessage(con));
+               exit(1);
+       }
+       PQclear(res);
+}
+
 /* set up a connection to the backend */
 static PGconn *
 doConnect(void)
 {
        PGconn     *con;
-       PGresult   *res;
 
        con = PQsetdbLogin(pghost, pgport, pgoptions, pgtty, dbName,
                                           login, pwd);
@@ -215,13 +230,7 @@ doConnect(void)
                return (NULL);
        }
 
-       res = PQexec(con, "SET search_path = public");
-       if (PQresultStatus(res) != PGRES_COMMAND_OK)
-       {
-               fprintf(stderr, "%s", PQerrorMessage(con));
-               exit(1);
-       }
-       PQclear(res);
+       executeStatement(con, "SET search_path = public");
 
        return (con);
 }
@@ -242,17 +251,23 @@ discard_response(CState * state)
 
 /* check to see if the SQL result was good */
 static int
-check(CState * state, PGresult *res, int n, int good)
+check(CState *state, PGresult *res, int n)
 {
        CState     *st = &state[n];
 
-       if (res && PQresultStatus(res) != good)
+       switch (PQresultStatus(res))
        {
-               fprintf(stderr, "Client %d aborted in state %d: %s", n, st->state, PQerrorMessage(st->con));
-               remains--;                              /* I've aborted */
-               PQfinish(st->con);
-               st->con = NULL;
-               return (-1);
+               case PGRES_COMMAND_OK:
+               case PGRES_TUPLES_OK:
+                       /* OK */
+                       break;
+               default:
+                       fprintf(stderr, "Client %d aborted in state %d: %s",
+                                       n, st->state, PQerrorMessage(st->con));
+                       remains--;                              /* I've aborted */
+                       PQfinish(st->con);
+                       st->con = NULL;
+                       return (-1);
        }
        return (0);                                     /* OK */
 }
@@ -338,10 +353,13 @@ putVariable(CState * st, char *name, char *value)
        }
        else
        {
-               if ((value = strdup(value)) == NULL)
+               char       *val;
+
+               if ((val = strdup(value)) == NULL)
                        return false;
+
                free(var->value);
-               var->value = value;
+               var->value = val;
        }
 
        return true;
@@ -451,21 +469,17 @@ top:
                        diff = (int) (now.tv_sec - st->txn_begin.tv_sec) * 1000000.0 +
                                (int) (now.tv_usec - st->txn_begin.tv_usec);
 
-                       fprintf(LOGFILE, "%d %d %.0f\n", st->id, st->cnt, diff);
+                       fprintf(LOGFILE, "%d %d %.0f %d %ld %ld\n",
+                               st->id, st->cnt, diff, st->use_file, now.tv_sec,now.tv_usec);
                }
 
                if (commands[st->state]->type == SQL_COMMAND)
                {
                        res = PQgetResult(st->con);
-                       if (strncasecmp(commands[st->state]->argv[0], "select", 6) != 0)
-                       {
-                               if (check(state, res, n, PGRES_COMMAND_OK))
-                                       return;
-                       }
-                       else
+                       if (check(state, res, n))
                        {
-                               if (check(state, res, n, PGRES_TUPLES_OK))
-                                       return;
+                               PQclear(res);
+                               return;
                        }
                        PQclear(res);
                        discard_response(st);
@@ -557,7 +571,7 @@ top:
                        fprintf(stderr, "\n");
                }
 
-               if (strcasecmp(argv[0], "setrandom") == 0)
+               if (pg_strcasecmp(argv[0], "setrandom") == 0)
                {
                        char       *var;
                        int                     min,
@@ -620,7 +634,7 @@ top:
 
                        st->listen = 1;
                }
-               else if (strcasecmp(argv[0], "set") == 0)
+               else if (pg_strcasecmp(argv[0], "set") == 0)
                {
                        char       *var;
                        int                     ope1,
@@ -715,18 +729,18 @@ init(void)
        PGconn     *con;
        PGresult   *res;
        static char *DDLs[] = {
-               "drop table branches",
+               "drop table if exists branches",
                "create table branches(bid int not null,bbalance int,filler char(88))",
-               "drop table tellers",
+               "drop table if exists tellers",
                "create table tellers(tid int not null,bid int,tbalance int,filler char(84))",
-               "drop table accounts",
+               "drop table if exists accounts",
                "create table accounts(aid int not null,bid int,abalance int,filler char(84))",
-               "drop table history",
-       "create table history(tid int,bid int,aid int,delta int,mtime timestamp,filler char(22))"};
+               "drop table if exists history",
+               "create table history(tid int,bid int,aid int,delta int,mtime timestamp,filler char(22))"};
        static char *DDLAFTERs[] = {
                "alter table branches add primary key (bid)",
                "alter table tellers add primary key (tid)",
-       "alter table accounts add primary key (aid)"};
+               "alter table accounts add primary key (aid)"};
 
 
        char            sql[256];
@@ -736,77 +750,46 @@ init(void)
        if ((con = doConnect()) == NULL)
                exit(1);
 
-       for (i = 0; i < (sizeof(DDLs) / sizeof(char *)); i++)
-       {
-               res = PQexec(con, DDLs[i]);
-               if (strncmp(DDLs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)
-               {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
-               }
-               PQclear(res);
-       }
+       for (i = 0; i < lengthof(DDLs); i++)
+               executeStatement(con, DDLs[i]);
 
-       res = PQexec(con, "begin");
-       if (PQresultStatus(res) != PGRES_COMMAND_OK)
-       {
-               fprintf(stderr, "%s", PQerrorMessage(con));
-               exit(1);
-       }
-       PQclear(res);
+       executeStatement(con, "begin");
 
-       for (i = 0; i < nbranches * tps; i++)
+       for (i = 0; i < nbranches * scale; i++)
        {
                snprintf(sql, 256, "insert into branches(bid,bbalance) values(%d,0)", i + 1);
-               res = PQexec(con, sql);
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
-               {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
-               }
-               PQclear(res);
+               executeStatement(con, sql);
        }
 
-       for (i = 0; i < ntellers * tps; i++)
+       for (i = 0; i < ntellers * scale; i++)
        {
                snprintf(sql, 256, "insert into tellers(tid,bid,tbalance) values (%d,%d,0)"
                                 ,i + 1, i / ntellers + 1);
-               res = PQexec(con, sql);
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
-               {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
-               }
-               PQclear(res);
+               executeStatement(con, sql);
        }
 
-       res = PQexec(con, "end");
-       if (PQresultStatus(res) != PGRES_COMMAND_OK)
+       executeStatement(con, "commit");
+
+       /*
+        * fill the accounts table with some data
+        */
+       fprintf(stderr, "creating tables...\n");
+
+       executeStatement(con, "begin");
+       executeStatement(con, "truncate accounts");
+
+       res = PQexec(con, "copy accounts from stdin");
+       if (PQresultStatus(res) != PGRES_COPY_IN)
        {
                fprintf(stderr, "%s", PQerrorMessage(con));
                exit(1);
        }
        PQclear(res);
 
-       /*
-        * occupy accounts table with some data
-        */
-       fprintf(stderr, "creating tables...\n");
-       for (i = 0; i < naccounts * tps; i++)
+       for (i = 0; i < naccounts * scale; i++)
        {
                int                     j = i + 1;
 
-               if (j % 10000 == 1)
-               {
-                       res = PQexec(con, "copy accounts from stdin");
-                       if (PQresultStatus(res) != PGRES_COPY_IN)
-                       {
-                               fprintf(stderr, "%s", PQerrorMessage(con));
-                               exit(1);
-                       }
-                       PQclear(res);
-               }
-
                snprintf(sql, 256, "%d\t%d\t%d\t\n", j, i / naccounts + 1, 0);
                if (PQputline(con, sql))
                {
@@ -815,62 +798,32 @@ init(void)
                }
 
                if (j % 10000 == 0)
-               {
-                       /*
-                        * every 10000 tuples, we commit the copy command. this should
-                        * avoid generating too much WAL logs
-                        */
                        fprintf(stderr, "%d tuples done.\n", j);
-                       if (PQputline(con, "\\.\n"))
-                       {
-                               fprintf(stderr, "very last PQputline failed\n");
-                               exit(1);
-                       }
-
-                       if (PQendcopy(con))
-                       {
-                               fprintf(stderr, "PQendcopy failed\n");
-                               exit(1);
-                       }
-
-#ifdef NOT_USED
-
-                       /*
-                        * do a checkpoint to purge the old WAL logs
-                        */
-                       res = PQexec(con, "checkpoint");
-                       if (PQresultStatus(res) != PGRES_COMMAND_OK)
-                       {
-                               fprintf(stderr, "%s", PQerrorMessage(con));
-                               exit(1);
-                       }
-                       PQclear(res);
-#endif   /* NOT_USED */
-               }
        }
-       fprintf(stderr, "set primary key...\n");
-       for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)
+       if (PQputline(con, "\\.\n"))
        {
-               res = PQexec(con, DDLAFTERs[i]);
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
-               {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
-               }
-               PQclear(res);
+               fprintf(stderr, "very last PQputline failed\n");
+               exit(1);
        }
-
-       /* vacuum */
-       fprintf(stderr, "vacuum...");
-       res = PQexec(con, "vacuum analyze");
-       if (PQresultStatus(res) != PGRES_COMMAND_OK)
+       if (PQendcopy(con))
        {
-               fprintf(stderr, "%s", PQerrorMessage(con));
+               fprintf(stderr, "PQendcopy failed\n");
                exit(1);
        }
-       PQclear(res);
-       fprintf(stderr, "done.\n");
+       executeStatement(con, "commit");
 
+       /*
+        * create indexes
+        */
+       fprintf(stderr, "set primary key...\n");
+       for (i = 0; i < lengthof(DDLAFTERs); i++)
+               executeStatement(con, DDLAFTERs[i]);
+
+       /* vacuum */
+       fprintf(stderr, "vacuum...");
+       executeStatement(con, "vacuum analyze");
+
+       fprintf(stderr, "done.\n");
        PQfinish(con);
 }
 
@@ -922,7 +875,7 @@ process_commands(char *buf)
                        tok = strtok(NULL, delim);
                }
 
-               if (strcasecmp(my_commands->argv[0], "setrandom") == 0)
+               if (pg_strcasecmp(my_commands->argv[0], "setrandom") == 0)
                {
                        if (my_commands->argc < 4)
                        {
@@ -934,7 +887,7 @@ process_commands(char *buf)
                                fprintf(stderr, "%s: extra argument \"%s\" ignored\n",
                                                my_commands->argv[0], my_commands->argv[j]);
                }
-               else if (strcasecmp(my_commands->argv[0], "set") == 0)
+               else if (pg_strcasecmp(my_commands->argv[0], "set") == 0)
                {
                        if (my_commands->argc < 3)
                        {
@@ -1006,14 +959,16 @@ process_file(char *filename)
                while (isspace((unsigned char) buf[i]))
                        i++;
 
-               if (strncmp(&buf[i], "\n", 1) != 0 && strncmp(&buf[i], "--", 2) != 0) {
+               if (buf[i] != '\0' && strncmp(&buf[i], "--", 2) != 0)
+               {
                        commands = process_commands(&buf[i]);
                        if (commands == NULL)
                        {
                                fclose(fd);
                                return false;
                        }
-               } else
+               }
+               else
                        continue;
 
                my_commands[lineno] = commands;
@@ -1133,7 +1088,7 @@ printResults(
                s = "Custom query";
 
        printf("transaction type: %s\n", s);
-       printf("scaling factor: %d\n", tps);
+       printf("scaling factor: %d\n", scale);
        printf("number of clients: %d\n", nclients);
        printf("number of transactions per client: %d\n", nxacts);
        printf("number of transactions actually processed: %d/%d\n", normal_xacts, nxacts * nclients);
@@ -1148,7 +1103,7 @@ main(int argc, char **argv)
        int                     c;
        int                     is_init_mode = 0;               /* initialize mode? */
        int                     is_no_vacuum = 0;               /* no vacuum at all before testing? */
-       int                     is_full_vacuum = 0;             /* do full vacuum before testing? */
+       int                     do_vacuum_accounts = 0; /* do vacuum accounts before testing? */
        int                     debug = 0;              /* debug flag */
        int                     ttype = 0;              /* transaction type. 0: TPC-B, 1: SELECT only,
                                                                 * 2: skip update of branches and tellers */
@@ -1167,7 +1122,7 @@ main(int argc, char **argv)
        int                     nsocks;                 /* return from select(2) */
        int                     maxsock;                /* max socket number to be waited */
 
-#if !(defined(__CYGWIN__) || defined(__MINGW32__))
+#ifdef HAVE_GETRLIMIT
        struct rlimit rlim;
 #endif
 
@@ -1175,6 +1130,13 @@ main(int argc, char **argv)
        PGresult   *res;
        char       *env;
 
+       char            val[64];
+
+#ifdef WIN32
+       /* stderr is buffered on Win32. */
+       setvbuf(stderr, NULL, _IONBF, 0);
+#endif
+
        if ((env = getenv("PGHOST")) != NULL && *env != '\0')
                pghost = env;
        if ((env = getenv("PGPORT")) != NULL && *env != '\0')
@@ -1205,7 +1167,7 @@ main(int argc, char **argv)
                                is_no_vacuum++;
                                break;
                        case 'v':
-                               is_full_vacuum++;
+                               do_vacuum_accounts++;
                                break;
                        case 'p':
                                pgport = optarg;
@@ -1226,8 +1188,8 @@ main(int argc, char **argv)
                                        fprintf(stderr, "invalid number of clients: %d\n", nclients);
                                        exit(1);
                                }
-#if !(defined(__CYGWIN__) || defined(__MINGW32__))
-#ifdef RLIMIT_NOFILE                   /* most platform uses RLIMIT_NOFILE */
+#ifdef HAVE_GETRLIMIT
+#ifdef RLIMIT_NOFILE                   /* most platforms use RLIMIT_NOFILE */
                                if (getrlimit(RLIMIT_NOFILE, &rlim) == -1)
 #else                                                  /* but BSD doesn't ... */
                                if (getrlimit(RLIMIT_OFILE, &rlim) == -1)
@@ -1238,20 +1200,20 @@ main(int argc, char **argv)
                                }
                                if (rlim.rlim_cur <= (nclients + 2))
                                {
-                                       fprintf(stderr, "You need at least %d open files resource but you are only allowed to use %ld.\n", nclients + 2, (long) rlim.rlim_cur);
-                                       fprintf(stderr, "Use limit/ulimt to increase the limit before using pgbench.\n");
+                                       fprintf(stderr, "You need at least %d open files but you are only allowed to use %ld.\n", nclients + 2, (long) rlim.rlim_cur);
+                                       fprintf(stderr, "Use limit/ulimit to increase the limit before using pgbench.\n");
                                        exit(1);
                                }
-#endif
+#endif /* HAVE_GETRLIMIT */
                                break;
                        case 'C':
                                is_connect = 1;
                                break;
                        case 's':
-                               tps = atoi(optarg);
-                               if (tps <= 0)
+                               scale = atoi(optarg);
+                               if (scale <= 0)
                                {
-                                       fprintf(stderr, "invalid scaling factor: %d\n", tps);
+                                       fprintf(stderr, "invalid scaling factor: %d\n", scale);
                                        exit(1);
                                }
                                break;
@@ -1323,12 +1285,10 @@ main(int argc, char **argv)
 
        remains = nclients;
 
-       if (getVariable(&state[0], "tps") == NULL)
+       if (getVariable(&state[0], "scale") == NULL)
        {
-               char            val[64];
-
-               snprintf(val, sizeof(val), "%d", tps);
-               if (putVariable(&state[0], "tps", val) == false)
+               snprintf(val, sizeof(val), "%d", scale);
+               if (putVariable(&state[0], "scale", val) == false)
                {
                        fprintf(stderr, "Couldn't allocate memory for variable\n");
                        exit(1);
@@ -1346,6 +1306,8 @@ main(int argc, char **argv)
 
                memset(state + 1, 0, sizeof(*state) * (nclients - 1));
 
+               snprintf(val, sizeof(val), "%d", scale);
+
                for (i = 1; i < nclients; i++)
                {
                        int                     j;
@@ -1358,6 +1320,12 @@ main(int argc, char **argv)
                                        exit(1);
                                }
                        }
+
+                       if (putVariable(&state[i], "scale", val) == false)
+                       {
+                               fprintf(stderr, "Couldn't allocate memory for variable\n");
+                               exit(1);
+                       }
                }
        }
 
@@ -1405,61 +1373,47 @@ main(int argc, char **argv)
                        fprintf(stderr, "%s", PQerrorMessage(con));
                        exit(1);
                }
-               tps = atoi(PQgetvalue(res, 0, 0));
-               if (tps < 0)
-               {
-                       fprintf(stderr, "count(*) from branches invalid (%d)\n", tps);
-                       exit(1);
-               }
-               PQclear(res);
-       }
-
-       if (!is_no_vacuum)
-       {
-               fprintf(stderr, "starting vacuum...");
-               res = PQexec(con, "vacuum branches");
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
+               scale = atoi(PQgetvalue(res, 0, 0));
+               if (scale < 0)
                {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
+                       fprintf(stderr, "count(*) from branches invalid (%d)\n", scale);
                        exit(1);
                }
                PQclear(res);
 
-               res = PQexec(con, "vacuum tellers");
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
+               snprintf(val, sizeof(val), "%d", scale);
+               if (putVariable(&state[0], "scale", val) == false)
                {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
+                       fprintf(stderr, "Couldn't allocate memory for variable\n");
                        exit(1);
                }
-               PQclear(res);
 
-               res = PQexec(con, "delete from history");
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
-               {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
-               }
-               PQclear(res);
-               res = PQexec(con, "vacuum history");
-               if (PQresultStatus(res) != PGRES_COMMAND_OK)
+               if (nclients > 1)
                {
-                       fprintf(stderr, "%s", PQerrorMessage(con));
-                       exit(1);
+                       for (i = 1; i < nclients; i++)
+                       {
+                               if (putVariable(&state[i], "scale", val) == false)
+                               {
+                                       fprintf(stderr, "Couldn't allocate memory for variable\n");
+                                       exit(1);
+                               }
+                       }
                }
-               PQclear(res);
+       }
 
+       if (!is_no_vacuum)
+       {
+               fprintf(stderr, "starting vacuum...");
+               executeStatement(con, "vacuum branches");
+               executeStatement(con, "vacuum tellers");
+               executeStatement(con, "delete from history");
+               executeStatement(con, "vacuum history");
                fprintf(stderr, "end.\n");
 
-               if (is_full_vacuum)
+               if (do_vacuum_accounts)
                {
-                       fprintf(stderr, "starting full vacuum...");
-                       res = PQexec(con, "vacuum analyze accounts");
-                       if (PQresultStatus(res) != PGRES_COMMAND_OK)
-                       {
-                               fprintf(stderr, "%s", PQerrorMessage(con));
-                               exit(1);
-                       }
-                       PQclear(res);
+                       fprintf(stderr, "starting vacuum accounts...");
+                       executeStatement(con, "vacuum analyze accounts");
                        fprintf(stderr, "end.\n");
                }
        }
@@ -1467,7 +1421,7 @@ main(int argc, char **argv)
 
        /* set random seed */
        gettimeofday(&tv1, NULL);
-       srand((unsigned int) tv1.tv_usec);
+       srandom((unsigned int) tv1.tv_usec);
 
        /* get start up time */
        gettimeofday(&tv1, NULL);
@@ -1520,7 +1474,7 @@ main(int argc, char **argv)
                if (state[i].ecnt > prev_ecnt && commands[state[i].state]->type == META_COMMAND)
                {
                        fprintf(stderr, "Client %d aborted in state %d. Execution meta-command failed.\n", i, state[i].state);
-                       remains--;                              /* I've aborted */
+                       remains--;                      /* I've aborted */
                        PQfinish(state[i].con);
                        state[i].con = NULL;
                }
@@ -1600,7 +1554,7 @@ main(int argc, char **argv)
                        if (state[i].ecnt > prev_ecnt && commands[state[i].state]->type == META_COMMAND)
                        {
                                fprintf(stderr, "Client %d aborted in state %d. Execution meta-command failed.\n", i, state[i].state);
-                               remains--;                              /* I've aborted */
+                               remains--;              /* I've aborted */
                                PQfinish(state[i].con);
                                state[i].con = NULL;
                        }