]> granicus.if.org Git - postgresql/blobdiff - contrib/pg_upgrade/pg_upgrade.c
Update copyright for 2014
[postgresql] / contrib / pg_upgrade / pg_upgrade.c
index 489b68003c376a1a310990d70940eec529afd27d..b992cadbc50c1ef904a32df419396a0fe8e4d850 100644 (file)
@@ -3,7 +3,7 @@
  *
  *     main source file
  *
- *     Copyright (c) 2010-2013, PostgreSQL Global Development Group
+ *     Copyright (c) 2010-2014, PostgreSQL Global Development Group
  *     contrib/pg_upgrade/pg_upgrade.c
  */
 
@@ -134,7 +134,7 @@ main(int argc, char **argv)
                disable_old_cluster();
 
        transfer_all_new_tablespaces(&old_cluster.dbarr, &new_cluster.dbarr,
-                                                old_cluster.pgdata, new_cluster.pgdata);
+                                                                old_cluster.pgdata, new_cluster.pgdata);
 
        /*
         * Assuming OIDs are only used in system tables, there is no need to
@@ -193,20 +193,19 @@ setup(char *argv0, bool *live_check)
        if (pid_lock_file_exists(old_cluster.pgdata))
        {
                /*
-                *      If we have a postmaster.pid file, try to start the server.  If
-                *      it starts, the pid file was stale, so stop the server.  If it
-                *      doesn't start, assume the server is running.  If the pid file
-                *      is left over from a server crash, this also allows any committed
-                *      transactions stored in the WAL to be replayed so they are not
-                *      lost, because WAL files are not transfered from old to new
-                *      servers.
-                */             
+                * If we have a postmaster.pid file, try to start the server.  If it
+                * starts, the pid file was stale, so stop the server.  If it doesn't
+                * start, assume the server is running.  If the pid file is left over
+                * from a server crash, this also allows any committed transactions
+                * stored in the WAL to be replayed so they are not lost, because WAL
+                * files are not transfered from old to new servers.
+                */
                if (start_postmaster(&old_cluster, false))
                        stop_postmaster(false);
                else
                {
                        if (!user_opts.check)
-                               pg_log(PG_FATAL, "There seems to be a postmaster servicing the old cluster.\n"
+                               pg_fatal("There seems to be a postmaster servicing the old cluster.\n"
                                           "Please shutdown that postmaster and try again.\n");
                        else
                                *live_check = true;
@@ -219,13 +218,13 @@ setup(char *argv0, bool *live_check)
                if (start_postmaster(&new_cluster, false))
                        stop_postmaster(false);
                else
-                       pg_log(PG_FATAL, "There seems to be a postmaster servicing the new cluster.\n"
-                          "Please shutdown that postmaster and try again.\n");
+                       pg_fatal("There seems to be a postmaster servicing the new cluster.\n"
+                                  "Please shutdown that postmaster and try again.\n");
        }
 
        /* get path to pg_upgrade executable */
        if (find_my_exec(argv0, exec_path) < 0)
-               pg_log(PG_FATAL, "Could not get path name to pg_upgrade: %s\n", getErrorText(errno));
+               pg_fatal("Could not get path name to pg_upgrade: %s\n", getErrorText(errno));
 
        /* Trim off program name and keep just path */
        *last_dir_separator(exec_path) = '\0';
@@ -312,9 +311,9 @@ create_new_objects(void)
        prep_status("Adding support functions to new cluster");
 
        /*
-        *      Technically, we only need to install these support functions in new
-        *      databases that also exist in the old cluster, but for completeness
-        *      we process all new databases.
+        * Technically, we only need to install these support functions in new
+        * databases that also exist in the old cluster, but for completeness we
+        * process all new databases.
         */
        for (dbnum = 0; dbnum < new_cluster.dbarr.ndbs; dbnum++)
        {
@@ -330,21 +329,25 @@ create_new_objects(void)
 
        for (dbnum = 0; dbnum < old_cluster.dbarr.ndbs; dbnum++)
        {
-               char sql_file_name[MAXPGPATH], log_file_name[MAXPGPATH];
-               DbInfo     *old_db = &old_cluster.dbarr.dbs[dbnum];
+               char            sql_file_name[MAXPGPATH],
+                                       log_file_name[MAXPGPATH];
+               DbInfo     *old_db = &old_cluster.dbarr.dbs[dbnum];
 
                pg_log(PG_STATUS, "%s", old_db->db_name);
                snprintf(sql_file_name, sizeof(sql_file_name), DB_DUMP_FILE_MASK, old_db->db_oid);
                snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid);
 
                /*
-                *      pg_dump only produces its output at the end, so there is little
-                *      parallelism if using the pipe.
+                * pg_dump only produces its output at the end, so there is little
+                * parallelism if using the pipe.
                 */
-               parallel_exec_prog(log_file_name, NULL,
-                                 "\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"",
-                                 new_cluster.bindir, cluster_conn_opts(&new_cluster),
-                                 old_db->db_name, sql_file_name);
+               parallel_exec_prog(log_file_name,
+                                                  NULL,
+                                                  "\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"",
+                                                  new_cluster.bindir,
+                                                  cluster_conn_opts(&new_cluster),
+                                                  old_db->db_name,
+                                                  sql_file_name);
        }
 
        /* reap all children */
@@ -375,7 +378,7 @@ copy_subdir_files(char *subdir)
        snprintf(old_path, sizeof(old_path), "%s/%s", old_cluster.pgdata, subdir);
        snprintf(new_path, sizeof(new_path), "%s/%s", new_cluster.pgdata, subdir);
        if (!rmtree(new_path, true))
-               pg_log(PG_FATAL, "could not delete directory \"%s\"\n", new_path);
+               pg_fatal("could not delete directory \"%s\"\n", new_path);
        check_ok();
 
        prep_status("Copying old %s to new server", subdir);
@@ -418,6 +421,7 @@ copy_clog_xlog_xid(void)
                copy_subdir_files("pg_multixact/offsets");
                copy_subdir_files("pg_multixact/members");
                prep_status("Setting next multixact ID and offset for new cluster");
+
                /*
                 * we preserve all files and contents, so we must preserve both "next"
                 * counters here and the oldest multi present on system.
@@ -434,6 +438,7 @@ copy_clog_xlog_xid(void)
        else if (new_cluster.controldata.cat_ver >= MULTIXACT_FORMATCHANGE_CAT_VER)
        {
                prep_status("Setting oldest multixact ID on new cluster");
+
                /*
                 * We don't preserve files in this case, but it's important that the
                 * oldest multi is set to the latest value used by the old system, so
@@ -549,7 +554,6 @@ set_frozenxids(void)
 static void
 cleanup(void)
 {
-
        fclose(log_opts.internal);
 
        /* Remove dump and log files? */
@@ -567,8 +571,9 @@ cleanup(void)
                if (old_cluster.dbarr.dbs)
                        for (dbnum = 0; dbnum < old_cluster.dbarr.ndbs; dbnum++)
                        {
-                               char sql_file_name[MAXPGPATH], log_file_name[MAXPGPATH];
-                               DbInfo     *old_db = &old_cluster.dbarr.dbs[dbnum];
+                               char            sql_file_name[MAXPGPATH],
+                                                       log_file_name[MAXPGPATH];
+                               DbInfo     *old_db = &old_cluster.dbarr.dbs[dbnum];
 
                                snprintf(sql_file_name, sizeof(sql_file_name), DB_DUMP_FILE_MASK, old_db->db_oid);
                                unlink(sql_file_name);