3 -- Sanity checks for common errors in making operator/procedure system tables:
4 -- pg_operator, pg_proc, pg_cast, pg_aggregate, pg_am, pg_amop, pg_amproc, pg_opclass.
6 -- None of the SELECTs here should ever find any matching entries,
7 -- so the expected output is easy to maintain ;-).
8 -- A test failure indicates someone messed up an entry in the system tables.
10 -- NB: we assume the oidjoins test will have caught any dangling links,
11 -- that is OID or REGPROC fields that are not zero and do not match some
12 -- row in the linked-to table. However, if we want to enforce that a link
13 -- field can't be 0, we have to check it here.
15 -- NB: run this test earlier than the create_operator test, because
16 -- that test creates some bogus operators...
19 -- Helper functions to deal with cases where binary-coercible matches are
22 -- This should match IsBinaryCoercible() in parse_coerce.c.
23 create function binary_coercible(oid, oid) returns bool as
25 EXISTS(select 1 from pg_cast where
26 castsource = $1 and casttarget = $2 and
27 castfunc = 0 and castcontext = ''i'') OR
28 ( EXISTS(select 1 from pg_type source where
29 source.oid = $1 and source.typelem != 0 )
31 EXISTS(select 1 from pg_type target where
32 target.oid = $2 and target.typname = ''anyarray'' ) )'
35 -- This one ignores castcontext, so it considers only physical equivalence
36 -- and not whether the coercion can be invoked implicitly.
37 create function physically_coercible(oid, oid) returns bool as
39 EXISTS(select 1 from pg_cast where
40 castsource = $1 and casttarget = $2 and
44 -- **************** pg_proc ****************
46 -- Look for illegal values in pg_proc fields.
48 SELECT p1.oid, p1.proname
50 WHERE p1.prolang = 0 OR p1.prorettype = 0 OR
52 array_lower(p1.proargtypes, 1) != 0 OR
53 array_upper(p1.proargtypes, 1) != p1.pronargs-1 OR
54 0::oid = ANY (p1.proargtypes);
56 -- Look for conflicting proc definitions (same names and input datatypes).
57 -- (This test should be dead code now that we have the unique index
58 -- pg_proc_proname_args_nsp_index, but I'll leave it in anyway.)
60 SELECT p1.oid, p1.proname, p2.oid, p2.proname
61 FROM pg_proc AS p1, pg_proc AS p2
62 WHERE p1.oid != p2.oid AND
63 p1.proname = p2.proname AND
64 p1.pronargs = p2.pronargs AND
65 p1.proargtypes = p2.proargtypes;
67 -- Considering only built-in procs (prolang = 12), look for multiple uses
68 -- of the same internal function (ie, matching prosrc fields). It's OK to
69 -- have several entries with different pronames for the same internal function,
70 -- but conflicts in the number of arguments and other critical items should
71 -- be complained of. (We don't check data types here; see next query.)
72 -- Note: ignore aggregate functions here, since they all point to the same
73 -- dummy built-in function.
75 SELECT p1.oid, p1.proname, p2.oid, p2.proname
76 FROM pg_proc AS p1, pg_proc AS p2
77 WHERE p1.oid < p2.oid AND
78 p1.prosrc = p2.prosrc AND
79 p1.prolang = 12 AND p2.prolang = 12 AND
80 (p1.proisagg = false OR p2.proisagg = false) AND
81 (p1.prolang != p2.prolang OR
82 p1.proisagg != p2.proisagg OR
83 p1.prosecdef != p2.prosecdef OR
84 p1.proisstrict != p2.proisstrict OR
85 p1.proretset != p2.proretset OR
86 p1.provolatile != p2.provolatile OR
87 p1.pronargs != p2.pronargs);
89 -- Look for uses of different type OIDs in the argument/result type fields
90 -- for different aliases of the same built-in function.
91 -- This indicates that the types are being presumed to be binary-equivalent,
92 -- or that the built-in function is prepared to deal with different types.
93 -- That's not wrong, necessarily, but we make lists of all the types being
94 -- so treated. Note that the expected output of this part of the test will
95 -- need to be modified whenever new pairs of types are made binary-equivalent,
96 -- or when new polymorphic built-in functions are added!
97 -- Note: ignore aggregate functions here, since they all point to the same
98 -- dummy built-in function.
100 SELECT DISTINCT p1.prorettype, p2.prorettype
101 FROM pg_proc AS p1, pg_proc AS p2
102 WHERE p1.oid != p2.oid AND
103 p1.prosrc = p2.prosrc AND
104 p1.prolang = 12 AND p2.prolang = 12 AND
105 NOT p1.proisagg AND NOT p2.proisagg AND
106 (p1.prorettype < p2.prorettype);
108 SELECT DISTINCT p1.proargtypes[0], p2.proargtypes[0]
109 FROM pg_proc AS p1, pg_proc AS p2
110 WHERE p1.oid != p2.oid AND
111 p1.prosrc = p2.prosrc AND
112 p1.prolang = 12 AND p2.prolang = 12 AND
113 NOT p1.proisagg AND NOT p2.proisagg AND
114 (p1.proargtypes[0] < p2.proargtypes[0]);
116 SELECT DISTINCT p1.proargtypes[1], p2.proargtypes[1]
117 FROM pg_proc AS p1, pg_proc AS p2
118 WHERE p1.oid != p2.oid AND
119 p1.prosrc = p2.prosrc AND
120 p1.prolang = 12 AND p2.prolang = 12 AND
121 NOT p1.proisagg AND NOT p2.proisagg AND
122 (p1.proargtypes[1] < p2.proargtypes[1]);
124 SELECT DISTINCT p1.proargtypes[2], p2.proargtypes[2]
125 FROM pg_proc AS p1, pg_proc AS p2
126 WHERE p1.oid != p2.oid AND
127 p1.prosrc = p2.prosrc AND
128 p1.prolang = 12 AND p2.prolang = 12 AND
129 NOT p1.proisagg AND NOT p2.proisagg AND
130 (p1.proargtypes[2] < p2.proargtypes[2]);
132 SELECT DISTINCT p1.proargtypes[3], p2.proargtypes[3]
133 FROM pg_proc AS p1, pg_proc AS p2
134 WHERE p1.oid != p2.oid AND
135 p1.prosrc = p2.prosrc AND
136 p1.prolang = 12 AND p2.prolang = 12 AND
137 NOT p1.proisagg AND NOT p2.proisagg AND
138 (p1.proargtypes[3] < p2.proargtypes[3]);
140 SELECT DISTINCT p1.proargtypes[4], p2.proargtypes[4]
141 FROM pg_proc AS p1, pg_proc AS p2
142 WHERE p1.oid != p2.oid AND
143 p1.prosrc = p2.prosrc AND
144 p1.prolang = 12 AND p2.prolang = 12 AND
145 NOT p1.proisagg AND NOT p2.proisagg AND
146 (p1.proargtypes[4] < p2.proargtypes[4]);
148 SELECT DISTINCT p1.proargtypes[5], p2.proargtypes[5]
149 FROM pg_proc AS p1, pg_proc AS p2
150 WHERE p1.oid != p2.oid AND
151 p1.prosrc = p2.prosrc AND
152 p1.prolang = 12 AND p2.prolang = 12 AND
153 NOT p1.proisagg AND NOT p2.proisagg AND
154 (p1.proargtypes[5] < p2.proargtypes[5]);
156 SELECT DISTINCT p1.proargtypes[6], p2.proargtypes[6]
157 FROM pg_proc AS p1, pg_proc AS p2
158 WHERE p1.oid != p2.oid AND
159 p1.prosrc = p2.prosrc AND
160 p1.prolang = 12 AND p2.prolang = 12 AND
161 NOT p1.proisagg AND NOT p2.proisagg AND
162 (p1.proargtypes[6] < p2.proargtypes[6]);
164 SELECT DISTINCT p1.proargtypes[7], p2.proargtypes[7]
165 FROM pg_proc AS p1, pg_proc AS p2
166 WHERE p1.oid != p2.oid AND
167 p1.prosrc = p2.prosrc AND
168 p1.prolang = 12 AND p2.prolang = 12 AND
169 NOT p1.proisagg AND NOT p2.proisagg AND
170 (p1.proargtypes[7] < p2.proargtypes[7]);
172 -- Look for functions that return type "internal" and do not have any
173 -- "internal" argument. Such a function would be a security hole since
174 -- it might be used to call an internal function from an SQL command.
175 -- As of 7.3 this query should find only internal_in.
177 SELECT p1.oid, p1.proname
179 WHERE p1.prorettype = 'internal'::regtype AND NOT
180 'internal'::regtype = ANY (p1.proargtypes);
183 -- **************** pg_cast ****************
185 -- Catch bogus values in pg_cast columns (other than cases detected by
190 WHERE castsource = 0 OR casttarget = 0 OR castcontext NOT IN ('e', 'a', 'i');
192 -- Look for casts to/from the same type that aren't length coercion functions.
193 -- (We assume they are length coercions if they take multiple arguments.)
194 -- Such entries are not necessarily harmful, but they are useless.
198 WHERE castsource = casttarget AND castfunc = 0;
201 FROM pg_cast c, pg_proc p
202 WHERE c.castfunc = p.oid AND p.pronargs < 2 AND castsource = casttarget;
204 -- Look for cast functions that don't have the right signature. The
205 -- argument and result types in pg_proc must be the same as, or binary
206 -- compatible with, what it says in pg_cast.
207 -- As a special case, we allow casts from CHAR(n) that use functions
208 -- declared to take TEXT. This does not pass the binary-coercibility test
209 -- because CHAR(n)-to-TEXT normally invokes rtrim(). However, the results
210 -- are the same, so long as the function is one that ignores trailing blanks.
213 FROM pg_cast c, pg_proc p
214 WHERE c.castfunc = p.oid AND
215 (p.pronargs < 1 OR p.pronargs > 3
216 OR NOT (binary_coercible(c.castsource, p.proargtypes[0])
217 OR (c.castsource = 'character'::regtype AND
218 p.proargtypes[0] = 'text'::regtype))
219 OR NOT binary_coercible(p.prorettype, c.casttarget));
222 FROM pg_cast c, pg_proc p
223 WHERE c.castfunc = p.oid AND
224 ((p.pronargs > 1 AND p.proargtypes[1] != 'int4'::regtype) OR
225 (p.pronargs > 2 AND p.proargtypes[2] != 'bool'::regtype));
227 -- Look for binary compatible casts that do not have the reverse
228 -- direction registered as well, or where the reverse direction is not
229 -- also binary compatible. This is legal, but usually not intended.
231 -- As of 7.4, this finds the casts from text and varchar to bpchar, because
232 -- those are binary-compatible while the reverse way goes through rtrim().
234 -- As of 8.2, this finds the cast from cidr to inet, because that is a
235 -- trivial binary coercion while the other way goes through inet_to_cidr().
239 WHERE c.castfunc = 0 AND
240 NOT EXISTS (SELECT 1 FROM pg_cast k
241 WHERE k.castfunc = 0 AND
242 k.castsource = c.casttarget AND
243 k.casttarget = c.castsource);
245 -- **************** pg_operator ****************
247 -- Look for illegal values in pg_operator fields.
249 SELECT p1.oid, p1.oprname
250 FROM pg_operator as p1
251 WHERE (p1.oprkind != 'b' AND p1.oprkind != 'l' AND p1.oprkind != 'r') OR
252 p1.oprresult = 0 OR p1.oprcode = 0;
254 -- Look for missing or unwanted operand types
256 SELECT p1.oid, p1.oprname
257 FROM pg_operator as p1
258 WHERE (p1.oprleft = 0 and p1.oprkind != 'l') OR
259 (p1.oprleft != 0 and p1.oprkind = 'l') OR
260 (p1.oprright = 0 and p1.oprkind != 'r') OR
261 (p1.oprright != 0 and p1.oprkind = 'r');
263 -- Look for conflicting operator definitions (same names and input datatypes).
265 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
266 FROM pg_operator AS p1, pg_operator AS p2
267 WHERE p1.oid != p2.oid AND
268 p1.oprname = p2.oprname AND
269 p1.oprkind = p2.oprkind AND
270 p1.oprleft = p2.oprleft AND
271 p1.oprright = p2.oprright;
273 -- Look for commutative operators that don't commute.
274 -- DEFINITIONAL NOTE: If A.oprcom = B, then x A y has the same result as y B x.
275 -- We expect that B will always say that B.oprcom = A as well; that's not
276 -- inherently essential, but it would be inefficient not to mark it so.
278 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
279 FROM pg_operator AS p1, pg_operator AS p2
280 WHERE p1.oprcom = p2.oid AND
281 (p1.oprkind != 'b' OR
282 p1.oprleft != p2.oprright OR
283 p1.oprright != p2.oprleft OR
284 p1.oprresult != p2.oprresult OR
285 p1.oid != p2.oprcom);
287 -- Look for negatory operators that don't agree.
288 -- DEFINITIONAL NOTE: If A.oprnegate = B, then both A and B must yield
289 -- boolean results, and (x A y) == ! (x B y), or the equivalent for
290 -- single-operand operators.
291 -- We expect that B will always say that B.oprnegate = A as well; that's not
292 -- inherently essential, but it would be inefficient not to mark it so.
293 -- Also, A and B had better not be the same operator.
295 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
296 FROM pg_operator AS p1, pg_operator AS p2
297 WHERE p1.oprnegate = p2.oid AND
298 (p1.oprkind != p2.oprkind OR
299 p1.oprleft != p2.oprleft OR
300 p1.oprright != p2.oprright OR
301 p1.oprresult != 'bool'::regtype OR
302 p2.oprresult != 'bool'::regtype OR
303 p1.oid != p2.oprnegate OR
306 -- Look for mergejoin operators that don't match their links.
307 -- An lsortop/rsortop link leads from an '=' operator to the
308 -- sort operator ('<' operator) that's appropriate for
309 -- its left-side or right-side data type.
310 -- An ltcmpop/gtcmpop link leads from an '=' operator to the
311 -- '<' or '>' operator of the same input datatypes.
312 -- (If the '=' operator has identical L and R input datatypes,
313 -- then lsortop, rsortop, and ltcmpop are all the same operator.)
315 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
316 FROM pg_operator AS p1, pg_operator AS p2
317 WHERE p1.oprlsortop = p2.oid AND
318 (p1.oprname NOT IN ('=', '~=~') OR p2.oprname NOT IN ('<', '~<~') OR
319 p1.oprkind != 'b' OR p2.oprkind != 'b' OR
320 p1.oprleft != p2.oprleft OR
321 p1.oprleft != p2.oprright OR
322 p1.oprresult != 'bool'::regtype OR
323 p2.oprresult != 'bool'::regtype);
325 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
326 FROM pg_operator AS p1, pg_operator AS p2
327 WHERE p1.oprrsortop = p2.oid AND
328 (p1.oprname NOT IN ('=', '~=~') OR p2.oprname NOT IN ('<', '~<~') OR
329 p1.oprkind != 'b' OR p2.oprkind != 'b' OR
330 p1.oprright != p2.oprleft OR
331 p1.oprright != p2.oprright OR
332 p1.oprresult != 'bool'::regtype OR
333 p2.oprresult != 'bool'::regtype);
335 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
336 FROM pg_operator AS p1, pg_operator AS p2
337 WHERE p1.oprltcmpop = p2.oid AND
338 (p1.oprname NOT IN ('=', '~=~') OR p2.oprname NOT IN ('<', '~<~') OR
339 p1.oprkind != 'b' OR p2.oprkind != 'b' OR
340 p1.oprleft != p2.oprleft OR
341 p1.oprright != p2.oprright OR
342 p1.oprresult != 'bool'::regtype OR
343 p2.oprresult != 'bool'::regtype);
345 SELECT p1.oid, p1.oprcode, p2.oid, p2.oprcode
346 FROM pg_operator AS p1, pg_operator AS p2
347 WHERE p1.oprgtcmpop = p2.oid AND
348 (p1.oprname NOT IN ('=', '~=~') OR p2.oprname NOT IN ('>', '~>~') OR
349 p1.oprkind != 'b' OR p2.oprkind != 'b' OR
350 p1.oprleft != p2.oprleft OR
351 p1.oprright != p2.oprright OR
352 p1.oprresult != 'bool'::regtype OR
353 p2.oprresult != 'bool'::regtype);
355 -- Make sure all four links are specified if any are.
357 SELECT p1.oid, p1.oprcode
358 FROM pg_operator AS p1
359 WHERE NOT ((oprlsortop = 0 AND oprrsortop = 0 AND
360 oprltcmpop = 0 AND oprgtcmpop = 0) OR
361 (oprlsortop != 0 AND oprrsortop != 0 AND
362 oprltcmpop != 0 AND oprgtcmpop != 0));
364 -- A mergejoinable = operator must have a commutator (usually itself).
366 SELECT p1.oid, p1.oprname FROM pg_operator AS p1
367 WHERE p1.oprlsortop != 0 AND
370 -- Mergejoinable operators across datatypes must come in closed sets, that
371 -- is if you provide int2 = int4 and int4 = int8 then you must also provide
372 -- int2 = int8 (and commutators of all these). This is necessary because
373 -- the planner tries to deduce additional qual clauses from transitivity
374 -- of mergejoinable operators. If there are clauses int2var = int4var and
375 -- int4var = int8var, the planner will deduce int2var = int8var ... and it
376 -- had better have a way to represent it.
378 SELECT p1.oid, p2.oid FROM pg_operator AS p1, pg_operator AS p2
379 WHERE p1.oprlsortop != p1.oprrsortop AND
380 p1.oprrsortop = p2.oprlsortop AND
381 p2.oprlsortop != p2.oprrsortop AND
382 NOT EXISTS (SELECT 1 FROM pg_operator p3 WHERE
383 p3.oprlsortop = p1.oprlsortop AND p3.oprrsortop = p2.oprrsortop);
386 -- Hashing only works on simple equality operators "type = sametype",
387 -- since the hash itself depends on the bitwise representation of the type.
388 -- Check that allegedly hashable operators look like they might be "=".
390 SELECT p1.oid, p1.oprname
391 FROM pg_operator AS p1
392 WHERE p1.oprcanhash AND NOT
393 (p1.oprkind = 'b' AND p1.oprresult = 'bool'::regtype AND
394 p1.oprleft = p1.oprright AND p1.oprname IN ('=', '~=~') AND
397 -- In 6.5 we accepted hashable array equality operators when the array element
398 -- type is hashable. However, what we actually need to make hashjoin work on
399 -- an array is a hashable element type *and* no padding between elements in
400 -- the array storage (or, perhaps, guaranteed-zero padding). Currently,
401 -- since the padding code in arrayfuncs.c is pretty bogus, it seems safest
402 -- to just forbid hashjoin on array equality ops.
403 -- This should be reconsidered someday.
405 -- -- Look for array equality operators that are hashable when the underlying
406 -- -- type is not, or vice versa. This is presumably bogus.
408 -- SELECT p1.oid, p1.oprcanhash, p2.oid, p2.oprcanhash, t1.typname, t2.typname
409 -- FROM pg_operator AS p1, pg_operator AS p2, pg_type AS t1, pg_type AS t2
410 -- WHERE p1.oprname = '=' AND p1.oprleft = p1.oprright AND
411 -- p2.oprname = '=' AND p2.oprleft = p2.oprright AND
412 -- p1.oprleft = t1.oid AND p2.oprleft = t2.oid AND t1.typelem = t2.oid AND
413 -- p1.oprcanhash != p2.oprcanhash;
415 -- Substitute check: forbid hashable array ops, period.
416 SELECT p1.oid, p1.oprname
417 FROM pg_operator AS p1, pg_proc AS p2
418 WHERE p1.oprcanhash AND p1.oprcode = p2.oid AND p2.proname = 'array_eq';
420 -- Hashable operators should appear as members of hash index opclasses.
422 SELECT p1.oid, p1.oprname
423 FROM pg_operator AS p1
424 WHERE p1.oprcanhash AND NOT EXISTS
425 (SELECT 1 FROM pg_opclass op JOIN pg_amop p ON op.oid = amopclaid
426 WHERE opcamid = (SELECT oid FROM pg_am WHERE amname = 'hash') AND
431 SELECT p1.oid, p1.oprname, op.opcname
432 FROM pg_operator AS p1, pg_opclass op, pg_amop p
433 WHERE amopopr = p1.oid AND amopclaid = op.oid
434 AND opcamid = (SELECT oid FROM pg_am WHERE amname = 'hash')
435 AND NOT p1.oprcanhash;
437 -- Check that each operator defined in pg_operator matches its oprcode entry
438 -- in pg_proc. Easiest to do this separately for each oprkind.
440 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
441 FROM pg_operator AS p1, pg_proc AS p2
442 WHERE p1.oprcode = p2.oid AND
445 OR NOT binary_coercible(p2.prorettype, p1.oprresult)
446 OR NOT binary_coercible(p1.oprleft, p2.proargtypes[0])
447 OR NOT binary_coercible(p1.oprright, p2.proargtypes[1]));
449 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
450 FROM pg_operator AS p1, pg_proc AS p2
451 WHERE p1.oprcode = p2.oid AND
454 OR NOT binary_coercible(p2.prorettype, p1.oprresult)
455 OR NOT binary_coercible(p1.oprright, p2.proargtypes[0])
458 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
459 FROM pg_operator AS p1, pg_proc AS p2
460 WHERE p1.oprcode = p2.oid AND
463 OR NOT binary_coercible(p2.prorettype, p1.oprresult)
464 OR NOT binary_coercible(p1.oprleft, p2.proargtypes[0])
465 OR p1.oprright != 0);
467 -- If the operator is mergejoinable or hashjoinable, its underlying function
468 -- should not be volatile.
470 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
471 FROM pg_operator AS p1, pg_proc AS p2
472 WHERE p1.oprcode = p2.oid AND
473 (p1.oprlsortop != 0 OR p1.oprcanhash) AND
474 p2.provolatile = 'v';
476 -- If oprrest is set, the operator must return boolean,
477 -- and it must link to a proc with the right signature
478 -- to be a restriction selectivity estimator.
479 -- The proc signature we want is: float8 proc(internal, oid, internal, int4)
481 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
482 FROM pg_operator AS p1, pg_proc AS p2
483 WHERE p1.oprrest = p2.oid AND
484 (p1.oprresult != 'bool'::regtype OR
485 p2.prorettype != 'float8'::regtype OR p2.proretset OR
487 p2.proargtypes[0] != 'internal'::regtype OR
488 p2.proargtypes[1] != 'oid'::regtype OR
489 p2.proargtypes[2] != 'internal'::regtype OR
490 p2.proargtypes[3] != 'int4'::regtype);
492 -- If oprjoin is set, the operator must be a binary boolean op,
493 -- and it must link to a proc with the right signature
494 -- to be a join selectivity estimator.
495 -- The proc signature we want is: float8 proc(internal, oid, internal, int2)
497 SELECT p1.oid, p1.oprname, p2.oid, p2.proname
498 FROM pg_operator AS p1, pg_proc AS p2
499 WHERE p1.oprjoin = p2.oid AND
500 (p1.oprkind != 'b' OR p1.oprresult != 'bool'::regtype OR
501 p2.prorettype != 'float8'::regtype OR p2.proretset OR
503 p2.proargtypes[0] != 'internal'::regtype OR
504 p2.proargtypes[1] != 'oid'::regtype OR
505 p2.proargtypes[2] != 'internal'::regtype OR
506 p2.proargtypes[3] != 'int2'::regtype);
508 -- **************** pg_aggregate ****************
510 -- Look for illegal values in pg_aggregate fields.
512 SELECT ctid, aggfnoid::oid
513 FROM pg_aggregate as p1
514 WHERE aggfnoid = 0 OR aggtransfn = 0 OR aggtranstype = 0;
516 -- Make sure the matching pg_proc entry is sensible, too.
518 SELECT a.aggfnoid::oid, p.proname
519 FROM pg_aggregate as a, pg_proc as p
520 WHERE a.aggfnoid = p.oid AND
521 (NOT p.proisagg OR p.proretset);
523 -- Make sure there are no proisagg pg_proc entries without matches.
528 NOT EXISTS (SELECT 1 FROM pg_aggregate a WHERE a.aggfnoid = p.oid);
530 -- If there is no finalfn then the output type must be the transtype.
532 SELECT a.aggfnoid::oid, p.proname
533 FROM pg_aggregate as a, pg_proc as p
534 WHERE a.aggfnoid = p.oid AND
535 a.aggfinalfn = 0 AND p.prorettype != a.aggtranstype;
537 -- Cross-check transfn against its entry in pg_proc.
538 -- NOTE: use physically_coercible here, not binary_coercible, because
539 -- max and min on abstime are implemented using int4larger/int4smaller.
540 SELECT a.aggfnoid::oid, p.proname, ptr.oid, ptr.proname
541 FROM pg_aggregate AS a, pg_proc AS p, pg_proc AS ptr
542 WHERE a.aggfnoid = p.oid AND
543 a.aggtransfn = ptr.oid AND
545 OR NOT (ptr.pronargs = p.pronargs + 1)
546 OR NOT physically_coercible(ptr.prorettype, a.aggtranstype)
547 OR NOT physically_coercible(a.aggtranstype, ptr.proargtypes[0])
548 OR (p.pronargs > 0 AND
549 NOT physically_coercible(p.proargtypes[0], ptr.proargtypes[1]))
550 OR (p.pronargs > 1 AND
551 NOT physically_coercible(p.proargtypes[1], ptr.proargtypes[2]))
552 OR (p.pronargs > 2 AND
553 NOT physically_coercible(p.proargtypes[2], ptr.proargtypes[3]))
554 -- we could carry the check further, but that's enough for now
557 -- Cross-check finalfn (if present) against its entry in pg_proc.
559 SELECT a.aggfnoid::oid, p.proname, pfn.oid, pfn.proname
560 FROM pg_aggregate AS a, pg_proc AS p, pg_proc AS pfn
561 WHERE a.aggfnoid = p.oid AND
562 a.aggfinalfn = pfn.oid AND
564 OR NOT binary_coercible(pfn.prorettype, p.prorettype)
566 OR NOT binary_coercible(a.aggtranstype, pfn.proargtypes[0]));
568 -- If transfn is strict then either initval should be non-NULL, or
569 -- input type should match transtype so that the first non-null input
570 -- can be assigned as the state value.
572 SELECT a.aggfnoid::oid, p.proname, ptr.oid, ptr.proname
573 FROM pg_aggregate AS a, pg_proc AS p, pg_proc AS ptr
574 WHERE a.aggfnoid = p.oid AND
575 a.aggtransfn = ptr.oid AND ptr.proisstrict AND
576 a.agginitval IS NULL AND
577 NOT binary_coercible(p.proargtypes[0], a.aggtranstype);
579 -- Cross-check aggsortop (if present) against pg_operator.
580 -- We expect to find only "<" for "min" and ">" for "max".
582 SELECT DISTINCT proname, oprname
583 FROM pg_operator AS o, pg_aggregate AS a, pg_proc AS p
584 WHERE a.aggfnoid = p.oid AND a.aggsortop = o.oid
587 -- Check datatypes match
589 SELECT a.aggfnoid::oid, o.oid
590 FROM pg_operator AS o, pg_aggregate AS a, pg_proc AS p
591 WHERE a.aggfnoid = p.oid AND a.aggsortop = o.oid AND
592 (oprkind != 'b' OR oprresult != 'boolean'::regtype
593 OR oprleft != p.proargtypes[0] OR oprright != p.proargtypes[0]);
595 -- Check operator is a suitable btree opclass member
597 SELECT a.aggfnoid::oid, o.oid
598 FROM pg_operator AS o, pg_aggregate AS a, pg_proc AS p
599 WHERE a.aggfnoid = p.oid AND a.aggsortop = o.oid AND
600 NOT EXISTS(SELECT 1 FROM pg_amop ao, pg_opclass oc
601 WHERE amopclaid = oc.oid AND amopsubtype = 0
602 AND amopopr = o.oid AND opcamid = 403
603 AND opcintype = o.oprleft AND opcdefault);
605 -- Check correspondence of btree strategies and names
607 SELECT DISTINCT proname, oprname, amopstrategy
608 FROM pg_operator AS o, pg_aggregate AS a, pg_proc AS p,
609 pg_amop as ao, pg_opclass oc
610 WHERE a.aggfnoid = p.oid AND a.aggsortop = o.oid AND
611 amopclaid = oc.oid AND amopopr = o.oid AND opcamid = 403
614 -- **************** pg_opclass ****************
616 -- Look for illegal values in pg_opclass fields
619 FROM pg_opclass as p1
620 WHERE p1.opcamid = 0 OR p1.opcintype = 0;
622 -- There should not be multiple entries in pg_opclass with opcdefault true
623 -- and the same opcamid/opcintype combination.
625 SELECT p1.oid, p2.oid
626 FROM pg_opclass AS p1, pg_opclass AS p2
627 WHERE p1.oid != p2.oid AND
628 p1.opcamid = p2.opcamid AND p1.opcintype = p2.opcintype AND
629 p1.opcdefault AND p2.opcdefault;
631 -- **************** pg_amop ****************
633 -- Look for illegal values in pg_amop fields
635 SELECT p1.amopclaid, p1.amopstrategy
637 WHERE p1.amopclaid = 0 OR p1.amopstrategy <= 0 OR p1.amopopr = 0;
639 -- Cross-check amopstrategy index against parent AM
641 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.amname
642 FROM pg_amop AS p1, pg_am AS p2, pg_opclass AS p3
643 WHERE p1.amopclaid = p3.oid AND p3.opcamid = p2.oid AND
644 p1.amopstrategy > p2.amstrategies;
646 -- Detect missing pg_amop entries: should have as many strategy operators
647 -- as AM expects for each opclass for the AM. When nondefault subtypes are
648 -- present, enforce condition separately for each subtype.
649 -- We have to exclude GiST and GIN, unfortunately, since its havn't got any fixed
650 -- requirements about strategy operators.
652 SELECT p1.oid, p1.amname, p2.oid, p2.opcname, p3.amopsubtype
653 FROM pg_am AS p1, pg_opclass AS p2, pg_amop AS p3
654 WHERE p2.opcamid = p1.oid AND p3.amopclaid = p2.oid AND
655 p1.amname != 'gist' AND p1.amname != 'gin' AND
656 p1.amstrategies != (SELECT count(*) FROM pg_amop AS p4
657 WHERE p4.amopclaid = p2.oid AND
658 p4.amopsubtype = p3.amopsubtype);
660 -- Check that amopopr points at a reasonable-looking operator, ie a binary
661 -- operator yielding boolean.
663 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname
664 FROM pg_amop AS p1, pg_operator AS p2
665 WHERE p1.amopopr = p2.oid AND
666 (p2.oprkind != 'b' OR p2.oprresult != 'bool'::regtype);
668 -- Make a list of all the distinct operator names being used in particular
669 -- strategy slots. This is a bit hokey, since the list might need to change
670 -- in future releases, but it's an effective way of spotting mistakes such as
671 -- swapping two operators within a class.
673 SELECT DISTINCT opcamid, amopstrategy, oprname
674 FROM pg_amop p1 LEFT JOIN pg_opclass p2 ON amopclaid = p2.oid
675 LEFT JOIN pg_operator p3 ON amopopr = p3.oid
678 -- Check that all operators linked to by opclass entries have selectivity
679 -- estimators. This is not absolutely required, but it seems a reasonable
680 -- thing to insist on for all standard datatypes.
682 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname
683 FROM pg_amop AS p1, pg_operator AS p2
684 WHERE p1.amopopr = p2.oid AND
685 (p2.oprrest = 0 OR p2.oprjoin = 0);
687 -- Check that operator input types match the opclass
688 -- For 8.0, we require that oprleft match opcintype (possibly by coercion).
689 -- When amopsubtype is zero (default), oprright must equal oprleft;
690 -- when amopsubtype is not zero, oprright must equal amopsubtype.
692 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname, p3.opcname
693 FROM pg_amop AS p1, pg_operator AS p2, pg_opclass AS p3
694 WHERE p1.amopopr = p2.oid AND p1.amopclaid = p3.oid AND
695 NOT binary_coercible(p3.opcintype, p2.oprleft);
697 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname, p3.opcname
698 FROM pg_amop AS p1, pg_operator AS p2, pg_opclass AS p3
699 WHERE p1.amopopr = p2.oid AND p1.amopclaid = p3.oid AND
700 p1.amopsubtype = 0 AND
701 p2.oprleft != p2.oprright;
703 SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname, p3.opcname
704 FROM pg_amop AS p1, pg_operator AS p2, pg_opclass AS p3
705 WHERE p1.amopopr = p2.oid AND p1.amopclaid = p3.oid AND
706 p1.amopsubtype != 0 AND
707 p1.amopsubtype != p2.oprright;
709 -- Operators that are primary members of opclasses must be immutable (else
710 -- it suggests that the index ordering isn't fixed). Operators that are
711 -- cross-type members need only be stable, since they are just shorthands
712 -- for index probe queries.
714 SELECT p1.amopclaid, p1.amopopr, p2.oprname, p3.prosrc
715 FROM pg_amop AS p1, pg_operator AS p2, pg_proc AS p3
716 WHERE p1.amopopr = p2.oid AND p2.oprcode = p3.oid AND
717 p1.amopsubtype = 0 AND
718 p3.provolatile != 'i';
720 SELECT p1.amopclaid, p1.amopopr, p2.oprname, p3.prosrc
721 FROM pg_amop AS p1, pg_operator AS p2, pg_proc AS p3
722 WHERE p1.amopopr = p2.oid AND p2.oprcode = p3.oid AND
723 p1.amopsubtype != 0 AND
724 p3.provolatile = 'v';
726 -- **************** pg_amproc ****************
728 -- Look for illegal values in pg_amproc fields
730 SELECT p1.amopclaid, p1.amprocnum
732 WHERE p1.amopclaid = 0 OR p1.amprocnum <= 0 OR p1.amproc = 0;
734 -- Cross-check amprocnum index against parent AM
736 SELECT p1.amopclaid, p1.amprocnum, p2.oid, p2.amname
737 FROM pg_amproc AS p1, pg_am AS p2, pg_opclass AS p3
738 WHERE p1.amopclaid = p3.oid AND p3.opcamid = p2.oid AND
739 p1.amprocnum > p2.amsupport;
741 -- Detect missing pg_amproc entries: should have as many support functions
742 -- as AM expects for each opclass for the AM. When nondefault subtypes are
743 -- present, enforce condition separately for each subtype.
745 SELECT p1.oid, p1.amname, p2.oid, p2.opcname, p3.amprocsubtype
746 FROM pg_am AS p1, pg_opclass AS p2, pg_amproc AS p3
747 WHERE p2.opcamid = p1.oid AND p3.amopclaid = p2.oid AND
748 p1.amsupport != (SELECT count(*) FROM pg_amproc AS p4
749 WHERE p4.amopclaid = p2.oid AND
750 p4.amprocsubtype = p3.amprocsubtype);
752 -- Unfortunately, we can't check the amproc link very well because the
753 -- signature of the function may be different for different support routines
754 -- or different base data types.
755 -- We can check that all the referenced instances of the same support
756 -- routine number take the same number of parameters, but that's about it
757 -- for a general check...
759 SELECT p1.amopclaid, p1.amprocnum,
762 p4.amopclaid, p4.amprocnum,
765 FROM pg_amproc AS p1, pg_proc AS p2, pg_opclass AS p3,
766 pg_amproc AS p4, pg_proc AS p5, pg_opclass AS p6
767 WHERE p1.amopclaid = p3.oid AND p4.amopclaid = p6.oid AND
768 p3.opcamid = p6.opcamid AND p1.amprocnum = p4.amprocnum AND
769 p1.amproc = p2.oid AND p4.amproc = p5.oid AND
770 (p2.proretset OR p5.proretset OR p2.pronargs != p5.pronargs);
772 -- For btree, though, we can do better since we know the support routines
773 -- must be of the form cmp(input, input) returns int4 in the default case
774 -- (subtype = 0), and cmp(input, subtype) returns int4 when subtype != 0.
776 SELECT p1.amopclaid, p1.amprocnum,
779 FROM pg_amproc AS p1, pg_proc AS p2, pg_opclass AS p3
780 WHERE p3.opcamid = (SELECT oid FROM pg_am WHERE amname = 'btree')
781 AND p1.amopclaid = p3.oid AND p1.amproc = p2.oid AND
782 amprocsubtype = 0 AND
788 OR NOT binary_coercible(opcintype, proargtypes[0])
789 OR proargtypes[0] != proargtypes[1]);
791 SELECT p1.amopclaid, p1.amprocnum,
794 FROM pg_amproc AS p1, pg_proc AS p2, pg_opclass AS p3
795 WHERE p3.opcamid = (SELECT oid FROM pg_am WHERE amname = 'btree')
796 AND p1.amopclaid = p3.oid AND p1.amproc = p2.oid AND
797 amprocsubtype != 0 AND
803 OR NOT binary_coercible(opcintype, proargtypes[0])
804 OR proargtypes[1] != amprocsubtype);
806 -- For hash we can also do a little better: the support routines must be
807 -- of the form hash(something) returns int4. Ideally we'd check that the
808 -- opcintype is binary-coercible to the function's input, but there are
809 -- enough cases where that fails that I'll just leave out the check for now.
811 SELECT p1.amopclaid, p1.amprocnum,
814 FROM pg_amproc AS p1, pg_proc AS p2, pg_opclass AS p3
815 WHERE p3.opcamid = (SELECT oid FROM pg_am WHERE amname = 'hash')
816 AND p1.amopclaid = p3.oid AND p1.amproc = p2.oid AND
822 -- OR NOT physically_coercible(opcintype, proargtypes[0])
825 -- Support routines that are primary members of opclasses must be immutable
826 -- (else it suggests that the index ordering isn't fixed). But cross-type
827 -- members need only be stable, since they are just shorthands
828 -- for index probe queries.
830 SELECT p1.amopclaid, p1.amproc, p2.prosrc
831 FROM pg_amproc AS p1, pg_proc AS p2
832 WHERE p1.amproc = p2.oid AND
833 p1.amprocsubtype = 0 AND
834 p2.provolatile != 'i';
836 SELECT p1.amopclaid, p1.amproc, p2.prosrc
837 FROM pg_amproc AS p1, pg_proc AS p2
838 WHERE p1.amproc = p2.oid AND
839 p1.amprocsubtype != 0 AND
840 p2.provolatile = 'v';