1 /* Licensed to the Apache Software Foundation (ASF) under one or more
2 * contributor license agreements. See the NOTICE file distributed with
3 * this work for additional information regarding copyright ownership.
4 * The ASF licenses this file to You under the Apache License, Version 2.0
5 * (the "License"); you may not use this file except in compliance with
6 * the License. You may obtain a copy of the License at
8 * http://www.apache.org/licenses/LICENSE-2.0
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
19 #include "apr_strings.h"
21 #define APR_WANT_STRFUNC
28 #include "ap_config.h"
30 #include "http_config.h"
31 #include "http_main.h"
33 #include "http_core.h"
34 #include "http_protocol.h"
35 #include "http_request.h" /* for sub_req_lookup_uri() */
36 #include "util_script.h"
37 #include "apr_date.h" /* For apr_date_parse_http() */
38 #include "util_ebcdic.h"
46 * Various utility functions which are common to a whole lot of
47 * script-type extensions mechanisms, and might as well be gathered
48 * in one place (if only to avoid creating inter-module dependancies
49 * where there don't have to be).
52 /* we know core's module_index is 0 */
53 #undef APLOG_MODULE_INDEX
54 #define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX
56 static char *http2env(request_rec *r, const char *w)
58 char *res = (char *)apr_palloc(r->pool, sizeof("HTTP_") + strlen(w));
68 while ((c = *w++) != 0) {
70 *cp++ = apr_toupper(c);
77 ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
78 "Not exporting header with invalid name as envvar: %s",
79 ap_escape_logitem(r->pool, w));
88 static void add_unless_null(apr_table_t *table, const char *name, const char *val)
91 apr_table_addn(table, name, val);
95 static void env2env(apr_table_t *table, const char *name)
97 add_unless_null(table, name, getenv(name));
100 AP_DECLARE(char **) ap_create_environment(apr_pool_t *p, apr_table_t *t)
102 const apr_array_header_t *env_arr = apr_table_elts(t);
103 const apr_table_entry_t *elts = (const apr_table_entry_t *) env_arr->elts;
104 char **env = (char **) apr_palloc(p, (env_arr->nelts + 2) * sizeof(char *));
110 if (!apr_table_get(t, "TZ")) {
113 env[j++] = apr_pstrcat(p, "TZ=", tz, NULL);
116 for (i = 0; i < env_arr->nelts; ++i) {
120 env[j] = apr_pstrcat(p, elts[i].key, "=", elts[i].val, NULL);
122 if (apr_isdigit(*whack)) {
125 while (*whack != '=') {
127 if (!apr_isalnum(*whack) && *whack != '(' && *whack != ')') {
129 if (!apr_isalnum(*whack)) {
142 AP_DECLARE(void) ap_add_common_vars(request_rec *r)
145 server_rec *s = r->server;
146 conn_rec *c = r->connection;
147 core_dir_config *conf =
148 (core_dir_config *)ap_get_core_module_config(r->per_dir_config);
149 const char *env_temp;
150 const apr_array_header_t *hdrs_arr = apr_table_elts(r->headers_in);
151 const apr_table_entry_t *hdrs = (const apr_table_entry_t *) hdrs_arr->elts;
156 /* use a temporary apr_table_t which we'll overlap onto
157 * r->subprocess_env later
158 * (exception: if r->subprocess_env is empty at the start,
159 * write directly into it)
161 if (apr_is_empty_table(r->subprocess_env)) {
162 e = r->subprocess_env;
165 e = apr_table_make(r->pool, 25 + hdrs_arr->nelts);
168 /* First, add environment vars from headers... this is as per
169 * CGI specs, though other sorts of scripting interfaces see
173 for (i = 0; i < hdrs_arr->nelts; ++i) {
178 /* A few headers are special cased --- Authorization to prevent
179 * rogue scripts from capturing passwords; content-type and -length
180 * for no particular reason.
183 if (!strcasecmp(hdrs[i].key, "Content-type")) {
184 apr_table_addn(e, "CONTENT_TYPE", hdrs[i].val);
186 else if (!strcasecmp(hdrs[i].key, "Content-length")) {
187 apr_table_addn(e, "CONTENT_LENGTH", hdrs[i].val);
190 * You really don't want to disable this check, since it leaves you
191 * wide open to CGIs stealing passwords and people viewing them
192 * in the environment with "ps -e". But, if you must...
194 #ifndef SECURITY_HOLE_PASS_AUTHORIZATION
195 else if (!strcasecmp(hdrs[i].key, "Authorization")
196 || !strcasecmp(hdrs[i].key, "Proxy-Authorization")) {
197 if (conf->cgi_pass_auth == AP_CGI_PASS_AUTH_ON) {
198 add_unless_null(e, http2env(r, hdrs[i].key), hdrs[i].val);
203 add_unless_null(e, http2env(r, hdrs[i].key), hdrs[i].val);
206 env_temp = apr_table_get(r->subprocess_env, "PATH");
207 if (env_temp == NULL) {
208 env_temp = getenv("PATH");
210 if (env_temp == NULL) {
211 env_temp = DEFAULT_PATH;
213 apr_table_addn(e, "PATH", apr_pstrdup(r->pool, env_temp));
216 env2env(e, "SystemRoot");
217 env2env(e, "COMSPEC");
218 env2env(e, "PATHEXT");
219 env2env(e, "WINDIR");
221 env2env(e, "COMSPEC");
224 env2env(e, "PERLLIB_PREFIX");
226 env2env(e, "LIBRARY_PATH");
227 #elif defined(DARWIN)
228 env2env(e, "DYLD_LIBRARY_PATH");
230 env2env(e, "LIBPATH");
231 #elif defined(__HPUX__)
232 /* HPUX PARISC 2.0W knows both, otherwise redundancy is harmless */
233 env2env(e, "SHLIB_PATH");
234 env2env(e, "LD_LIBRARY_PATH");
235 #else /* Some Unix */
236 env2env(e, "LD_LIBRARY_PATH");
239 apr_table_addn(e, "SERVER_SIGNATURE", ap_psignature("", r));
240 apr_table_addn(e, "SERVER_SOFTWARE", ap_get_server_banner());
241 apr_table_addn(e, "SERVER_NAME",
242 ap_escape_html(r->pool, ap_get_server_name_for_url(r)));
243 apr_table_addn(e, "SERVER_ADDR", r->connection->local_ip); /* Apache */
244 apr_table_addn(e, "SERVER_PORT",
245 apr_psprintf(r->pool, "%u", ap_get_server_port(r)));
246 add_unless_null(e, "REMOTE_HOST",
247 ap_get_remote_host(c, r->per_dir_config, REMOTE_HOST, NULL));
248 apr_table_addn(e, "REMOTE_ADDR", r->useragent_ip);
249 apr_table_addn(e, "DOCUMENT_ROOT", ap_document_root(r)); /* Apache */
250 apr_table_setn(e, "REQUEST_SCHEME", ap_http_scheme(r));
251 apr_table_addn(e, "CONTEXT_PREFIX", ap_context_prefix(r));
252 apr_table_addn(e, "CONTEXT_DOCUMENT_ROOT", ap_context_document_root(r));
253 apr_table_addn(e, "SERVER_ADMIN", s->server_admin); /* Apache */
254 if (apr_table_get(r->notes, "proxy-noquery") && (q = ap_strchr(r->filename, '?'))) {
256 apr_table_addn(e, "SCRIPT_FILENAME", apr_pstrdup(r->pool, r->filename));
260 apr_table_addn(e, "SCRIPT_FILENAME", r->filename); /* Apache */
263 rport = c->client_addr->port;
264 apr_table_addn(e, "REMOTE_PORT", apr_itoa(r->pool, rport));
267 apr_table_addn(e, "REMOTE_USER", r->user);
270 request_rec *back = r->prev;
274 apr_table_addn(e, "REDIRECT_REMOTE_USER", back->user);
280 add_unless_null(e, "AUTH_TYPE", r->ap_auth_type);
281 env_temp = ap_get_remote_logname(r);
283 apr_table_addn(e, "REMOTE_IDENT", apr_pstrdup(r->pool, env_temp));
286 /* Apache custom error responses. If we have redirected set two new vars */
289 /* PR#57785: reconstruct full URL here */
290 apr_uri_t *uri = &r->prev->parsed_uri;
292 uri->scheme = (char*)ap_http_scheme(r->prev);
295 uri->port = ap_get_server_port(r->prev);
296 uri->port_str = apr_psprintf(r->pool, "%u", uri->port);
298 if (!uri->hostname) {
299 uri->hostname = (char*)ap_get_server_name_for_url(r->prev);
301 add_unless_null(e, "REDIRECT_QUERY_STRING", r->prev->args);
302 add_unless_null(e, "REDIRECT_URL",
303 apr_uri_unparse(r->pool, uri, 0));
306 if (e != r->subprocess_env) {
307 apr_table_overlap(r->subprocess_env, e, APR_OVERLAP_TABLES_SET);
311 /* This "cute" little function comes about because the path info on
312 * filenames and URLs aren't always the same. So we take the two,
313 * and find as much of the two that match as possible.
316 AP_DECLARE(int) ap_find_path_info(const char *uri, const char *path_info)
318 int lu = strlen(uri);
319 int lp = strlen(path_info);
321 while (lu-- && lp-- && uri[lu] == path_info[lp]) {
322 if (path_info[lp] == '/') {
323 while (lu && uri[lu-1] == '/') lu--;
331 while (uri[lu] != '\0' && uri[lu] != '/') {
337 /* Obtain the Request-URI from the original request-line, returning
338 * a new string from the request pool containing the URI or "".
340 static char *original_uri(request_rec *r)
344 if (r->the_request == NULL) {
345 return (char *) apr_pcalloc(r->pool, 1);
348 first = r->the_request; /* use the request-line */
350 while (*first && !apr_isspace(*first)) {
351 ++first; /* skip over the method */
353 while (apr_isspace(*first)) {
354 ++first; /* and the space(s) */
358 while (*last && !apr_isspace(*last)) {
359 ++last; /* end at next whitespace */
362 return apr_pstrmemdup(r->pool, first, last - first);
365 AP_DECLARE(void) ap_add_cgi_vars(request_rec *r)
367 apr_table_t *e = r->subprocess_env;
369 apr_table_setn(e, "GATEWAY_INTERFACE", "CGI/1.1");
370 apr_table_setn(e, "SERVER_PROTOCOL", r->protocol);
371 apr_table_setn(e, "REQUEST_METHOD", r->method);
372 apr_table_setn(e, "QUERY_STRING", r->args ? r->args : "");
373 apr_table_setn(e, "REQUEST_URI", original_uri(r));
375 /* Note that the code below special-cases scripts run from includes,
376 * because it "knows" that the sub_request has been hacked to have the
377 * args and path_info of the original request, and not any that may have
378 * come with the script URI in the include command. Ugh.
381 if (!strcmp(r->protocol, "INCLUDED")) {
382 apr_table_setn(e, "SCRIPT_NAME", r->uri);
383 if (r->path_info && *r->path_info) {
384 apr_table_setn(e, "PATH_INFO", r->path_info);
387 else if (!r->path_info || !*r->path_info) {
388 apr_table_setn(e, "SCRIPT_NAME", r->uri);
391 int path_info_start = ap_find_path_info(r->uri, r->path_info);
393 apr_table_setn(e, "SCRIPT_NAME",
394 apr_pstrndup(r->pool, r->uri, path_info_start));
396 apr_table_setn(e, "PATH_INFO", r->path_info);
399 if (r->path_info && r->path_info[0]) {
401 * To get PATH_TRANSLATED, treat PATH_INFO as a URI path.
402 * Need to re-escape it for this, since the entire URI was
403 * un-escaped before we determined where the PATH_INFO began.
407 pa_req = ap_sub_req_lookup_uri(ap_escape_uri(r->pool, r->path_info), r,
410 if (pa_req->filename) {
411 char *pt = apr_pstrcat(r->pool, pa_req->filename, pa_req->path_info,
414 /* We need to make this a real Windows path name */
415 apr_filepath_merge(&pt, "", pt, APR_FILEPATH_NATIVE, r->pool);
417 apr_table_setn(e, "PATH_TRANSLATED", pt);
419 ap_destroy_sub_req(pa_req);
424 static int set_cookie_doo_doo(void *v, const char *key, const char *val)
426 apr_table_addn(v, key, val);
430 #define HTTP_UNSET (-HTTP_OK)
431 #define SCRIPT_LOG_MARK __FILE__,__LINE__,module_index
433 AP_DECLARE(int) ap_scan_script_header_err_core_ex(request_rec *r, char *buffer,
434 int (*getsfunc) (char *, int, void *),
438 char x[MAX_STRING_LEN];
441 int cgi_status = HTTP_UNSET;
443 apr_table_t *cookie_table;
444 int trace_log = APLOG_R_MODULE_IS_LEVEL(r, module_index, APLOG_TRACE1);
445 int first_header = 1;
450 w = buffer ? buffer : x;
452 /* temporary place to hold headers to merge in later */
453 merge = apr_table_make(r->pool, 10);
455 /* The HTTP specification says that it is legal to merge duplicate
456 * headers into one. Some browsers that support Cookies don't like
457 * merged headers and prefer that each Set-Cookie header is sent
458 * separately. Lets humour those browsers by not merging.
459 * Oh what a pain it is.
461 cookie_table = apr_table_make(r->pool, 2);
462 apr_table_do(set_cookie_doo_doo, cookie_table, r->err_headers_out, "Set-Cookie", NULL);
466 int rv = (*getsfunc) (w, MAX_STRING_LEN - 1, getsfunc_data);
468 const char *msg = "Premature end of script headers";
470 msg = "End of script output before headers";
471 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_ERR|APLOG_TOCLIENT, 0, r,
473 apr_filepath_name_get(r->filename));
474 return HTTP_INTERNAL_SERVER_ERROR;
477 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_ERR|APLOG_TOCLIENT, 0, r,
478 "Script timed out before returning headers: %s",
479 apr_filepath_name_get(r->filename));
480 return HTTP_GATEWAY_TIME_OUT;
483 /* Delete terminal (CR?)LF */
486 /* Indeed, the host's '\n':
487 '\012' for UNIX; '\015' for MacOS; '\025' for OS/390
488 -- whatever the script generates.
490 if (p > 0 && w[p - 1] == '\n') {
491 if (p > 1 && w[p - 2] == CR) {
500 * If we've finished reading the headers, check to make sure any
501 * HTTP/1.1 conditions are met. If so, we're done; normal processing
502 * will handle the script's output. If not, just return the error.
503 * The appropriate thing to do would be to send the script process a
504 * SIGPIPE to let it know we're ignoring it, close the channel to the
505 * script process, and *then* return the failed-to-meet-condition
506 * error. Otherwise we'd be waiting for the script to finish
507 * blithering before telling the client the output was no good.
508 * However, we don't have the information to do that, so we have to
509 * leave it to an upper layer.
512 int cond_status = OK;
514 /* PR#38070: This fails because it gets confused when a
515 * CGI Status header overrides ap_meets_conditions.
517 * We can fix that by dropping ap_meets_conditions when
518 * Status has been set. Since this is the only place
519 * cgi_status gets used, let's test it explicitly.
521 * The alternative would be to ignore CGI Status when
522 * ap_meets_conditions returns anything interesting.
523 * That would be safer wrt HTTP, but would break CGI.
525 if ((cgi_status == HTTP_UNSET) && (r->method_number == M_GET)) {
526 cond_status = ap_meets_conditions(r);
528 apr_table_overlap(r->err_headers_out, merge,
529 APR_OVERLAP_TABLES_MERGE);
530 if (!apr_is_empty_table(cookie_table)) {
531 /* the cookies have already been copied to the cookie_table */
532 apr_table_unset(r->err_headers_out, "Set-Cookie");
533 r->err_headers_out = apr_table_overlay(r->pool,
534 r->err_headers_out, cookie_table);
541 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE4, 0, r,
542 "Headers from script '%s':",
543 apr_filepath_name_get(r->filename));
544 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE4, 0, r, " %s", w);
547 /* if we see a bogus header don't ignore it. Shout and scream */
549 #if APR_CHARSET_EBCDIC
550 /* Chances are that we received an ASCII header text instead of
551 * the expected EBCDIC header lines. Try to auto-detect:
553 if (!(l = strchr(w, ':'))) {
554 int maybeASCII = 0, maybeEBCDIC = 0;
555 unsigned char *cp, native;
556 apr_size_t inbytes_left, outbytes_left;
558 for (cp = w; *cp != '\0'; ++cp) {
559 native = apr_xlate_conv_byte(ap_hdrs_from_ascii, *cp);
560 if (apr_isprint(*cp) && !apr_isprint(native))
562 if (!apr_isprint(*cp) && apr_isprint(native))
565 if (maybeASCII > maybeEBCDIC) {
566 ap_log_error(SCRIPT_LOG_MARK, APLOG_ERR, 0, r->server,
567 APLOGNO(02660) "CGI Interface Error: "
568 "Script headers apparently ASCII: (CGI = %s)",
570 inbytes_left = outbytes_left = cp - w;
571 apr_xlate_conv_buffer(ap_hdrs_from_ascii,
572 w, &inbytes_left, w, &outbytes_left);
575 #endif /*APR_CHARSET_EBCDIC*/
576 if (!(l = strchr(w, ':'))) {
578 /* Soak up all the script output - may save an outright kill */
579 while ((*getsfunc)(w, MAX_STRING_LEN - 1, getsfunc_data) > 0) {
584 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_ERR|APLOG_TOCLIENT, 0, r,
585 "malformed header from script '%s': Bad header: %.30s",
586 apr_filepath_name_get(r->filename), w);
587 return HTTP_INTERNAL_SERVER_ERROR;
591 while (apr_isspace(*l)) {
595 if (!strcasecmp(w, "Content-type")) {
598 /* Nuke trailing whitespace */
600 char *endp = l + strlen(l) - 1;
601 while (endp > l && apr_isspace(*endp)) {
605 tmp = apr_pstrdup(r->pool, l);
606 ap_content_type_tolower(tmp);
607 ap_set_content_type(r, tmp);
610 * If the script returned a specific status, that's what
611 * we'll use - otherwise we assume 200 OK.
613 else if (!strcasecmp(w, "Status")) {
614 r->status = cgi_status = atoi(l);
615 if (!ap_is_HTTP_VALID_RESPONSE(cgi_status))
616 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_ERR|APLOG_TOCLIENT, 0, r,
617 "Invalid status line from script '%s': %.30s",
618 apr_filepath_name_get(r->filename), l);
621 ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE1, 0, r,
622 "Status line from script '%s': %.30s",
623 apr_filepath_name_get(r->filename), l);
624 r->status_line = apr_pstrdup(r->pool, l);
626 else if (!strcasecmp(w, "Location")) {
627 apr_table_set(r->headers_out, w, l);
629 else if (!strcasecmp(w, "Content-Length")) {
630 apr_table_set(r->headers_out, w, l);
632 else if (!strcasecmp(w, "Content-Range")) {
633 apr_table_set(r->headers_out, w, l);
635 else if (!strcasecmp(w, "Transfer-Encoding")) {
636 apr_table_set(r->headers_out, w, l);
638 else if (!strcasecmp(w, "ETag")) {
639 apr_table_set(r->headers_out, w, l);
642 * If the script gave us a Last-Modified header, we can't just
643 * pass it on blindly because of restrictions on future values.
645 else if (!strcasecmp(w, "Last-Modified")) {
646 ap_update_mtime(r, apr_date_parse_http(l));
647 ap_set_last_modified(r);
649 else if (!strcasecmp(w, "Set-Cookie")) {
650 apr_table_add(cookie_table, w, l);
653 apr_table_add(merge, w, l);
657 /* never reached - we leave this function within the while loop above */
661 AP_DECLARE(int) ap_scan_script_header_err_core(request_rec *r, char *buffer,
662 int (*getsfunc) (char *, int, void *),
665 return ap_scan_script_header_err_core_ex(r, buffer, getsfunc,
670 static int getsfunc_FILE(char *buf, int len, void *f)
672 return apr_file_gets(buf, len, (apr_file_t *) f) == APR_SUCCESS;
675 AP_DECLARE(int) ap_scan_script_header_err(request_rec *r, apr_file_t *f,
678 return ap_scan_script_header_err_core_ex(r, buffer, getsfunc_FILE, f,
682 AP_DECLARE(int) ap_scan_script_header_err_ex(request_rec *r, apr_file_t *f,
683 char *buffer, int module_index)
685 return ap_scan_script_header_err_core_ex(r, buffer, getsfunc_FILE, f,
690 static int getsfunc_BRIGADE(char *buf, int len, void *arg)
692 apr_bucket_brigade *bb = (apr_bucket_brigade *)arg;
693 const char *dst_end = buf + len - 1; /* leave room for terminating null */
695 apr_bucket *e = APR_BRIGADE_FIRST(bb);
699 while ((dst < dst_end) && !done && e != APR_BRIGADE_SENTINEL(bb)
700 && !APR_BUCKET_IS_EOS(e)) {
701 const char *bucket_data;
702 apr_size_t bucket_data_len;
707 rv = apr_bucket_read(e, &bucket_data, &bucket_data_len,
709 if (rv != APR_SUCCESS || (bucket_data_len == 0)) {
711 return APR_STATUS_IS_TIMEUP(rv) ? -1 : 0;
714 src_end = bucket_data + bucket_data_len;
715 while ((src < src_end) && (dst < dst_end) && !done) {
719 else if (*src != '\r') {
726 apr_bucket_split(e, src - bucket_data);
728 next = APR_BUCKET_NEXT(e);
729 apr_bucket_delete(e);
736 AP_DECLARE(int) ap_scan_script_header_err_brigade(request_rec *r,
737 apr_bucket_brigade *bb,
740 return ap_scan_script_header_err_core_ex(r, buffer, getsfunc_BRIGADE, bb,
744 AP_DECLARE(int) ap_scan_script_header_err_brigade_ex(request_rec *r,
745 apr_bucket_brigade *bb,
749 return ap_scan_script_header_err_core_ex(r, buffer, getsfunc_BRIGADE, bb,
760 static int getsfunc_STRING(char *w, int len, void *pvastrs)
762 struct vastrs *strs = (struct vastrs*) pvastrs;
766 if (!strs->curpos || !*strs->curpos) {
770 p = ap_strchr_c(strs->curpos, '\n');
774 p = ap_strchr_c(strs->curpos, '\0');
775 t = p - strs->curpos;
778 strncpy (w, strs->curpos, t);
780 if (!strs->curpos[t]) {
782 strs->curpos = va_arg(strs->args, const char *);
789 /* ap_scan_script_header_err_strs() accepts additional const char* args...
790 * each is treated as one or more header lines, and the first non-header
791 * character is returned to **arg, **data. (The first optional arg is
794 AP_DECLARE_NONSTD(int) ap_scan_script_header_err_strs_ex(request_rec *r,
803 va_start(strs.args, termarg);
805 strs.curpos = va_arg(strs.args, char*);
806 res = ap_scan_script_header_err_core_ex(r, buffer, getsfunc_STRING,
807 (void *) &strs, module_index);
809 *termch = strs.curpos;
816 AP_DECLARE_NONSTD(int) ap_scan_script_header_err_strs(request_rec *r,
824 va_start(strs.args, termarg);
826 strs.curpos = va_arg(strs.args, char*);
827 res = ap_scan_script_header_err_core_ex(r, buffer, getsfunc_STRING,
828 (void *) &strs, APLOG_MODULE_INDEX);
830 *termch = strs.curpos;
838 argstr_to_table(char *str, apr_table_t *parms)
848 key = apr_strtok(str, "&", &strtok_state);
850 value = strchr(key, '=');
852 *value = '\0'; /* Split the string in two */
853 value++; /* Skip passed the = */
858 ap_unescape_url(key);
859 ap_unescape_url(value);
860 apr_table_set(parms, key, value);
861 key = apr_strtok(NULL, "&", &strtok_state);
865 AP_DECLARE(void) ap_args_to_table(request_rec *r, apr_table_t **table)
867 apr_table_t *t = apr_table_make(r->pool, 10);
868 argstr_to_table(apr_pstrdup(r->pool, r->args), t);